prefers-reduced-motion: reduce causes crash in custom dialogs if reopened quickly

[odinhb]

Whether you set alertify.defaults.transitionOff = true, alertify.defaults.transition = null or use chromium devtools to "Emulate CSS prefers-reduced-motion: reduce" (by using the command palette, Ctrl+Shift+P) all these result in the same crash.

I have reproduced the issue in a jsfiddle here: https://jsfiddle.net/m9o3sed0/8/

alertify-transition-crash-reproduction-example.webm

The crash happens when opening, closing and reopening the dialog in quick succession (like an automated browser test). It doesn't happen unless transitions/animations are somehow disabled.

It also doesn't happen unless you set closeEvent.cancel = true (like in the jsfiddle) and use .destroy() to close it instead.

The crash happens here (it might be a little annoying to get a stack trace from jsfiddle, but you should be able to do it in devtools):

AlertifyJS/src/js/dialog/transition.js

Line 11 in 8dde6f1

clearTimeout(instance.__internal.timerIn);

Because instance.__internal === undefined.

The use case for calling .destroy() in this manner instead of letting the default behaviour (close event?) close the dialog is that we want to open another nested dialog and wait for that one to .destroy() the first one.

This bug is reproducible all the way back to alertify v1.5.0, when .destroy() was introduced.