refactor: move KaosProcess out of Kaos #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to astral-sh/ty#2080, this usage seems to be not wel-defined, and not supported by `ty` Signed-off-by: tianxiao <shentianxiao@moonshot.cn>
There was a problem hiding this comment.
Pull request overview
This PR refactors the KaosProcess protocol by moving it from a nested class Kaos.Process to a top-level protocol KaosProcess. This change addresses compatibility issues with the ty type checker tool that doesn't properly support nested Protocol classes. The refactoring reverses a previous design decision from v0.5.0 where KaosProcess was originally moved into Kaos.Process.
Key changes:
- Extract
KaosProcessas a standalone Protocol at the module level in__init__.py - Update all type annotations from
Kaos.ProcesstoKaosProcessacross the codebase - Add
KaosProcessto imports inssh.pyandlocal.py
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/kaos/init.py | Moves KaosProcess protocol from nested Kaos.Process to top-level and updates the Kaos.exec return type annotation |
| src/kaos/ssh.py | Adds KaosProcess to imports and updates exec method return type from Kaos.Process to KaosProcess |
| src/kaos/local.py | Adds KaosProcess to imports and updates exec method return type from Kaos.Process to KaosProcess |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
cc @stdrc @powerfooI |
Collaborator
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to astral-sh/ty#2080, this usage seems to be not wel-defined, and not supported by
tySigned-off-by: tianxiao shentianxiao@moonshot.cn