Add optional centroid reporting to Butina clustering#82
Merged
scal444 merged 2 commits intoNVIDIA-Digital-Bio:mainfrom Jan 30, 2026
Merged
Add optional centroid reporting to Butina clustering#82scal444 merged 2 commits intoNVIDIA-Digital-Bio:mainfrom
scal444 merged 2 commits intoNVIDIA-Digital-Bio:mainfrom
Conversation
Contributor
Greptile Overview
|
| Filename | Overview |
|---|---|
| nvmolkit/clustering.cpp | Added toOwnedPyArray helper and conditional centroid return logic with proper memory management |
| src/butina.h | Added optional centroids parameter and return value for cluster count to both GPU entry points |
| src/butina.cu | Threaded centroids through all kernels, added remapCentroidsKernel, and returns cluster count |
evasnow1992
approved these changes
Jan 30, 2026
Collaborator
evasnow1992
left a comment
There was a problem hiding this comment.
Thank you for addressing the user request. Code changes are clean and valid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #74