Replace deprecated Class.newInstance()#3312
Open
SethSmucker wants to merge 12 commits intointegrationfrom
Open
Replace deprecated Class.newInstance()#3312SethSmucker wants to merge 12 commits intointegrationfrom
SethSmucker wants to merge 12 commits intointegrationfrom
Conversation
…newInstance() Class.newInstance() has been deprecated since Java 9 because it propagates exceptions thrown by the nullary constructor, including checked exceptions. The replacement getDeclaredConstructor().newInstance() wraps such exceptions in an InvocationTargetException. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
53 tasks
Collaborator
|
There are additional occurrences of |
- QueryIterator.java: c.newInstance() -> c.getDeclaredConstructor().newInstance() - AggregatingReducer.java: clazz.newInstance() -> clazz.getDeclaredConstructor().newInstance() - Updated exception handling in related methods and overrides
…eprecated-class-newinstance
foster33
requested changes
Jan 9, 2026
Collaborator
foster33
left a comment
foster33
left a comment
There was a problem hiding this comment.
There seems to be 4 more uses of Class.newInstance(). I will go ahead and make those changes.
foster33
previously approved these changes
Jan 15, 2026
apmoriarty
reviewed
Jan 16, 2026
...house/ingest-core/src/main/java/datawave/ingest/mapreduce/job/reduce/AggregatingReducer.java
Outdated
Show resolved
Hide resolved
Collaborator
|
One additional usage that needs to be replaced:
|
…eprecated-class-newinstance
…eprecated-class-newinstance
…eprecated-class-newinstance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Class.newInstance()withgetDeclaredConstructor().newInstance()ReflectiveOperationException(covers the additional exceptions from the new API)Files Changed
DatawaveMetricsConfig.javaProtostuffHttpMessageConverter.javaFixes #3311
Part of #2443
🤖 Generated with Claude Code