Replace non-public TabletClosedException and ScanTimedOutException#3318
Open
SethSmucker wants to merge 6 commits intointegrationfrom
Open
Replace non-public TabletClosedException and ScanTimedOutException#3318SethSmucker wants to merge 6 commits intointegrationfrom
SethSmucker wants to merge 6 commits intointegrationfrom
Conversation
…onpublic-exceptions
This was referenced Jan 6, 2026
foster33
reviewed
Jan 7, 2026
| if (isScanTimedOutException(e)) { | ||
| // this is okay. This means that we are being timesliced. | ||
| myScan.addRange(currentRange); | ||
| return this; |
Collaborator
There was a problem hiding this comment.
Should we be returning this here? Just curious because it was not in the original catch block you removed
This was referenced Jan 23, 2026
…onpublic-exceptions
…onpublic-exceptions
…onpublic-exceptions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
instanceof TabletClosedExceptionwith class name checkcatch (ScanTimedOutException)with class name check inside generic catch blockFiles Changed
QueryIterator.java- TabletClosedExceptionDocIdQueryIterator.java- TabletClosedExceptionDocumentIterator.java- TabletClosedExceptionScan.java- ScanTimedOutExceptionApproach
Since these are non-public Accumulo classes that won't exist in Accumulo 4, we use class name comparison:
Fixes #3317
Part of #2443