fix error 'length is read-only`. Use defineProperty

Author: ammarahm-ed

test-app/runtime/src/main/cpp/napi/common/native_api_util.h

@@ -166,6 +166,16 @@ namespace napi_util {
         return napi_define_properties(env, object, 1, &desc);
     }
 
+    inline napi_status define_property_value(napi_env env, napi_value object, const char *propertyName,
+                                       napi_value value = nullptr, napi_property_attributes attributes = napi_default_jsproperty, void *data = nullptr) {
+        return napi_util::define_property(env, object, propertyName, value, nullptr, nullptr, data, attributes);
+    }
+
+    inline napi_status define_property_get_set(napi_env env, napi_value object, const char *propertyName,
+                                       napi_callback getter, napi_callback setter, napi_property_attributes attributes = napi_default_jsproperty, void *data = nullptr) {
+        return napi_util::define_property(env, object, propertyName, nullptr, getter, setter, data, attributes);
+    }
+
     inline void setPrototypeOf(napi_env env, napi_value object, napi_value prototype) {
         napi_value global, global_object, set_proto;
 

test-app/runtime/src/main/cpp/runtime/metadata/MetadataNode.cpp

@@ -1085,7 +1085,7 @@ std::vector<MetadataNode::MethodCallbackData *> MetadataNode::SetClassMembersFro
                 napi_create_function(env, methodName.c_str(), methodName.size(), MethodCallback,
                                      callbackData, &method);
 
-                napi_set_named_property(env, prototype, methodName.c_str(), method);
+                napi_util::define_property_value(env, prototype, methodName.c_str(), method, napi_default_method);
                 lastMethodName = methodName;
                 collectedExtensionMethods.emplace(methodName, callbackData);
 
@@ -1112,7 +1112,7 @@ std::vector<MetadataNode::MethodCallbackData *> MetadataNode::SetClassMembersFro
                 napi_value method;
                 napi_create_function(env, methodName.c_str(), methodName.size(), MethodCallback,
                                      callbackData, &method);
-                napi_set_named_property(env, prototype, methodName.c_str(), method);
+                napi_util::define_property_value(env, prototype, methodName.c_str(), method, napi_default_method);
                 collectedExtensionMethods.emplace(methodName, callbackData);
             }
 
@@ -1199,7 +1199,8 @@ std::vector<MetadataNode::MethodCallbackData *> MetadataNode::SetClassMembersFro
             napi_value method;
             napi_create_function(env, methodName.c_str(), methodName.size(), MethodCallback,
                                  callbackData, &method);
-            napi_set_named_property(env, constructor, methodName.c_str(), method);
+
+            napi_util::define_property_value(env, constructor, methodName.c_str(), method, napi_default_method);
             lastMethodName = methodName;
         }
         callbackData->candidates.push_back(std::move(entry));
@@ -1234,6 +1235,7 @@ std::vector<MetadataNode::MethodCallbackData *> MetadataNode::SetClassMembersFro
                             ArgConverter::convertToJsString(env, tname));
 
     SetClassAccessor(env, constructor);
+
     return instanceMethodData;
 }
 
@@ -1992,7 +1994,7 @@ napi_value MetadataNode::MethodCallback(napi_env env, napi_callback_info info) {
 
 
         if (argc == 0 && methodName == PROP_KEY_VALUEOF) {
-            return jsThis;
+            return jsThis; 
         } else {
 //            Runtime::GetRuntime(env)->clearPendingError();
             bool isFromInterface = initialCallbackData->node->IsNodeTypeInterface();