Skip to content

[chore] update pyproject.toml and other workflows to use uv#1080

Open
deven367 wants to merge 26 commits intomainfrom
ci-updates
Open

[chore] update pyproject.toml and other workflows to use uv#1080
deven367 wants to merge 26 commits intomainfrom
ci-updates

Conversation

@deven367
Copy link
Collaborator

@deven367 deven367 commented Jan 22, 2026

  • Drops support for Python 3.9, and adds support for Python 3.14
  • Migrates to group-dependency instead of project.optional-dependencies in pyproject.toml
  • Update workflows to use uv

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 22, 2026

Merging this PR will not alter performance

✅ 6 untouched benchmarks


Comparing ci-updates (4098178) with main (65569e1)

Open in CodSpeed

@CLAassistant
Copy link

CLAassistant commented Feb 3, 2026

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ deven367
❌ elephaint
You have signed the CLA already but the status is still pending? Let us recheck it.

@elephaint
Copy link
Contributor

Code Review Summary

Security Issues

.github/workflows/pytest.yml - Actions not pinned to specific SHA hashes:

  • Line 24: actions/checkout@v4 - should be pinned like other workflows
  • Line 28: actions/setup-python@v5 - should be pinned like other workflows
  • Line 33: astral-sh/setup-uv@v5 - should be pinned like other workflows

Other workflows (build-docs.yaml, ci.yaml, lint.yaml) properly pin these actions to specific commit SHAs.

Test Coverage Issues

action_files/test_ray.py:6 - Outdated skip condition:

if sys.version_info >= (3, 12):
    pytest.skip("Ray requires Python<3.12", allow_module_level=True)

This skips Ray tests for Python >= 3.12, but according to the PR's changes, Ray is only unavailable for Python 3.14+. The condition should be sys.version_info >= (3, 14) to match other Ray-related skips in the codebase.

Code Quality Issues

tests/test_distributed_fugue.py:10-12 - Unused imports:

  • DaskExecutionEngine from fugue_dask
  • SparkSession from pyspark.sql

pyproject.toml - Dependency group version inconsistencies:

  • Line 71: dask group uses fugue[dask]>=0.8.1
  • Line 81: all group uses fugue[dask]>=0.9.4
  • Line 76: spark group uses fugue[spark]>=0.8.1
  • Line 82: all group uses fugue[spark]>=0.9.4

Consider aligning these version constraints.

Minor Consistency Notes

  • File extension: pytest.yml uses .yml while all other workflows use .yaml
  • Lint workflow uses actions/setup-python@42375524e23c412d93fb67b49958b491fce71c38 # 5.4.0 while other workflows use v5.6.0

elephaint
elephaint previously approved these changes Feb 3, 2026
Copy link
Contributor

@elephaint elephaint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, non-blocking comments (see below and further in the thread)

elephaint
elephaint previously approved these changes Feb 19, 2026
@deven367 deven367 enabled auto-merge (squash) February 19, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments