[chore] update pyproject.toml and other workflows to use uv#1080
[chore] update pyproject.toml and other workflows to use uv#1080
pyproject.toml and other workflows to use uv#1080Conversation
|
|
Code Review SummarySecurity Issues.github/workflows/pytest.yml - Actions not pinned to specific SHA hashes:
Other workflows (build-docs.yaml, ci.yaml, lint.yaml) properly pin these actions to specific commit SHAs. Test Coverage Issuesaction_files/test_ray.py:6 - Outdated skip condition: if sys.version_info >= (3, 12):
pytest.skip("Ray requires Python<3.12", allow_module_level=True)This skips Ray tests for Python >= 3.12, but according to the PR's changes, Ray is only unavailable for Python 3.14+. The condition should be Code Quality Issuestests/test_distributed_fugue.py:10-12 - Unused imports:
pyproject.toml - Dependency group version inconsistencies:
Consider aligning these version constraints. Minor Consistency Notes
|
elephaint
left a comment
There was a problem hiding this comment.
Looks good to me, non-blocking comments (see below and further in the thread)
group-dependencyinstead ofproject.optional-dependenciesin pyproject.tomluv