[FIX] project_sequence: support preexisting sequenceless projects

Author: arnaudlayec

project_sequence/models/project_project.py

@@ -76,7 +76,7 @@ def create(self, vals_list):
         # It is important to set sequence_code before calling super() because
         # other modules such as hr_timesheet expect the name to always have a value
         for vals in vals_list:
-            if not vals.get("sequence_code", False):
+            if "sequence_code" not in vals:
                 vals["sequence_code"] = self.env["ir.sequence"].next_by_code(
                     "project.sequence"
                 )

project_sequence/tests/test_project_sequence.py

@@ -111,35 +111,16 @@ def test_sequence_unique(self):
     @users("manager")
     def test_project_without_sequence(self):
         """Preexisting projects had no sequence, and they should display fine."""
-        proj1 = self.env["project.project"].search(
-            [
-                ("sequence_code", "=", False),
-            ],
-            limit=1,
+        proj1 = self.env["project.project"].create(
+            {"name": "one", "sequence_code": False}
         )
-        proj1.name = "one"
-        self.assertFalse(proj1.sequence_code)
         self.assertEqual(proj1.display_name, "one")
+        self.assertFalse(proj1.sequence_code)
         # Make sure that the sequence is not increased
         proj2 = self.env["project.project"].create({"name": "two"})
         self.assertEqual(proj2.sequence_code, "23-00011")
         self.assertEqual(proj2.display_name, "23-00011 - two")
 
-    @users("manager")
-    def test_project_with_empty_sequence(self):
-        """Sequence is applied when creating project with an empty sequence"""
-        proj1 = self.env["project.project"].create(
-            {"name": "whatever", "sequence_code": ""}
-        )
-        self.assertEqual(proj1.sequence_code, "23-00011")
-        self.assertEqual(proj1.display_name, "23-00011 - whatever")
-        # Sequence is applied when creating project with sequence in False
-        proj2 = self.env["project.project"].create(
-            {"name": "whatever", "sequence_code": False}
-        )
-        self.assertEqual(proj2.sequence_code, "23-00012")
-        self.assertEqual(proj2.display_name, "23-00012 - whatever")
-
     def test_custom_pattern(self):
         """Display name pattern can be customized."""
         self.env["ir.config_parameter"].set_param(