Add fullname/parent properties to the builders

Author: OoLunar

src/CommandAllExtension.cs

@@ -175,9 +175,34 @@ private async Task DiscordClient_ReadyAsync(DiscordClient sender, ReadyEventArgs
             // Prevent the event handler from being executed multiple times.
             Client.Ready -= DiscordClient_ReadyAsync;
 
-            foreach (CommandBuilder command in CommandManager.CommandBuilders.Values)
+            // Iterate through all the commands and ensure that all the parameters can be converted.
+            foreach (CommandBuilder commandBuilder in CommandManager.CommandBuilders.Values)
             {
-                SaturateParametersRecursively(command);
+                if (!ArgumentConverterManager.TrySaturateParameters(commandBuilder.GetAllParameters(), out IEnumerable<CommandParameterBuilder>? failedParameters))
+                {
+                    foreach (CommandParameterBuilder parameterBuilder in failedParameters!)
+                    {
+                        if (parameterBuilder.OverloadBuilder is null)
+                        {
+                            throw new InvalidOperationException($"OverloadBuilder is null on parameter {parameterBuilder}.");
+                        }
+                        else if (parameterBuilder.OverloadBuilder.Command is null)
+                        {
+                            throw new InvalidOperationException($"Command is null on overload {parameterBuilder.OverloadBuilder}.");
+                        }
+
+                        parameterBuilder.OverloadBuilder.Flags |= CommandOverloadFlags.Disabled;
+                        if (parameterBuilder.OverloadBuilder.Command.Overloads.All(x => x.Flags.HasFlag(CommandOverloadFlags.Disabled)))
+                        {
+                            _logger.LogError("Disabling command {Command} due to all overloads being disabled.", commandBuilder);
+                            parameterBuilder.OverloadBuilder!.Command.Flags |= CommandFlags.Disabled;
+                        }
+                        else if (!parameterBuilder.OverloadBuilder.Command.Flags.HasFlag(CommandFlags.Disabled))
+                        {
+                            _logger.LogWarning("Disabling overload {CommandOverload} due to missing converters for the following parameters: {FailedParameters}", parameterBuilder.OverloadBuilder, parameterBuilder);
+                        }
+                    }
+                }
             }
 
             await _configureCommands.InvokeAsync(this, new ConfigureCommandsEventArgs(this, CommandManager));

src/Commands/Builders/Commands/CommandBuilder.cs

@@ -41,6 +41,12 @@ public sealed class CommandBuilder : Builder
         /// <inheritdoc cref="Command.SlashMetadata"/>
         public CommandSlashMetadataBuilder SlashMetadata { get; set; }
 
+        /// <inheritdoc cref="Command.Parent"/>
+        public CommandBuilder? Parent { get; set; }
+
+        /// <inheritdoc cref="Command.FullName"/>
+        public string? FullName => Parent is null ? Name : $"{Parent.FullName} {Name}";
+
         /// <inheritdoc/>
         public CommandBuilder(CommandAllExtension commandAllExtension) : base(commandAllExtension) => SlashMetadata = new(commandAllExtension);
 
@@ -85,6 +91,22 @@ public void NormalizeOverloadPriorities()
             Overloads = overloads;
         }
 
+        public IReadOnlyList<CommandParameterBuilder> GetAllParameters()
+        {
+            List<CommandParameterBuilder> parameters = new();
+            foreach (CommandOverloadBuilder overload in Overloads)
+            {
+                parameters.AddRange(overload.Parameters);
+            }
+
+            foreach (CommandBuilder subcommand in Subcommands)
+            {
+                parameters.AddRange(subcommand.GetAllParameters());
+            }
+
+            return parameters.AsReadOnly();
+        }
+
         /// <inheritdoc/>
         [MemberNotNull(nameof(Name), nameof(Description))]
         public override void Verify()
@@ -227,6 +249,7 @@ private static bool TryParse(CommandAllExtension commandAllExtension, Type type,
                 // Take the description from the first overload that has it.
                 foreach (CommandOverloadBuilder overload in builder.Overloads)
                 {
+                    overload.Command = builder;
                     if (overload.Method.GetCustomAttribute<DescriptionAttribute>() is DescriptionAttribute descriptionAttribute)
                     {
                         builder.Description = descriptionAttribute.Description;
@@ -264,6 +287,11 @@ private static bool TryParse(CommandAllExtension commandAllExtension, Type type,
                     Subcommands = new(commandBuilders),
                 };
 
+                foreach (CommandBuilder subcommand in builder.Subcommands)
+                {
+                    subcommand.Parent = builder;
+                }
+
                 builders = new[] { builder };
                 error = null;
                 return true;

src/Commands/Builders/Commands/CommandOverloadBuilder.cs

@@ -7,6 +7,7 @@
 using OoLunar.DSharpPlus.CommandAll.Attributes;
 using OoLunar.DSharpPlus.CommandAll.Commands.Builders.SlashMetadata;
 using OoLunar.DSharpPlus.CommandAll.Commands.Enums;
+using OoLunar.DSharpPlus.CommandAll.Commands.System.Commands;
 using OoLunar.DSharpPlus.CommandAll.Exceptions;
 
 namespace OoLunar.DSharpPlus.CommandAll.Commands.Builders.Commands
@@ -32,6 +33,9 @@ public sealed class CommandOverloadBuilder : Builder
         /// <inheritdoc cref="CommandOverload.SlashMetadata"/>
         public CommandOverloadSlashMetadataBuilder SlashMetadata { get; set; }
 
+        /// <inheritdoc cref="CommandOverload.Command"/>
+        public CommandBuilder? Command { get; set; }
+
         /// <inheritdoc/>
         public CommandOverloadBuilder(CommandAllExtension commandAllExtension) : base(commandAllExtension) => SlashMetadata = new(commandAllExtension);
 
@@ -141,6 +145,7 @@ public static bool TryParse(CommandAllExtension commandAllExtension, MethodInfo
                     return false;
                 }
 
+                parameterBuilder.OverloadBuilder = builder;
                 parameterBuilders.Add(parameterBuilder);
             }
 

src/Commands/Builders/Commands/CommandParameterBuilder.cs

@@ -11,6 +11,7 @@
 using OoLunar.DSharpPlus.CommandAll.Commands.Arguments;
 using OoLunar.DSharpPlus.CommandAll.Commands.Builders.SlashMetadata;
 using OoLunar.DSharpPlus.CommandAll.Commands.Enums;
+using OoLunar.DSharpPlus.CommandAll.Commands.System.Commands;
 using OoLunar.DSharpPlus.CommandAll.Converters;
 using OoLunar.DSharpPlus.CommandAll.Exceptions;
 
@@ -46,6 +47,9 @@ public sealed class CommandParameterBuilder : Builder
         /// <inheritdoc cref="CommandParameter.SlashMetadata"/>
         public CommandParameterSlashMetadataBuilder SlashMetadata { get; set; }
 
+        /// <inheritdoc cref="CommandParameter.Overload"/>
+        public CommandOverloadBuilder? OverloadBuilder { get; set; }
+
         /// <inheritdoc/>
         public CommandParameterBuilder(CommandAllExtension commandAllExtension) : base(commandAllExtension) => SlashMetadata = new(commandAllExtension);
 

src/Managers/CommandManager.cs

@@ -7,6 +7,7 @@
 using Microsoft.Extensions.Logging;
 using OoLunar.DSharpPlus.CommandAll.Commands;
 using OoLunar.DSharpPlus.CommandAll.Commands.Builders.Commands;
+using OoLunar.DSharpPlus.CommandAll.Commands.Enums;
 using OoLunar.DSharpPlus.CommandAll.Commands.System.Commands;
 using OoLunar.DSharpPlus.CommandAll.Exceptions;
 
@@ -79,12 +80,16 @@ public void BuildCommands()
             {
                 try
                 {
-                    if (!commandBuilder.TryVerify(out Exception? error))
+                    if (commandBuilder.Flags.HasFlag(CommandFlags.Disabled))
+                    {
+                        continue;
+                    }
+                    else if (!commandBuilder.TryVerify(out Exception? error))
                     {
                         _logger.LogError(error, "Failed to verify command builder {CommandBuilder}", commandBuilder);
                         continue;
                     }
-                    else if (commands.TryGetValue(commandBuilder.Name!, out Command? existingCommand))
+                    else if (commands.TryGetValue(commandBuilder.Name, out Command? existingCommand))
                     {
                         _logger.LogError("Command {ExistingCommand} already has the name {ExistingCommandName}. Unable to add {CommandBuilder}", existingCommand, existingCommand.Name, commandBuilder);
                         continue;