test: use SymTest within FixedSizeMemoryStack

Author: waelsy123

contracts/utils/FixedSizeMemoryStack.sol

@@ -49,9 +49,7 @@ library FixedSizeMemoryStack {
         uint256 t = stack._top;
         if (t >= stack._data.length) revert StackOverflow(stack._data.length);
         stack._data[t] = value;
-        unchecked {
-            stack._top = t + 1;
-        }
+        stack._top = t + 1;
     }
 
     /// @notice Pop the top value from the stack.
@@ -60,9 +58,7 @@ library FixedSizeMemoryStack {
     function pop(Stack memory stack) internal pure returns (bytes32 value) {
         uint256 t = stack._top;
         if (t == 0) revert StackUnderflow();
-        unchecked {
-            t -= 1;
-        }
+        t -= 1;
         value = stack._data[t];
         stack._top = t;
     }

test/utils/FixedSizeMemoryStack.t.sol

@@ -36,17 +36,24 @@ contract FixedSizeMemoryStackTest is Test, SymTest {
     }
 
     /// forge-config: default.allow_internal_expect_revert = true
-    function testPeek() public {
+    function testPeekStackUnderflow() public {
         FixedSizeMemoryStack.Stack memory stack = FixedSizeMemoryStack.init(10);
 
         vm.expectRevert(abi.encodeWithSelector(FixedSizeMemoryStack.StackUnderflow.selector));
         stack.peek();
         assertEq(stack._top, 0);
+    }
 
-        stack.push(bytes32(uint256(1)));
-        stack.push(bytes32(uint256(2)));
+    function testPeek() public {
+        FixedSizeMemoryStack.Stack memory stack = FixedSizeMemoryStack.init(10);
+
+        bytes32 item1 = svm.createBytes32("item1");
+        bytes32 item2 = svm.createBytes32("item2");
 
-        assertEq(stack.peek(), bytes32(uint256(2)));
+        stack.push(item1);
+        stack.push(item2);
+
+        assertEq(stack.peek(), item2);
         assertEq(stack._top, 2);
     }
 
@@ -55,10 +62,13 @@ contract FixedSizeMemoryStackTest is Test, SymTest {
 
         assertEq(stack.size(), 0);
 
-        stack.push(bytes32(uint256(1)));
+        bytes32 item1 = svm.createBytes32("item1");
+        bytes32 item2 = svm.createBytes32("item2");
+
+        stack.push(item1);
         assertEq(stack.size(), 1);
 
-        stack.push(bytes32(uint256(2)));
+        stack.push(item2);
         assertEq(stack.size(), 2);
 
         stack.pop();
@@ -79,7 +89,9 @@ contract FixedSizeMemoryStackTest is Test, SymTest {
 
         assertEq(stack.isEmpty(), true);
 
-        stack.push(bytes32(uint256(1)));
+        bytes32 item1 = svm.createBytes32("item1");
+
+        stack.push(item1);
         assertEq(stack.isEmpty(), false);
 
         stack.pop();
@@ -91,11 +103,14 @@ contract FixedSizeMemoryStackTest is Test, SymTest {
 
         assertEq(stack.isFull(), false);
 
-        stack.push(bytes32(uint256(1)));
+        bytes32 item1 = svm.createBytes32("item1");
+
+        stack.push(item1);
         assertEq(stack.isFull(), false);
 
         for (uint256 i = 0; i < 9; i++) {
-            stack.push(bytes32(uint256(i)));
+            bytes32 item = svm.createBytes32(string(abi.encodePacked("item", i)));
+            stack.push(item);
         }
 
         assertEq(stack.isFull(), true);
@@ -107,8 +122,11 @@ contract FixedSizeMemoryStackTest is Test, SymTest {
     function testClear() public {
         FixedSizeMemoryStack.Stack memory stack = FixedSizeMemoryStack.init(10);
 
-        stack.push(bytes32(uint256(1)));
-        stack.push(bytes32(uint256(2)));
+        bytes32 item1 = svm.createBytes32("item1");
+        bytes32 item2 = svm.createBytes32("item2");
+
+        stack.push(item1);
+        stack.push(item2);
 
         stack.clear();