Skip to content

Commit 8a7b66d

Browse files
committed
Merge remote-tracking branch 'origin/dev'
2 parents 4450f60 + 0fd6d9b commit 8a7b66d

36 files changed

+1010
-388
lines changed

CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,10 @@
1+
### 1.4.122 - 2019/01/01
2+
* Updated the crafting bench options for 3.5
3+
* Added support for most of the new craft modifiers
4+
* Applied the weapon restriction changes from 3.5
5+
* Adrenaline can now always be enabled (as it is no longer exclusive to Champion)
6+
* Fixed issue with modifiers to socketed gem level applying twice
7+
18
### 1.4.121 - 2018/12/12
29
* Applied the unique balance changes for 3.5
310
* Added base radius values for Vortex (20), Armageddon Brand (18/8), Winter Orb (16), and the Banner skills (40)

Classes/ItemsTab.lua

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1555,8 +1555,14 @@ function ItemsTabClass:AddCustomModifierToDisplayItem()
15551555
if sourceId == "MASTER" then
15561556
for _, craft in ipairs(self.build.data.masterMods) do
15571557
if craft.types[self.displayItem.type] then
1558+
local label
1559+
if craft.master then
1560+
label = craft.master .. " " .. craft.masterLevel .. " "..craft.type:sub(1,3).."^8[" .. table.concat(craft, "/") .. "]"
1561+
else
1562+
label = table.concat(craft, "/")
1563+
end
15581564
t_insert(modList, {
1559-
label = craft.master .. " " .. craft.masterLevel .. " "..craft.type:sub(1,3).."^8[" .. table.concat(craft, "/") .. "]",
1565+
label = label,
15601566
mod = craft,
15611567
type = "crafted",
15621568
})
@@ -1606,8 +1612,10 @@ function ItemsTabClass:AddCustomModifierToDisplayItem()
16061612
end)
16071613
end
16081614
end
1615+
if self.build.targetVersion ~= "2_6" or (self.displayItem.type ~= "Jewel" and self.displayItem.type ~= "Flask") then
1616+
t_insert(sourceList, { label = "Crafting Bench", sourceId = "MASTER" })
1617+
end
16091618
if self.displayItem.type ~= "Jewel" and self.displayItem.type ~= "Flask" then
1610-
t_insert(sourceList, { label = "Master", sourceId = "MASTER" })
16111619
t_insert(sourceList, { label = "Essence", sourceId = "ESSENCE" })
16121620
end
16131621
if not self.displayItem.crafted then
@@ -1634,7 +1642,7 @@ function ItemsTabClass:AddCustomModifierToDisplayItem()
16341642
return item
16351643
end
16361644
controls.sourceLabel = new("LabelControl", {"TOPRIGHT",nil,"TOPLEFT"}, 95, 20, 0, 16, "^7Source:")
1637-
controls.source = new("DropDownControl", {"TOPLEFT",nil,"TOPLEFT"}, 100, 20, 100, 18, sourceList, function(index, value)
1645+
controls.source = new("DropDownControl", {"TOPLEFT",nil,"TOPLEFT"}, 100, 20, 150, 18, sourceList, function(index, value)
16381646
buildMods(value.sourceId)
16391647
controls.modSelect:SetSel(1)
16401648
end)

Data/2_6/ModCache.lua

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

Data/2_6/Skills/act_dex.lua

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,6 @@ skills["AnimateWeapon"] = {
127127
[30] = { 90, 45, },
128128
},
129129
}
130-
131130
skills["NewArcticArmour"] = {
132131
name = "Arctic Armour",
133132
color = 2,
@@ -245,9 +244,9 @@ skills["Barrage"] = {
245244
name = "All Projectiles",
246245
},
247246
},
248-
setupFunc = function(actor, output)
249-
if actor.mainSkill.skillPart == 2 then
250-
actor.mainSkill.skillData.dpsMultiplier = output.ProjectileCount
247+
setupFunc = function(activeSkill, output)
248+
if activeSkill.skillPart == 2 then
249+
activeSkill.skillData.dpsMultiplier = output.ProjectileCount
251250
end
252251
end,
253252
baseFlags = {
@@ -1718,8 +1717,8 @@ skills["DetonateDead"] = {
17181717
color = 2,
17191718
description = "Explodes an unused corpse, dealing fire damage to nearby enemies.",
17201719
skillTypes = { [39] = true, [10] = true, [11] = true, [17] = true, [18] = true, [19] = true, [26] = true, [36] = true, [33] = true, },
1721-
setupFunc = function(actor, output)
1722-
local skillData = actor.mainSkill.skillData
1720+
setupFunc = function(activeSkill, output)
1721+
local skillData = activeSkill.skillData
17231722
if skillData.corpseLife then
17241723
skillData.FireMin = skillData.FireMin + skillData.corpseLife * 0.06
17251724
skillData.FireMax = skillData.FireMax + skillData.corpseLife * 0.06
@@ -1820,8 +1819,8 @@ skills["VaalDetonateDead"] = {
18201819
color = 2,
18211820
description = "Explodes an unused corpse, dealing fire damage to nearby enemies. Nearby corpses will also explode in a chain reaction.",
18221821
skillTypes = { [39] = true, [10] = true, [11] = true, [17] = true, [18] = true, [19] = true, [26] = true, [43] = true, [33] = true, },
1823-
setupFunc = function(actor, output)
1824-
local skillData = actor.mainSkill.skillData
1822+
setupFunc = function(activeSkill, output)
1823+
local skillData = activeSkill.skillData
18251824
if skillData.corpseLife then
18261825
skillData.FireMin = skillData.FireMin + skillData.corpseLife * 0.08
18271826
skillData.FireMax = skillData.FireMax + skillData.corpseLife * 0.08

Data/2_6/Skills/act_int.lua

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3125,9 +3125,9 @@ skills["FreezingPulse"] = {
31253125
color = 3,
31263126
description = "An icy projectile which has a chance to freeze enemies it passes through. The projectile fades quickly, reducing damage and freezing chance until it runs out of time and dissipates completely.",
31273127
skillTypes = { [2] = true, [3] = true, [10] = true, [17] = true, [18] = true, [19] = true, [26] = true, [36] = true, [34] = true, [60] = true, },
3128-
setupFunc = function(env, output)
3129-
env.modDB:NewMod("Damage", "MORE", -100, "Skill:Freezing Pulse", ModFlag.Spell, { type = "DistanceRamp", ramp = {{0,0},{60*output.ProjectileSpeedMod,1}} })
3130-
env.modDB:NewMod("EnemyFreezeChance", "BASE", 25, "Skill:Freezing Pulse", { type = "DistanceRamp", ramp = {{0,1},{15*output.ProjectileSpeedMod,0}} })
3128+
setupFunc = function(activeSkill, output)
3129+
activeSkill.skillModList:NewMod("Damage", "MORE", -100, "Skill:Freezing Pulse", ModFlag.Spell, { type = "DistanceRamp", ramp = {{0,0},{60*output.ProjectileSpeedMod,1}} })
3130+
activeSkill.skillModList:NewMod("EnemyFreezeChance", "BASE", 25, "Skill:Freezing Pulse", { type = "DistanceRamp", ramp = {{0,1},{15*output.ProjectileSpeedMod,0}} })
31313131
end,
31323132
baseFlags = {
31333133
spell = true,
@@ -5620,11 +5620,11 @@ skills["RighteousFire"] = {
56205620
color = 3,
56215621
description = "Engulfs you in magical fire that rapidly burns you and nearby enemies. Your spell damage is substantially increased while under this effect. The effect ends when you have 1 life remaining.",
56225622
skillTypes = { [2] = true, [5] = true, [11] = true, [18] = true, [29] = true, [36] = true, [40] = true, [33] = true, },
5623-
setupFunc = function(actor, output)
5624-
if actor.mainSkill.skillFlags.totem then
5625-
actor.mainSkill.skillData.FireDot = output.TotemLife * 0.5
5623+
setupFunc = function(activeSkill, output)
5624+
if activeSkill.skillFlags.totem then
5625+
activeSkill.skillData.FireDot = output.TotemLife * 0.5
56265626
else
5627-
actor.mainSkill.skillData.FireDot = (output.Life + output.EnergyShield) * 0.5
5627+
activeSkill.skillData.FireDot = (output.Life + output.EnergyShield) * 0.5
56285628
end
56295629
end,
56305630
statMap = {
@@ -5736,9 +5736,9 @@ skills["VaalRighteousFire"] = {
57365736
color = 3,
57375737
description = "A fiery blast removes your energy shield and all but 1 life, exploding outwards to deal fire damage to nearby enemies based on the life and energy shield lost.",
57385738
skillTypes = { [2] = true, [11] = true, [10] = true, [43] = true, [33] = true, },
5739-
setupFunc = function(actor, output)
5740-
actor.mainSkill.skillData.FireMin = output.EnergyShield + output.Life - 1
5741-
actor.mainSkill.skillData.FireMax = output.EnergyShield + output.Life - 1
5739+
setupFunc = function(activeSkill, output)
5740+
activeSkill.skillData.FireMin = output.EnergyShield + output.Life - 1
5741+
activeSkill.skillData.FireMax = output.EnergyShield + output.Life - 1
57425742
end,
57435743
baseFlags = {
57445744
spell = true,

Data/2_6/Skills/sup_dex.lua

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -988,7 +988,7 @@ skills["SupportAdditionalQuality"] = {
988988
supportGemsOnly = true,
989989
statMap = {
990990
["supported_active_skill_gem_quality_%"] = {
991-
mod("GemProperty", "LIST", { keyword = "active_skill", key = "quality", value = nil }),
991+
mod("SupportedGemProperty", "LIST", { keyword = "active_skill", key = "quality", value = nil }),
992992
},
993993
},
994994
qualityStats = {

Data/2_6/Skills/sup_str.lua

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -552,7 +552,7 @@ skills["SupportAdditionalLevel"] = {
552552
supportGemsOnly = true,
553553
statMap = {
554554
["supported_active_skill_gem_level_+"] = {
555-
mod("GemProperty", "LIST", { keyword = "active_skill", key = "level", value = nil }),
555+
mod("SupportedGemProperty", "LIST", { keyword = "active_skill", key = "level", value = nil }),
556556
},
557557
},
558558
qualityStats = {

Data/3_0/ModCache.lua

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)