Skip to content

Commit 29d4ece

Browse files
committed
quick feedback
1 parent b1754e5 commit 29d4ece

File tree

2 files changed

+16
-13
lines changed

2 files changed

+16
-13
lines changed

.github/workflows/ci.yml

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ jobs:
1616
uses: actions/setup-go@v6
1717
with:
1818
go-version: ${{ env.go-version }}
19-
- name: Install Task
20-
run: go install github.com/go-task/task/v3/cmd/task@${{ env.task-version }}
19+
# - name: Install Task
20+
# run: go install github.com/go-task/task/v3/cmd/task@${{ env.task-version }}
2121
- name: Checkout code
2222
uses: actions/checkout@v6
2323
with:
@@ -26,10 +26,12 @@ jobs:
2626
# the repo). Following the Principle of least privilege, we disable this as long
2727
# as we don't need it.
2828
persist-credentials: false
29-
- run: task ci:setup
30-
- run: task lint
31-
- run: task build
32-
- run: task test:all
29+
# - run: task ci:setup
30+
# - run: task lint
31+
# - run: task build
32+
- run: go build ./...
33+
# - run: task test:all
34+
- run: go test ./... -v
3335
env:
3436
GOKIT_TEST_OAUTH_TOKEN: ${{ secrets.GOKIT_TEST_OAUTH_TOKEN }}
3537
GOKIT_TEST_GH_APP_PRIVATE_KEY: |

Taskfile.yml

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,14 @@ vars:
99

1010
tasks:
1111

12+
ci:setup:
13+
desc: Useful only when running under CI.
14+
cmds:
15+
- task: install:deps
16+
# Running "go mod download" is optional, since "go build" would do it anyway.
17+
# We run it explicitly to make the output of "go build" more focused.
18+
- cmd: go mod download -x
19+
1220
install:deps:
1321
desc: Install tool dependencies.
1422
cmds:
@@ -65,10 +73,3 @@ tasks:
6573
- rm -f coverage.out
6674
- rm -r -f bin
6775

68-
ci:setup:
69-
desc: Useful only when running under CI.
70-
cmds:
71-
- task: install:deps
72-
# Running "go mod download" is optional, since "go build" would do it anyway.
73-
# We run it explicitly to make the output of "go build" more focused.
74-
- cmd: go mod download -x

0 commit comments

Comments
 (0)