github action lint

Author: iAmoric

github/commitstatus.go

@@ -135,7 +135,7 @@ func (cs CommitStatus) Add(ctx context.Context, sha, state, targetURL, descripti
 		if err != nil {
 			return fmt.Errorf("http client Do: %w", err)
 		}
-		defer resp.Body.Close()
+		defer resp.Body.Close() //nolint:errcheck
 
 		elapsed := time.Since(start)
 		remaining := resp.Header.Get("X-RateLimit-Remaining")

github/commitstatus_test.go

@@ -61,7 +61,7 @@ func TestGitHubStatusSuccessMockAPI(t *testing.T) {
 	now := time.Now()
 	desc := now.Format("15:04:05")
 
-	run := func(t *testing.T, tc testCase) {
+	test := func(t *testing.T, tc testCase) {
 		attempt := 0
 		handler := func(w http.ResponseWriter, r *http.Request) {
 			response := tc.response[attempt]
@@ -71,7 +71,10 @@ func TestGitHubStatusSuccessMockAPI(t *testing.T) {
 			w.Header().Set("x-ratelimit-remaining", response.rateLimitRemaining)
 			w.Header().Set("x-ratelimit-reset", strconv.Itoa(int(response.rateLimitReset)))
 			w.WriteHeader(response.status)
-			fmt.Fprintln(w, response.body)
+			_, err := fmt.Fprintln(w, response.body)
+			if err != nil {
+				t.Fatalf("writing response body: %s", err)
+			}
 			attempt++
 		}
 		ts := httptest.NewServer(http.HandlerFunc(handler))
@@ -180,7 +183,7 @@ func TestGitHubStatusSuccessMockAPI(t *testing.T) {
 	}
 
 	for _, tc := range testCases {
-		t.Run(tc.name, func(t *testing.T) { run(t, tc) })
+		t.Run(tc.name, func(t *testing.T) { test(t, tc) })
 	}
 }
 
@@ -218,7 +221,10 @@ func TestGitHubStatusFailureMockAPI(t *testing.T) {
 			// for better control.
 			w.Header().Set("Date", now.Format(time.RFC1123))
 			w.WriteHeader(response.status)
-			fmt.Fprintln(w, response.body)
+			_, err := fmt.Fprintln(w, response.body)
+			if err != nil {
+				t.Fatalf("writing response body: %s", err)
+			}
 			attempt++
 		}
 		ts := httptest.NewServer(http.HandlerFunc(handler))

github/githubapp.go

@@ -76,7 +76,7 @@ func GenerateInstallationToken(ctx context.Context, client *http.Client, server
 	if err != nil {
 		return "", fmt.Errorf("http client Do: %s", err)
 	}
-	defer resp.Body.Close()
+	defer resp.Body.Close() //nolint:errcheck
 
 	body, errBody := io.ReadAll(resp.Body)
 	if resp.StatusCode != http.StatusCreated {

github/githubapp_test.go

@@ -23,18 +23,27 @@ func TestGenerateInstallationToken(t *testing.T) {
 	handler := func(w http.ResponseWriter, r *http.Request) {
 		if r.Method != http.MethodPost {
 			w.WriteHeader(http.StatusMethodNotAllowed)
-			fmt.Fprintln(w, "wrong HTTP method")
+			_, err := fmt.Fprintln(w, "wrong HTTP method")
+			if err != nil {
+				t.Fatalf("writing response: %s", err)
+			}
 			return
 		}
 
 		claims := decodeJWT(t, r, privateKey)
 		if claims.Issuer != clientID {
 			w.WriteHeader(http.StatusUnauthorized)
-			fmt.Fprintln(w, "unauthorized: wrong JWT token")
+			_, err := fmt.Fprintln(w, "unauthorized: wrong JWT token")
+			if err != nil {
+				t.Fatalf("writing response: %s", err)
+			}
 			return
 		}
 		w.WriteHeader(http.StatusCreated)
-		fmt.Fprintln(w, `{"token": "dummy_installation_token"}`)
+		_, err := fmt.Fprintln(w, `{"token": "dummy_installation_token"}`)
+		if err != nil {
+			t.Fatalf("writing response: %s", err)
+		}
 	}
 
 	ts := httptest.NewServer(http.HandlerFunc(handler))