-
Notifications
You must be signed in to change notification settings - Fork 187
Description
While #1737 does prevent a man in the middle from stealing an existing account after you joined the server once, there is still the possibility of taking over your account when you join for the first time.
This could be fixed by properly checking the server certificate using TLS.
Joining by direct IP should of course always remain without the certificate check.
This would require either relying on the existing certificate authority infrastructure (how easy is it to get a certificate nowadays?), or making our own certificate authority (since we control the application this is actually a valid option).
Making our own certificate authority could have certain advantages, since we have control over who gets a certificate (→we could effectively ban servers that misbehave, that could also be seen as a disadvantage though), and how much they pay for it(→this could be a potential revenue source if the project grows).