[Bug]: Users' Deleted Messages Are Not Logged After Leaving The Server

[ExpertGem-Official]

Checked Existing

• I have checked the repository for duplicate issues.

What happened?

When a message is deleted, either by a moderator or by the original poster, these messages are generally logged in a private #‎chubby-log channel. Only certain members (i.e. Discord moderators) are able to access this channel. (Side note: even if a moderater deletes someone else's message, the user mentioned in the User and Author fields is always the same, but this is better saved for another issue report.)

However, if a user is to leave the server, and one of their messages is later deleted by a moderator, that message will not be logged. An example can be found in https://discord.com/channels/408718485913468928/975405493075988561/1469147691794567168 (only Discord moderators and other staff can access this link). It's worth noting that a similar behavior occurs when a member is kicked or banned using either Clyde (built-in) or Chubby, and the user's messages from up to the past seven days are deleted via either of these commands; however, none of these message deletion events are ever logged, although this could be intentional.

What did you expect to happen?

If a user's message is deleted, regardless of whether this user is currently a member of the Discord server, the deletion event should be logged in #‎chubby-log.

Steps to reproduce?

1. A user joins the server.
2. The user sends a message, then
3. leaves the server.
4. A Discord moderator or a user with the Manage Messages permission then deletes that message.
5. The deletion is not logged in #‎chubby-log.
6. However, it is possible to see this action for a limited period of time via the built-in Audit Log, if another user deleted this message.

Other relevant information. (OPTIONAL)

No response

[jonbarrow]

I haven't looked into the specifics of this yet, but I suspect it has to do with this line:

chubby/src/events/messageDelete.ts

Lines 10 to 12 in 7a99f4e

	if (message.author.bot || !message.member) {
	return;
	}

According to Discord.js, Message.member is only available if the sender is part of the server:

Represents the author of the message as a guild member. Only available if the message comes from a guild where the author is still a member

The only purpose of checking for message.member here is because we use it to get user, which is an instance of the User class

However as you said here:

the user mentioned in the User and Author fields is always the same, but this is better saved for another issue report

The message.author field is ALSO an instance of the User class, so this check for getting the member and such seems to be pointless?