fix bug

Author: ProjektGopher

routes/web.php

@@ -4,10 +4,14 @@
 
 use Illuminate\Support\Facades\Route;
 use Projektgopher\Scrawl\Blog;
+use Symfony\Component\HttpKernel\Exception\HttpException;
 
 Route::get('blog/{slug}', function ($slug) {
+    if (! Blog::isPublished($slug)) {
+        // abort(404, 'We couldn\'t find this post.');
+        // throw new HttpException(404, 'We couldn\'t find this post.');
+        return response(status: 404, content: 'We couldn\'t find this post.');
+    }
 
-    return Blog::isPublished($slug)
-        ? response(status: 200, content: Blog::asHtml($slug))
-        : response(status: 404);
+    return response(status: 200, content: Blog::asHtml($slug));
 });

src/Blog.php

@@ -12,7 +12,7 @@ class Blog
 
     public static function isPublished($slug): bool
     {
-        return File::exists(self::$publishedDirectory . "/{$slug}.md");
+        return File::exists(base_path(self::$publishedDirectory . "/{$slug}.md"));
     }
 
     public static function asHtml($slug): string
@@ -25,7 +25,7 @@ public static function asHtml($slug): string
         );
 
         return (string) $converter->convertToHtml(
-            File::get(self::$publishedDirectory . "/{$slug}.md")
+            File::get(base_path(self::$publishedDirectory . "/{$slug}.md"))
         );
     }
 }

tests/routes/RoutesTest.php

@@ -18,13 +18,14 @@ public function it_registers_a_blog_post_route()
     /** @test */
     public function it_returns_a_200_if_the_blog_exists()
     {
+        $this->withoutExceptionHandling();
         File::shouldReceive('exists')
             ->once()
-            ->with('resources/blogs/published/test.md')
+            ->with(base_path('resources/blogs/published/test.md'))
             ->andReturn(true);
         File::shouldReceive('get')
             ->once()
-            ->with('resources/blogs/published/test.md')
+            ->with(base_path('resources/blogs/published/test.md'))
             ->andReturn('test');
 
         $this->get('/blog/test')->assertOk();
@@ -33,9 +34,10 @@ public function it_returns_a_200_if_the_blog_exists()
     /** @test */
     public function it_returns_a_404_if_the_blog_does_not_exist()
     {
+        $this->withoutExceptionHandling();
         File::shouldReceive('exists')
             ->once()
-            ->with('resources/blogs/published/does-not-exist.md')
+            ->with(base_path('resources/blogs/published/does-not-exist.md'))
             ->andReturn(false);
 
         $this->get('/blog/does-not-exist')->assertStatus(404);
@@ -44,13 +46,14 @@ public function it_returns_a_404_if_the_blog_does_not_exist()
     /** @test */
     public function it_converts_md_to_html()
     {
+        $this->withoutExceptionHandling();
         File::shouldReceive('exists')
             ->once()
-            ->with('resources/blogs/published/published-post.md')
+            ->with(base_path('resources/blogs/published/published-post.md'))
             ->andReturn(true);
         File::shouldReceive('get')
             ->once()
-            ->with('resources/blogs/published/published-post.md')
+            ->with(base_path('resources/blogs/published/published-post.md'))
             ->andReturn('# Hello World!');
 
         $this->get('/blog/published-post')