-
Notifications
You must be signed in to change notification settings - Fork 112
Open
Labels
bugSomething isn't workingSomething isn't workingskylineSkyline application changes - create Skyline/work branchSkyline application changes - create Skyline/work branch
Description
Summary
The "View > Retention Times > Molecule Comparison" menu navigation correctly displays "Molecule Comparison", but the graph's right-click context menu and its submenus inconsistently use "Peptide" terminology instead of adapting to the UI mode setting.
Transferred from: skyline.ms Issue #1048
Problems
- Right-click context menu items on RT, peak area, and mass error comparison graphs are not translated for UI mode
- "Graph" submenu shows "Peptide Comparison" instead of "Molecule Comparison" in small molecule/mixed mode
Root Cause
- The
BuildRTGraphMenu, peak area, and mass error context menu builders inSkylineGraphs.csdid not callPeptideToMoleculeTextMapper.TranslateMenuItemsafter populating context menus TranslateMenuItemsonly translates top-level menu items — it does not recurse intoDropDownItemsof submenus, so nested items like "Peptide Comparison" under the "Graph" submenu were never translated
Fix
Added a CleanupZedGraphMenuItems helper method in SkylineGraphs.cs that:
- Removes unwanted ZedGraph menu items (
set_default,show_val) - Calls
PeptideToMoleculeTextMapper.TranslateMenuItemson top-level context menu items - Recurses into dropdown submenus to translate nested items (e.g., "Peptide Comparison" → "Molecule Comparison")
Applied to all 3 affected context menu builder methods. This also eliminates code duplication — the remove + translate pattern was repeated identically in each method.
Files Modified
pwiz_tools/Skyline/SkylineGraphs.cs
Verification
Tested with TestMultiSelectPeakAreaGraphAsSmallMolecules using PauseTest() to visually confirm:
- Graph title says "Molecule Comparison"
- Right-click context menu items use "Molecule" terminology
- "Graph" submenu shows "Molecule Comparison" instead of "Peptide Comparison"
Getting Started
Use /pw-startissue to begin work.
Transferred from: skyline.ms Issue #1048
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingskylineSkyline application changes - create Skyline/work branchSkyline application changes - create Skyline/work branch