take the branch on the right when splitting rnd-lazy, etc.

Author: marke000

src/provisdom/math/random.clj

@@ -374,13 +374,14 @@
 
 (defn rnd-lazy
   "Creates a lazy sequence of random doubles from independent RNGs.
-  
+
   Parameters:
     `rng` - Initial random number generator
-  
+
   Returns a lazy sequence of doubles in [0, 1)."
   [rng]
-  (map rand-double (rng-lazy rng)))
+  (let [[_ rng-branch] (split rng)]
+    (map rand-double (rng-lazy rng-branch))))
 
 (s/fdef rnd-lazy
   :args (s/cat :rng ::rng)
@@ -394,7 +395,8 @@
 
   Returns a lazy sequence of random longs."
   [rng]
-  (map rand-long (rng-lazy rng)))
+  (let [[_ rng-branch] (split rng)]
+    (map rand-long (rng-lazy rng-branch))))
 
 (s/fdef rnd-long-lazy
   :args (s/cat :rng ::rng)
@@ -674,7 +676,8 @@
 
   Returns a vector of doubles in `[0, 1)`."
   [rng n]
-  (mapv rand-double (take n (rng-lazy rng))))
+  (let [[_ rng-branch] (split rng)]
+    (mapv rand-double (take n (rng-lazy rng-branch)))))
 
 (s/fdef rnd-doubles
   :args (s/cat :rng ::rng :n ::n)
@@ -703,7 +706,8 @@
 
   Returns a vector of random longs."
   [rng n]
-  (mapv rand-long (take n (rng-lazy rng))))
+  (let [[_ rng-branch] (split rng)]
+    (mapv rand-long (take n (rng-lazy rng-branch)))))
 
 (s/fdef rnd-longs
   :args (s/cat :rng ::rng :n ::n)
@@ -732,7 +736,8 @@
 
   Returns a vector of standard normal values (`mean=0`, `std=1`)."
   [rng n]
-  (mapv (comp random-normal rand-double) (take n (rng-lazy rng))))
+  (let [[_ rng-branch] (split rng)]
+    (mapv (comp random-normal rand-double) (take n (rng-lazy rng-branch)))))
 
 (s/fdef rnd-normals
   :args (s/cat :rng ::rng :n ::n)

test/provisdom/math/matrix_test.clj

@@ -368,12 +368,12 @@
     (random/bind-seed 0
       (t/is= [[]] (mx/rnd-matrix! 0 0)))
     (random/bind-seed 0
-      (t/is= [[0.2961287401299688 0.8622994122994543]
-              [0.07868284113948965 0.548683671433349]]
+      (t/is= [[0.0023434341918648904 0.355610453579705]
+              [0.8462878193318439 0.6940010275147983]]
         (mx/rnd-matrix! 2 2)))
     (random/bind-seed 0
-      (t/is= [[0.2961287401299688 0.8622994122994543 0.07868284113948965]
-              [0.548683671433349 0.11620266042486127 0.5772125043785624]]
+      (t/is= [[0.0023434341918648904 0.355610453579705 0.8462878193318439]
+              [0.6940010275147983 0.8119067024046234 0.14220466649514807]]
         (mx/rnd-matrix! 2 3)))))
 
 (t/deftest rnd-reflection-matrix!-test
@@ -385,8 +385,8 @@
     (random/bind-seed 0
       (t/is= [[-1.0]] (mx/rnd-reflection-matrix! 1)))
     (random/bind-seed 0
-      (t/is= [[0.7890118105552666 -0.6143780292330612]
-              [-0.6143780292330612 -0.7890118105552668]]
+      (t/is= [[0.9999131504400358 -0.013179210032561553]
+              [-0.013179210032561553 -0.9999131504400356]]
         (mx/rnd-reflection-matrix! 2)))))
 
 (t/deftest rnd-spectral-matrix!-test
@@ -398,8 +398,8 @@
     (random/bind-seed 0
       (t/is= [[2.0]] (mx/rnd-spectral-matrix! [2.0])))
     (random/bind-seed 0
-      (t/is= [[2.9987560086952176 0.04986416644446639]
-              [0.04986416644446639 1.0012439913047837]]
+      (t/is= [[1.3315052401244662 -0.7437168520471685]
+              [-0.7437168520471685 2.668494759875535]]
         (mx/rnd-spectral-matrix! [1.0 3.0])))))
 
 (t/deftest sparse->matrix-test

test/provisdom/math/random_test.clj

@@ -102,14 +102,14 @@
   (t/with-instrument `random/rnd-lazy
     (t/is-spec-check random/rnd-lazy))
   (t/with-instrument :all
-    (t/is= '(0.17343824438608113 0.5672348695804793 0.4407296095269242)
+    (t/is= '(0.6647522234423441 0.9435968775103368 0.11310782708569878)
       (take 3 (random/rnd-lazy (random/rng 3))))))
 
 (t/deftest rnd-long-lazy-test
   (t/with-instrument `random/rnd-long-lazy
     (t/is-spec-check random/rnd-long-lazy))
   (t/with-instrument :all
-    (t/is= '(3199370906783531226 -7983107604874433585 8130026312649114387)
+    (t/is= '(-6184229935439241264 -1040453965524906477 2086471138983279185)
       (take 3 (random/rnd-long-lazy (random/rng 3))))))
 
 ;;;BOUND RNG
@@ -167,14 +167,14 @@
   (t/with-instrument `random/rnd-lazy!
     (t/is-spec-check random/rnd-lazy!))
   (t/with-instrument :all
-    (t/is= '(0.17343824438608113 0.5672348695804793 0.4407296095269242)
+    (t/is= '(0.6647522234423441 0.9435968775103368 0.11310782708569878)
       (take 3 (random/bind-seed 3 (random/rnd-lazy!))))))
 
 (t/deftest rnd-long-lazy!-test
   (t/with-instrument `random/rnd-long-lazy!
     (t/is-spec-check random/rnd-long-lazy!))
   (t/with-instrument :all
-    (t/is= '(3199370906783531226 -7983107604874433585 8130026312649114387)
+    (t/is= '(-6184229935439241264 -1040453965524906477 2086471138983279185)
       (take 3 (random/bind-seed 3 (random/rnd-long-lazy!))))))
 
 ;;;USE CLOCK
@@ -219,43 +219,43 @@
   (t/with-instrument `random/rnd-doubles
     (t/is-spec-check random/rnd-doubles))
   (t/with-instrument :all
-    (t/is= [0.17343824438608113 0.5672348695804793 0.4407296095269242]
+    (t/is= [0.6647522234423441 0.9435968775103368 0.11310782708569878]
       (random/rnd-doubles (random/rng 3) 3))
     (t/is= [] (random/rnd-doubles (random/rng 3) 0))))
 
 (t/deftest rnd-doubles!-test
   (t/with-instrument `random/rnd-doubles!
     (t/is-spec-check random/rnd-doubles!))
   (t/with-instrument :all
-    (t/is= [0.17343824438608113 0.5672348695804793 0.4407296095269242]
+    (t/is= [0.6647522234423441 0.9435968775103368 0.11310782708569878]
       (random/bind-seed 3 (random/rnd-doubles! 3)))))
 
 (t/deftest rnd-longs-test
   (t/with-instrument `random/rnd-longs
     (t/is-spec-check random/rnd-longs))
   (t/with-instrument :all
-    (t/is= [3199370906783531226 -7983107604874433585 8130026312649114387]
+    (t/is= [-6184229935439241264 -1040453965524906477 2086471138983279185]
       (random/rnd-longs (random/rng 3) 3))))
 
 (t/deftest rnd-longs!-test
   (t/with-instrument `random/rnd-longs!
     (t/is-spec-check random/rnd-longs!))
   (t/with-instrument :all
-    (t/is= [3199370906783531226 -7983107604874433585 8130026312649114387]
+    (t/is= [-6184229935439241264 -1040453965524906477 2086471138983279185]
       (random/bind-seed 3 (random/rnd-longs! 3)))))
 
 (t/deftest rnd-normals-test
   (t/with-instrument `random/rnd-normals
     (t/is-spec-check random/rnd-normals))
   (t/with-instrument :all
-    (t/is= [-0.9406651398679139 0.16933867009164844 -0.14911965219889575]
+    (t/is= [0.4254679878903436 1.58570499753794 -1.2101648206296136]
       (random/rnd-normals (random/rng 3) 3))))
 
 (t/deftest rnd-normals!-test
   (t/with-instrument `random/rnd-normals!
     (t/is-spec-check random/rnd-normals!))
   (t/with-instrument :all
-    (t/is= [-0.9406651398679139 0.16933867009164844 -0.14911965219889575]
+    (t/is= [0.4254679878903436 1.58570499753794 -1.2101648206296136]
       (random/bind-seed 3 (random/rnd-normals! 3)))))
 
 ;;;CONVENIENCE FUNCTIONS

test/provisdom/math/tensor_test.clj

@@ -90,14 +90,14 @@
     (t/is-spec-check tensor/rnd-tensor! {:num-tests 20}))
   (t/with-instrument :all
     (random/bind-seed 0
-      (t/is= 0.2961287401299688 (tensor/rnd-tensor! [])))
+      (t/is= 0.0023434341918648904 (tensor/rnd-tensor! [])))
     (random/bind-seed 0
       (t/is= [] (tensor/rnd-tensor! [0])))
     (random/bind-seed 0
       (t/is= [[]] (tensor/rnd-tensor! [1 0])))
     (random/bind-seed 0
-      (t/is= [[0.2961287401299688 0.8622994122994543 0.07868284113948965]
-              [0.548683671433349 0.11620266042486127 0.5772125043785624]]
+      (t/is= [[0.0023434341918648904 0.355610453579705 0.8462878193318439]
+              [0.6940010275147983 0.8119067024046234 0.14220466649514807]]
         (tensor/rnd-tensor! [2 3])))))
 
 ;;INFO
@@ -143,7 +143,7 @@
                                   (boolean (and (seq indices)
                                              (> (first indices) v))))
                 [1.0 0.5]))
-    (t/is (tensor/every-kv? (fn [indices v]
+    (t/is (tensor/every-kv? (fn [indices _v]
                               (boolean (and (seq indices)
                                          (> (first indices) -1))))
             [1.0 0.5]))

test/provisdom/math/vector_test.clj

@@ -127,9 +127,9 @@
     (random/bind-seed 0
       (t/is= [] (vector/rnd-vector! 0)))
     (random/bind-seed 0
-      (t/is= [0.2961287401299688] (vector/rnd-vector! 1)))
+      (t/is= [0.0023434341918648904] (vector/rnd-vector! 1)))
     (random/bind-seed 0
-      (t/is= [0.2961287401299688 0.8622994122994543] (vector/rnd-vector! 2)))))
+      (t/is= [0.0023434341918648904 0.355610453579705] (vector/rnd-vector! 2)))))
 
 (t/deftest sparse->vector-test
   (t/with-instrument `vector/sparse->vector