Skip to content

Commit 9bb78f9

Browse files
authored
Merge pull request #230 from Sebanisu/fix-skip-bgbtl_1-
Bug: Fix bgbtl_1 was getting skipped on swizzle batch operations.
2 parents 12f45a5 + 893c10e commit 9bb78f9

File tree

7 files changed

+9
-24
lines changed

7 files changed

+9
-24
lines changed

.github/workflows/main-1.0.0.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: Field-Map-Editor
22

3-
run-name: 1.0.4.${{ github.run_number }}
3+
run-name: 1.0.5.${{ github.run_number }}
44

55
on:
66
workflow_dispatch:
@@ -52,7 +52,7 @@ jobs:
5252
run: ".github/workflows/build.ps1"
5353
shell: pwsh
5454
env:
55-
_BUILD_VERSION: "1.0.4.${{ github.run_number }}"
55+
_BUILD_VERSION: "1.0.5.${{ github.run_number }}"
5656
GITHUB_PACKAGES_PAT: ${{ secrets.GITHUB_TOKEN }}
5757
- name: Upload vcpkg build logs
5858
if: failure()

.github/workflows/ubuntu.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# See: https://github.com/actions/starter-workflows/blob/main/ci/cmake-multi-platform.yml
33
name: Field-Map-Editor-linux
44

5-
run-name: 1.0.4.${{ github.run_number }}
5+
run-name: 1.0.5.${{ github.run_number }}
66

77
on:
88
workflow_dispatch:

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ endif()
2323

2424
project(
2525
Field-Map-Editor
26-
VERSION 1.0.4
26+
VERSION 1.0.5
2727
LANGUAGES C CXX)
2828

2929
set(CMAKE_CXX_STANDARD "23")

changelog.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
All notable changes to the Field-Map-Editor project will be documented in this file, based on the available tags from the GitHub repository. Versions are sorted from the largest to the smallest number, with Canary representing the unreleased changes.
44

5-
## [canary] - To be 1.0.4
5+
## [canary] - To be 1.0.5
66

77
[Release](https://github.com/Sebanisu/Field-Map-Editor/releases/tag/canary)
88

src/opengl/main/gui/batch.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,7 @@ void fme::batch::draw_window()
103103
auto config = Configuration(config_path);
104104
config.save();
105105
}
106+
spdlog::info("Batch operation completed.");
106107
}
107108
prev_disabled = disabled;
108109

@@ -1425,6 +1426,7 @@ void fme::batch::button_start()
14251426
{
14261427
return;
14271428
}
1429+
spdlog::info("Starting batch operation.");
14281430
if (
14291431
selections->get<ConfigKey::BatchOutputType>()
14301432
== output_types::deswizzle_generate_toml)
@@ -2431,6 +2433,7 @@ void fme::batch::stop()
24312433
m_field.reset();
24322434
m_coo.reset();
24332435
m_status.clear();
2436+
spdlog::info("Stopping batch operation.");
24342437
}
24352438

24362439
fme::batch::batch(

src/opengl/main/map_sprite.cpp

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -2437,15 +2437,6 @@ const ff_8::MapHistory::nsat_map &map_sprite::working_animation_counts() const
24372437
// Adjust scale based on texture height or deswizzle state.
24382438
std::int32_t height = static_cast<std::int32_t>(get_max_texture_height());
24392439

2440-
// If there’s only one bpp and at most one palette, nothing needs
2441-
// saving.
2442-
if (
2443-
unique_bpp.size() == 1U
2444-
&& unique_values.palette().at(unique_bpp.front()).values().size() <= 1U)
2445-
{
2446-
return {};
2447-
}
2448-
24492440
// Prepare for gathering palette conflicts.
24502441
using map_type = std::remove_cvref_t<decltype(get_conflicting_palettes())>;
24512442
using mapped_type = typename map_type::mapped_type;
@@ -2631,15 +2622,6 @@ const ff_8::MapHistory::nsat_map &map_sprite::working_animation_counts() const
26312622
= ((256 * static_cast<std::int32_t>(max_texture_page_id)) + max_source_x)
26322623
* m_render_framebuffer->scale();
26332624

2634-
// If there’s only one bpp and at most one palette, nothing needs
2635-
// saving.
2636-
if (
2637-
unique_bpp.size() == 1U
2638-
&& unique_values.palette().at(unique_bpp.front()).values().size() <= 1U)
2639-
{
2640-
return {};
2641-
}
2642-
26432625
// Prepare for gathering palette conflicts.
26442626
const auto conflicting_palettes_map = get_conflicting_palettes();
26452627
auto conflicting_palettes_flatten

vcpkg.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "field-map-editor",
3-
"version": "1.0.4",
3+
"version": "1.0.5",
44
"builtin-baseline": "4334d8b4c8916018600212ab4dd4bbdc343065d1",
55
"dependencies": [
66
"lz4",

0 commit comments

Comments
 (0)