"end" autocompletion off when new line applied with formatOnType: true

[martinbarilik]

Description

Honestly no idea what am i doing wrong, but i use lsp more then a year now and it was always like that for me. Maybe it has something to do with non-standard tab-4-spaces indentation.

I'd be great if i didn't have to use arrow up whenever i create new method / class

Only way i can "workaround" this is to turn off formatOnType flag

Ruby LSP Information

VS Code Version

1.96.4

Ruby LSP Extension Version

0.9.2

Ruby LSP Server Version

0.23.9

Ruby LSP Add-ons

• Ruby LSP RSpec
• Ruby LSP Rails
• RuboCop

Ruby Version

3.3.5

Ruby Version Manager

rvm

Installed Extensions

Click to expand

• auto-rename-tag (0.1.10)
• material-icon-theme (5.19.0)
• prettier-vscode (11.0.0)
• ruby-lsp (0.9.2)
• simple-ruby-erb (0.2.0)
• theme-monokai-pro-vscode (2.0.6)
• vscode-erb-beautify (0.5.0)
• vscode-todo-highlight (1.0.5)

Ruby LSP Settings

Click to expand

Workspace

{}

User

{
  "enabledFeatures": {
    "codeActions": true,
    "diagnostics": true,
    "documentHighlights": true,
    "documentLink": true,
    "documentSymbols": true,
    "foldingRanges": true,
    "formatting": true,
    "hover": true,
    "inlayHint": true,
    "onTypeFormatting": true,
    "selectionRanges": true,
    "semanticHighlighting": true,
    "completion": true,
    "codeLens": true,
    "definition": true,
    "workspaceSymbol": true,
    "signatureHelp": true,
    "typeHierarchy": true
  },
  "featuresConfiguration": {},
  "addonSettings": {},
  "rubyVersionManager": {
    "identifier": "auto"
  },
  "customRubyCommand": "",
  "formatter": "auto",
  "linters": null,
  "bundleGemfile": "",
  "testTimeout": 30,
  "branch": "",
  "pullDiagnosticsOn": "both",
  "useBundlerCompose": false,
  "bypassTypechecker": false,
  "rubyExecutablePath": "",
  "indexing": {},
  "erbSupport": true,
  "featureFlags": {
    "all": true
  }
}

Reproduction steps

1. Type def test
2. hit enter

expected behaviour

class Test
    def test
        # cursor here
    end
end

current behaviour

class Test
    def test
        
end# cursor here
end

[shanecav84]

This is happening for me because I'm using VSCodium, which isn't explicitly supported as a client when moving the cursor on format

ruby-lsp/lib/ruby_lsp/requests/on_type_formatting.rb

Lines 165 to 166 in d50e558

	def move_cursor_to(line, character)
	return unless /Visual Studio Code|Cursor/.match?(@client_name)

@martinbarilik Are you using VSCodium or another VSCode variant?

[martinbarilik]

I am indeed using VSCodium.

Should we just add VSCodium to regex in PR or ?

edit: ok, i see you are lightning fast :) thanks for the PR @shanecav84

[martinbarilik]

@shanecav84 did the 0.9.9 / 0.9.10 version fix the issue for you ?