Skip to content

Commit 0c8c683

Browse files
Apply suggestions from code review
1 parent 093d29b commit 0c8c683

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/SoftRobots/component/constraint/model/SurfacePressureModel.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ class SOFA_SOFTROBOTS_API SurfacePressureModel : virtual public SoftRobotsConstr
150150

151151
void drawValue(const sofa::core::visual::VisualParams* vparams);
152152
void computeEdges();
153-
Real getTetrahedronVolume(const Coord& p0, const Coord& p1, const Coord& p2);
153+
Real getTriangleContributionToVolume(const Coord& p0, const Coord& p1, const Coord& p2);
154154
};
155155

156156
extern template class SurfacePressureModel<sofa::defaulttype::Vec3Types>;

src/SoftRobots/component/constraint/model/SurfacePressureModel.inl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -282,13 +282,13 @@ SReal SurfacePressureModel<DataTypes>::getCavityVolume(const VecCoord& positions
282282

283283
for (unsigned int t=0; t<triangles.size(); t++)
284284
{
285-
volume += getTetrahedronVolume(positions[triangles[t][0]], positions[triangles[t][1]], positions[triangles[t][2]]);
285+
volume += getTriangleContributionToVolume(positions[triangles[t][0]], positions[triangles[t][1]], positions[triangles[t][2]]);
286286
}
287287

288288
for (unsigned int q=0; q<quads.size(); q++)
289289
{
290-
volume += getTetrahedronVolume(positions[quads[q][0]], positions[quads[q][1]], positions[quads[q][2]]);
291-
volume += getTetrahedronVolume(positions[quads[q][0]], positions[quads[q][2]], positions[quads[q][3]]);
290+
volume += getTriangleContributionToVolume(positions[quads[q][0]], positions[quads[q][1]], positions[quads[q][2]]);
291+
volume += getTriangleContributionToVolume(positions[quads[q][0]], positions[quads[q][2]], positions[quads[q][3]]);
292292
}
293293

294294
if(volume<0)

0 commit comments

Comments
 (0)