Skip to content

Commit 0599314

Browse files
committed
fix: improve tracking of reasons why a worker does not support an expectation.
1 parent cee6aa4 commit 0599314

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

shared/packages/expectationManager/src/evaluationRunner/evaluateExpectationStates/new.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,13 +63,13 @@ export async function evaluateExpectationStateNew({ manager, tracker, trackedExp
6363
})
6464
}
6565
} else {
66-
let anyNoAvailableWorkersReasonUser = 'Unknown reason'
66+
let anyNoAvailableWorkersReasonUser = ''
6767
const allNoAvailableWorkersReasonsTech: string[] = []
68-
6968
for (const reason of trackedExp.noAvailableWorkersReasons.values()) {
7069
if (!anyNoAvailableWorkersReasonUser) anyNoAvailableWorkersReasonUser = reason.user // Just pick the first one
7170
allNoAvailableWorkersReasonsTech.push(reason.tech)
7271
}
72+
if (!anyNoAvailableWorkersReasonUser) anyNoAvailableWorkersReasonUser = 'Unknown reason'
7373

7474
tracker.trackedExpectationAPI.updateTrackedExpectationStatus(trackedExp, {
7575
state: ExpectedPackageStatusAPI.WorkStatusState.NEW,

shared/packages/expectationManager/src/internalManager/lib/trackedWorkerAgents.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,14 @@ export class TrackedWorkerAgents {
7474
if ((err + '').match(/timeout/i)) {
7575
trackedExp.noAvailableWorkersReasons.set(workerId, {
7676
user: 'Worker timed out',
77-
tech: `Worker "${workerId} timeout in doYouSupportExpectation()"`,
77+
tech: `${workerId}: Timeout in doYouSupportExpectation()"`,
7878
})
79-
} else throw err
79+
} else {
80+
trackedExp.noAvailableWorkersReasons.set(workerId, {
81+
user: 'Error in Worker',
82+
tech: `${workerId}: Error thrown: ${err}`,
83+
})
84+
}
8085
}
8186
}
8287
})

0 commit comments

Comments
 (0)