Add a configuration option to disable the opening of non-text files

[ghost]

I used to think the ability to open image files was cool, until I realized it's not cool at all when it's broken. Please try to see if you can reproduce it. On the latest nightly build, attempting to open any image file in ecode results in the application crashing.

[SpartanJ]

If it's crashing it's a bug and needs to be fixed, no need to add an option to avoid a bug. Please share an image that's crashing, share any detail that could be relevant like your split view configuration. I wasn't able to crash it. Try to test it with a new empty profile so we can discard if this is affected by the configuration.

[ghost]

Any image. At first, I thought it was a JPG with invalid metadata. Later, I tried a PNG, and it also crashed.

I have tested with a dozen of images and the result is still the same.

[SpartanJ]

That's weird, I really cannot reproduce it (Windows or Linux, the same, all works).
Have you tried with a new profile?
Can you share the crash logs?

[ghost]

The crash log is the same for all image files:

Stack trace (most recent call last):
#17   Object "", at 00007FF8E213E8D7, in BaseThreadInitThunk
#16   Object "", at 00007FF682FD4EAE, in  ?? 
#15   Object "", at 00007FF682FD5830, in  ?? 
#14   Object "", at 00007FF682BCADAB, in  ?? 
#13   Object "", at 00007FF682BB1DBD, in  ?? 
#12   Object "", at 00007FF8B37838F2, in EE::Window::Window::runMainLoop
#11   Object "", at 00007FF682BB9660, in  ?? 
#10   Object "", at 00007FF8B3501F23, in EE::Scene::SceneManager::update
#9    Object "", at 00007FF8B3714AA0, in EE::UI::UISceneNode::update
#8    Object "", at 00007FF8B35047D9, in EE::Scene::SceneNode::update
#7    Object "", at 00007FF8B34E2328, in EE::Scene::ActionManager::update
#6    Object "", at 00007FF8B34E1E1C, in EE::Scene::ActionManager::update
#5    Object "", at 00007FF8B34EE09C, in EE::Scene::Actions::Runnable::update
#4    Object "", at 00007FF8B36869ED, in EE::UI::Tools::UIImageViewer::New
#3    Object "", at 00007FF8B34FA407, in EE::Scene::Node::sendCommonEvent
#2    Object "", at 00007FF8B34FA4C3, in EE::Scene::Node::sendEvent
#1    Object "", at 00007FF682B69CB4, in  ?? 
#0    Object "", at 00007FF8B3755970, in EE::UI::UITreeView::setFocusOnSelection

[SpartanJ]

That was useful. Although you could have clarified how this was happening: you are drag and dropping the image with no project open (probably ecode -t). Thanks for reporting it, a fix has been pushed.

[ghost]

OK, the bug is fixed. But you might still consider the feature request described in the title of this thread (separate from the bug). I’m sure there are people who would find it useful.