Skip to content

Gas fee optimization #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aniket866 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Gas fee optimization #92

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59f984a
Gas fee optimization
aniket866 Jan 28, 2026
b27d627
Code-Rabbit follow-up
aniket866 Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions contracts/src/Chainvoice.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,13 +203,14 @@ contract Chainvoice {
function payInvoice(uint256 invoiceId) external payable nonReentrant {
require(invoiceId < invoices.length, "Invalid invoice ID");

InvoiceDetails storage invoice = invoices[invoiceId];
InvoiceDetails storage invoiceStorage = invoices[invoiceId]; //(read once from storage)
InvoiceDetails memory invoice = invoiceStorage; // now read all from this invoice(memory)
require(msg.sender == invoice.to, "Not authorized");
require(!invoice.isPaid, "Already paid");
require(!invoice.isCancelled, "Invoice is cancelled");

// Effects first for CEI (mark paid, bump fees), then interactions
invoice.isPaid = true;
invoiceStorage.isPaid = true;

if (invoice.tokenAddress == address(0)) {
require(msg.value == invoice.amountDue + fee, "Incorrect payment amount");
Expand Down