Make IAsyncConnection.StateChanged non-explicit in ConnectionStateTracker

Author: mikasoukhov

Net.SocketIO/ConnectionStateTracker.cs

@@ -80,7 +80,6 @@ public void Disconnect()
 	private readonly Lock _currStateLock = new();
 	private ConnectionStates _currState = ConnectionStates.Disconnected;
 
-	private event Func<ConnectionStates, CancellationToken, ValueTask> _stateChanged;
 #pragma warning disable CS0618 // Type or member is obsolete
 	private event Action<ConnectionStates> _syncStateChanged;
 
@@ -93,11 +92,7 @@ event Action<ConnectionStates> IConnection.StateChanged
 #pragma warning restore CS0618
 
 	/// <inheritdoc />
-	event Func<ConnectionStates, CancellationToken, ValueTask> IAsyncConnection.StateChanged
-	{
-		add => _stateChanged += value;
-		remove => _stateChanged -= value;
-	}
+	public event Func<ConnectionStates, CancellationToken, ValueTask> StateChanged;
 
 	/// <summary>
 	/// Connects all tracked connections asynchronously.
@@ -226,7 +221,7 @@ private async ValueTask UpdateOverallStateAsync(CancellationToken cancellationTo
 
 		_syncStateChanged?.Invoke(newState);
 
-		if (_stateChanged is { } handler)
+		if (StateChanged is { } handler)
 			await handler(newState, cancellationToken);
 	}
 }

Tests/Net/ConnectionStateTrackerTests.cs

@@ -921,9 +921,6 @@ public async Task ConnectAsync_CancellationRequested_PropagatesToken()
 		// Connection might still be called before cancellation
 	}
 
-	private static void SubscribeAsync(ConnectionStateTracker tracker, Func<ConnectionStates, CancellationToken, ValueTask> handler)
-		=> ((IAsyncConnection)tracker).StateChanged += handler;
-
 	[TestMethod]
 	public void AsyncStateChanged_AllConnected_Fires()
 	{
@@ -935,7 +932,7 @@ public void AsyncStateChanged_AllConnected_Fires()
 		tracker.Add(conn2);
 
 		ConnectionStates? firedState = null;
-		SubscribeAsync(tracker, (state, _) => { firedState = state; return default; });
+		tracker.StateChanged += (state, _) => { firedState = state; return default; };
 
 		conn1.SetState(ConnectionStates.Connected);
 		conn2.SetState(ConnectionStates.Connected);
@@ -954,7 +951,7 @@ public void AsyncStateChanged_TransitionSequence()
 		tracker.Add(conn2);
 
 		var states = new List<ConnectionStates>();
-		SubscribeAsync(tracker, (state, _) => { states.Add(state); return default; });
+		tracker.StateChanged += (state, _) => { states.Add(state); return default; };
 
 		conn1.SetState(ConnectionStates.Connected);
 		conn2.SetState(ConnectionStates.Connected);
@@ -991,7 +988,7 @@ public void AsyncStateChanged_BothSyncAndAsyncFire()
 		ConnectionStates? asyncState = null;
 
 		Subscribe(tracker, state => syncState = state);
-		SubscribeAsync(tracker, (state, _) => { asyncState = state; return default; });
+		tracker.StateChanged += (state, _) => { asyncState = state; return default; };
 
 		conn.SetState(ConnectionStates.Connected);