Source code for modified VoodooI2CGoodix?

[lazd]

Hey fellas, I'm looking for the source code for the beta touch drivers. As far as I can see, it may be based off two PRs that were sent against VoodooI2CGoodix, but it also has some other changes that are making it work nice in Sonoma. I need to get this building again and try to fix it to work with the latest VoodooI2C (it does, but without scroll functionality), but I'm not sure what the secret sauce is that's making the beta version of VoodooI2CGoodix in this repository work.

Please link me to the branch so I can fix it up! Thank uyou!

cc @balopez83 @THEDEVIOUS1

[THEDEVIOUS1]

just saw this...was actually coming to message u about the exact same thing after i saw the pull incorporated but no new release. just so we're clear here...exactly what beta build are u referring to? if its the final touch zip i uploaded....im not sure how much is junk and how much is needed other than removal of the dependency but this should be what u require . also...i assume that it is working well after sleep on sonoma(having an issue with that on the onegx1 non pro ...which can also be added to the working list otherwise) and youre using the latest voodooi2c? oh yeah...u still using the chuwi/what device if not?

lazd/VoodooI2CGoodix@master...THEDEVIOUS1:VoodooI2CGoodix:master

[lazd]

Hey @THEDEVIOUS1 long time no talk! Yeah, I'm looking for the source that was used to build the final touch zip that's in this repo. If it's your master, that's a good hint. Basically, it simply does not get interrupts after setting up the device with my master... I'll take a look, perhaps acpi_device->evaluateObject("_PS0") is the answer...

And nope, I'm not using the CHUWI, that thing keeps puffing batteries. I'm working on a LattePanda 2 Alpha 864s build inside of an old Apple eMate that happens to use the same Goodix touchscreen! Your kext from this repo works perfectly, I just can't get local builds to work haha

[THEDEVIOUS1]

good to hear from u @lazd ....glad to see u are still at it also. as far as im aware....i am unable to use any version of voodooi2c other than 2.3 when using the "final touch" version so is that true for u too? meant to ask earlier....if u dont mind and can find the time could u provide me with some basic instructions to build the kext myself? obviously have dont it before myself but seems ive forgotten how in the last past 4 years....lol. just realized i overlooked the part where u said your new builds do in fact work with the latest but not without limitations...i dont really care about scrolling right now so do u mind providing me a prebuilt kext so i can see if it still has the sleep issue on my system please?

[balopez83]

@lazd @THEDEVIOUS1 If you want to send me the exact code changes that made 2.3 work I can prob update the latest code to reflect that. I can't remember exactly what version but I think around 2.6 they refactored it and so will need to be tweaked to handle the changes that make the goodix screens to work.

I did something similar to bring in full surface keyboard and pen support with standard touch screen support for the Surface Pro 3 devices. I can likely add the goodix changes to my modded version to make it work for you guys. Mine is the latest version of voodooi2c so it should be an easy mod.

[balopez83]

@lazd I just looked over the code and I think you may be onto something with the evaluate code.

@THEDEVIOUS1 Are you just trying to use the satelite directly with the latest voodooi2c? I think they changed too much with the latest version to be able to directly drop it in. I am pretty sure the master code will need to be incorporated into a build file of the master voodooi2c to build it with the latest version. Likely some dependencies will need to be resolved as well since they moved stuff around a bit. Like I mentioned before though, I have a ready to go build of voodooi2c with a modded voodooi2chid that I use for the Surface Devices. I can try to drop in the code and see if I can make it work assuming @lazd doesn't figure it out before I get a chance :)

Also, what sleep issues are you having? Is it a crash on sleep on anything from Ventura on? If so, its because Apple depreciated a couple things and required some code to be added. Same issue occured with the Surface Devices. I have the code and just need to dig it up assuming thats your issue? If it is, its a really easy add.

[THEDEVIOUS1]

well...if it isnt my long lost minibook bro @balopez83 ! lol....how have u been man? ive basically traveled backwards in time and picked up a pocket 2 but then came across a onegx for a nice price so mostly have been using it although having a few stupid issues 2 of which dealing with brightness....on the pocket 2 the buttons will only work when added to the dsdt but not through a ssdt which seems like a simple enough fix but havent updated the repo in almost a month because of that. the other thing appears more major....on the onegx both the buttons and slider work but doesnt actually dim/brighten the screen. My apologies for derailing the thread @lazd but concerning voodooi2cgoodix...for the time being im simply trying to use the files from the final touch folder which work but only until the device sleeps then the touch screen is dead afterwards (check the link above for changes i made). now that i think about it...im not sure if i ever tried it on ventura(definitely didnt on these 2 devices anyway) but waiting for lazd to confirm if its working for him after awakening

[lazd]

good to hear from u @lazd ....glad to see u are still at it also. as far as im aware....i am unable to use any version of voodooi2c other than 2.3 when using the "final touch" version so is that true for u too? meant to ask earlier....if u dont mind and can find the time could u provide me with some basic instructions to build the kext myself? obviously have dont it before myself but seems ive forgotten how in the last past 4 years....lol. just realized i overlooked the part where u said your new builds do in fact work with the latest but not without limitations...i dont really care about scrolling right now so do u mind providing me a prebuilt kext so i can see if it still has the sleep issue on my system please?

Unfortunately I can't get my built kexts -- that LattePanda Alpha I was using died! @balopez83 is right, I had to change a few include statements to get things to build, but even then, my built kexts for VoodooI2CGoodix never worked -- only the kext from this repo worked! I was able to just drop on VoodooI2C.kext and VoodooI2CHID.kext from the latest version, and the kext from this repo would still work, albeit without scrolling.

I don't have any sleep issues at all, so perhaps your issue isn't with the kext itself...

[balopez83]

@lazd so does this mean that even if it builds you won't be able to test?

Can you both help me remember how this satellite actually worked? Based on the config.plist we had both the Goodix and Voodooi2chid kext active. Is the Goodix kext based off the i2CHID kext and thus requiring the voodooi2CHID kext to be installed and active? It looks like this one would be easy to integrate back into the and combine with the voodooi2CHID kext if that is the case. Likely will make this more resilient to new voodooi2c releases if we do that.

Also if it requires the CHID kext @lazd did you remember to add that in when you built it? I have a hunch that the issue is something to do with those two satellite kexts and not so much with the main i2c kext.

Anyway just spitballing this one and open to your thoughts.

[balopez83]

oh @lazd @THEDEVIOUS1 , since you are using Sonoma did you all test with the latest voodooInput kext? There was a new release that I don't believe has been integrated into the VoodooI2C master and is required to get I2C to work properly with the latest version of Sonoma.

[THEDEVIOUS1]

@lazd so does this mean that even if it builds you won't be able to test?

Can you both help me remember how this satellite actually worked? Based on the config.plist we had both the Goodix and Voodooi2chid kext active. Is the Goodix kext based off the i2CHID kext and thus requiring the voodooi2CHID kext to be installed and active? It looks like this one would be easy to integrate back into the and combine with the voodooi2CHID kext if that is the case. Likely will make this more resilient to new voodooi2c releases if we do that.

Also if it requires the CHID kext @lazd did you remember to add that in when you built it? I have a hunch that the issue is something to do with those two satellite kexts and not so much with the main i2c kext.

Anyway just spitballing this one and open to your thoughts.

as far as i know....theres no need for the hid kext because its working on the pocket 2 perfectly fine without it but thats interesting @lazd is saying he could just drop in the latest voodooi2c (but is also including voodooi2chid) with the final touch kext. correct me if im wrong @balopez but i dont think thats ever been true for us...even back on the minibook i believe we had to specifically use voodooi2c 2.3 which is why i included in that zip but again may be majorly mistaken so maybe that is effecting operation after awakening on my setup although i admit it could be a completely unrelated acpi configuration error

edit: @balopez just dropped in the latest voodooi2c with the hid kext and included the most recent version of voodooinput with the final touch goodix and its still dead on boot as it always has been for me if i recall correctly @lazd meant to mention how awesome that build was but hate to hear your device has died....if its possible please upload your ssdt/ddst and/or renames u were using as there has to be something different about your setup

[balopez83]

@THEDEVIOUS1 So I might have missed something but I don't think @lazd was using the HID kext and only trying to build it with the latest i2c build. That said you are exactly right in that the goodix kext shouldn't work without the 2.3 i2c release. They made too many changes for the goodix kext to work as-is with 2.6.

The way I see it is we are going to have to do this in two stages. The first is to use a clean i2c v2.3 to build against. We would need to build @lazd 's release and add that acpi code as I am pretty sure that is the difference that makes yours work and not the master goodix. That build will need to be tested to confirm that is the code change. Once that is done the second stage will be to update that code to the latest release and test against that until it works.

Doing it that way will take longer but it will allow us to ensure we are not hunting around blind for the issue. Problem is, we need a device to test against. I am grabbing my modded code off my SP3 which I can build against but until we have a computer to test against, I won't know if it actually works.

BTW, other than a old Surface Pro 3 and Surface Pro 4, and my work Surface Pro 7, I don't have any other device to test on. I do still have the One Mix Yoga 4 still but with the 11th gen its useless. I actually have a real mac now as well which I will build on. Wish those minibooks were better, I would have loved to still have it and have it work.

[THEDEVIOUS1]

@THEDEVIOUS1 So I might have missed something but I don't think @lazd was using the HID kext and only trying to build it with the latest i2c build. That said you are exactly right in that the goodix kext shouldn't work without the 2.3 i2c release. They made too many changes for the goodix kext to work as-is with 2.6.

The way I see it is we are going to have to do this in two stages. The first is to use a clean i2c v2.3 to build against. We would need to build @lazd 's release and add that acpi code as I am pretty sure that is the difference that makes yours work and not the master goodix. That build will need to be tested to confirm that is the code change. Once that is done the second stage will be to update that code to the latest release and test against that until it works.

Doing it that way will take longer but it will allow us to ensure we are not hunting around blind for the issue. Problem is, we need a device to test against. I am grabbing my modded code off my SP3 which I can build against but until we have a computer to test against, I won't know if it actually works.

BTW, other than a old Surface Pro 3 and Surface Pro 4, and my work Surface Pro 7, I don't have any other device to test on. I do still have the One Mix Yoga 4 still but with the 11th gen its useless. I actually have a real mac now as well which I will build on. Wish those minibooks were better, I would have loved to still have it and have it work.

agreed and to expand on that....what i originally did to figure out what works was to compare the goodix kext against the i2chid code and, since its so similar, was able to transplant parts until it was functioning properly. @lazd just so we're clear here....dont know if u have taken the time to review my source code yet but i realize there is a part i wasnt quite clear about when explaining(it is in the actual commits however)...im pretty sure the iographics dependency needs to be removed in the code as well and not just the plist like i seemed to be suggesting in the pull request

edit @balopez83 i must be missing something...just realized the last release for the minibook is using voodooi2c 2.6 with goodix 3.1 so is that a special recompiled version with stuff added/subtracted or did u not test it at the time?

[balopez83]

@THEDEVIOUS1 so you are right, I had my version numbers all messed up. That said I went ahead and built a voodooI2CGoodix.kext against the 2.8.0 master. I used your repo for the Goodix code and not @lazd so it includes all of your changes and in theory "should" work. Just drop in

I know we don't really have a way of testing but perhaps @THEDEVIOUS1 you could test on your machine to see if the kext even works to drive your machine. I know we won't be able to confirm if it will work on the lattepanda but at least we can validate if my build has issues or if it works as I hope.

VoodooI2C.kext.zip

VoodooI2CGoodix.kext.zip

If it doesn't work at first, try downloading the official 2.8.0 release of VoodooI2C and try my goodix kext again and see if it works. If that still doesn't work then let me know and I will dig deeper. Also, if it works I will zip up the whole build folder so you can play around with it as well since it builds.

[balopez83]

Oh @THEDEVIOUS1 I forgot to also add that if it works but it's not quite right such as losing multitouch or something else, try also replacing voodooinput with the latest actual release. I forgot to pull a new release of it and include it in the release I just sent you. I don't believe the actual 2.8.0 master release has the updated voodooinput either so you would have to replace that one as well if you try it.

[THEDEVIOUS1]

Oh @THEDEVIOUS1 I forgot to also add that if it works but it's not quite right such as losing multitouch or something else, try also replacing voodooinput with the latest actual release. I forgot to pull a new release of it and include it in the release I just sent you. I don't believe the actual 2.8.0 master release has the updated voodo oinput either so you would have to replace that one as well if you try it.

welp...long story short? looks like we're back to one of our original issues....yours works with either voodooinput BUT will only do so after warm boot from windows which also means it breaks after sleep with any version of voodooi2c other than 2.3. as far as with 2.3...it functions fine/the exact same as my version from cold boot and after awake EXCEPT scroll is broken on yours while it works on mine.

The fact that it only works after windows is probably why @lazd thought his builds werent working at all....oh & i assume that if u were loading the final touch goodix with newer versions is why the scroll was broken but the fact u were able to do so at all is still an anomaly and so im left to assume that there is in fact something else switched on/off on your setup