Skip to content

[Fix] Allow default TIS function usage when get_mismatch_metrics is set #1483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eecspan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Fix] Allow default TIS function usage when get_mismatch_metrics is set #1483

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions slime/utils/arguments.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1672,9 +1672,10 @@ def slime_validate_args(args):
assert not args.use_tis, "use_rollout_logprobs and use_tis cannot be set at the same time."

if args.get_mismatch_metrics:
assert (
args.custom_tis_function_path is not None
), "custom_tis_function_path must be set when get_mismatch_metrics is set"
if args.custom_tis_function_path is None:
logger.warning(
"get_mismatch_metrics is set but custom_tis_function_path is None. Using default vanilla_tis_function for metrics calculation."
)

if args.use_rollout_logprobs:
logger.info(
Expand Down