fix tests

Author: KevinVandy

knip.json

@@ -2,12 +2,8 @@
   "$schema": "https://unpkg.com/knip@5/schema.json",
   "ignoreDependencies": ["@faker-js/faker"],
   "ignoreWorkspaces": ["examples/**"],
-  "ignore": ["**/eslint.config.js"],
-  "eslint": {
-    "config": []
-  },
   "workspaces": {
-    "packages/react-pacer": {
+    "packages/react-keys": {
       "ignore": []
     }
   }

packages/keys/src/constants.ts

@@ -13,8 +13,8 @@ export function detectPlatform(): 'mac' | 'windows' | 'linux' {
     return 'linux' // Default for SSR
   }
 
-  const platform = navigator.platform?.toLowerCase() ?? ''
-  const userAgent = navigator.userAgent?.toLowerCase() ?? ''
+  const platform = navigator.platform.toLowerCase()
+  const userAgent = navigator.userAgent.toLowerCase()
 
   if (platform.includes('mac') || userAgent.includes('mac')) {
     return 'mac'

packages/keys/src/match.ts

@@ -152,7 +152,7 @@ export function createMultiHotkeyHandler(
   // Pre-parse all hotkeys for efficiency
   const parsedHandlers = Object.entries(handlers)
     .filter(
-      (entry): entry is [string, HotkeyCallback] => entry[1] !== undefined,
+      (entry): entry is [string, HotkeyCallback] => Boolean(entry[1]),
     )
     .map(([hotkey, handler]) => {
       const parsed = parseHotkey(hotkey as Hotkey, resolvedPlatform)

packages/react-keys-devtools/package.json

@@ -50,8 +50,11 @@
     "src"
   ],
   "devDependencies": {
+    "@eslint-react/eslint-plugin": "^2.8.1",
     "@types/react": "^19.2.10",
     "@vitejs/plugin-react": "^5.1.2",
+    "eslint-plugin-react-compiler": "19.1.0-rc.2",
+    "eslint-plugin-react-hooks": "^7.0.1",
     "react": "^19.2.4"
   },
   "peerDependencies": {

packages/react-keys/package.json

@@ -59,7 +59,8 @@
     "@vitejs/plugin-react": "^5.1.2",
     "eslint-plugin-react-compiler": "19.1.0-rc.2",
     "eslint-plugin-react-hooks": "^7.0.1",
-    "react": "^19.2.4"
+    "react": "^19.2.4",
+    "react-dom": "^19.2.4"
   },
   "peerDependencies": {
     "react": ">=16.8",

packages/react-keys/src/useHotkey.ts

@@ -67,13 +67,26 @@ export function useHotkey(
 ): void {
   const { enabled = true, ...hotkeyOptions } = options
 
+  // Extract options for stable dependencies
+  const {
+    preventDefault,
+    stopPropagation,
+    platform,
+    eventType,
+    requireReset,
+  } = hotkeyOptions
+
   // Use refs to keep callback and hotkey stable across renders
   const callbackRef = useRef(callback)
   callbackRef.current = callback
 
   const hotkeyRef = useRef(hotkey)
   hotkeyRef.current = hotkey
 
+  // Serialize hotkey for dependency comparison
+  const hotkeyKey =
+    typeof hotkey === 'string' ? hotkey : JSON.stringify(hotkey)
+
   useEffect(() => {
     if (!enabled) {
       return
@@ -86,25 +99,33 @@ export function useHotkey(
         : formatParsedHotkey(hotkeyValue)
 
     const manager = getHotkeyManager()
+
+    // Build options object, only including defined values to avoid
+    // overwriting manager defaults with undefined
+    const registerOptions: HotkeyOptions = { enabled: true }
+    if (preventDefault !== undefined)
+      registerOptions.preventDefault = preventDefault
+    if (stopPropagation !== undefined)
+      registerOptions.stopPropagation = stopPropagation
+    if (platform !== undefined) registerOptions.platform = platform
+    if (eventType !== undefined) registerOptions.eventType = eventType
+    if (requireReset !== undefined) registerOptions.requireReset = requireReset
+
     const unregister = manager.register(
       hotkeyString,
       (event, context) => callbackRef.current(event, context),
-      {
-        ...hotkeyOptions,
-        enabled: true,
-      },
+      registerOptions,
     )
 
     return unregister
   }, [
     enabled,
-    hotkeyOptions.preventDefault,
-    hotkeyOptions.stopPropagation,
-    hotkeyOptions.platform,
-    hotkeyOptions.eventType,
-    hotkeyOptions.requireReset,
-    // Re-register if hotkey changes (serialize for comparison)
-    typeof hotkey === 'string' ? hotkey : JSON.stringify(hotkey),
+    preventDefault,
+    stopPropagation,
+    platform,
+    eventType,
+    requireReset,
+    hotkeyKey,
   ])
 }
 

packages/react-keys/src/useHotkeySequence.ts

@@ -53,6 +53,9 @@ export function useHotkeySequence(
 ): void {
   const { enabled = true, ...sequenceOptions } = options
 
+  // Extract options for stable dependencies
+  const { timeout, platform } = sequenceOptions
+
   // Use refs to keep callback stable
   const callbackRef = useRef(callback)
   callbackRef.current = callback
@@ -66,16 +69,18 @@ export function useHotkeySequence(
     }
 
     const manager = getSequenceManager()
+
+    // Build options object conditionally to avoid overwriting manager defaults with undefined
+    const registerOptions: SequenceOptions = { enabled: true }
+    if (timeout !== undefined) registerOptions.timeout = timeout
+    if (platform !== undefined) registerOptions.platform = platform
+
     const unregister = manager.register(
       sequence,
       (event, context) => callbackRef.current(event, context),
-      {
-        ...sequenceOptions,
-        enabled: true,
-      },
+      registerOptions,
     )
 
     return unregister
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [enabled, sequenceKey, sequenceOptions.timeout, sequenceOptions.platform])
+  }, [enabled, sequence, sequenceKey, timeout, platform])
 }

packages/react-keys/tests/useHotkey.test.tsx

@@ -1,8 +1,18 @@
-import { describe, expect, it, vi } from 'vitest'
+import { describe, expect, it, vi, beforeEach, afterEach } from 'vitest'
 import { renderHook } from '@testing-library/react'
+import { HotkeyManager } from '@tanstack/keys'
 import { useHotkey } from '../src/useHotkey'
 
 describe('useHotkey', () => {
+  // Reset the HotkeyManager singleton between tests
+  beforeEach(() => {
+    HotkeyManager.resetInstance()
+  })
+
+  afterEach(() => {
+    HotkeyManager.resetInstance()
+  })
+
   it('should register a hotkey handler', () => {
     const callback = vi.fn()
     const addEventListenerSpy = vi.spyOn(document, 'addEventListener')
@@ -57,6 +67,7 @@ describe('useHotkey', () => {
     const event = new KeyboardEvent('keydown', {
       key: 's',
       metaKey: true,
+      bubbles: true,
     })
     document.dispatchEvent(event)
 
@@ -72,6 +83,7 @@ describe('useHotkey', () => {
     const event = new KeyboardEvent('keydown', {
       key: 'a',
       metaKey: true,
+      bubbles: true,
     })
     document.dispatchEvent(event)