chore: cleanup based on pr review

brenelz · brenelz · commit 34c0966d28e8 · 2026-01-30T17:42:36.000-06:00
diff --git a/src/components/AuthenticatedUserMenu.tsx b/src/components/AuthenticatedUserMenu.tsx
@@ -80,11 +80,7 @@ export function AuthenticatedUserMenu({
         )}
         {canAdmin && (
           <DropdownItem asChild>
-            <Link
-              to="/admin"
-              search={{ tab: 'overview' }}
-              className="flex items-center gap-2"
-            >
+            <Link to="/admin" className="flex items-center gap-2">
               <Lock className="w-4 h-4" />
               <span>Admin</span>
             </Link>
diff --git a/src/components/Navbar.tsx b/src/components/Navbar.tsx
@@ -790,9 +790,9 @@ export function Navbar({ children }: { children: React.ReactNode }) {
           showMenu && 'md:translate-x-0',
           // lg breakpoint: inline when no Title, flyout when Title
           inlineMenu &&
-            'lg:sticky lg:top-[var(--navbar-height)] lg:translate-x-0 lg:bg-white/50 lg:dark:bg-black/30 lg:backdrop-blur-none lg:shadow-none',
+          'lg:sticky lg:top-[var(--navbar-height)] lg:translate-x-0 lg:bg-white/50 lg:dark:bg-black/30 lg:backdrop-blur-none lg:shadow-none',
           !inlineMenu &&
-            'lg:fixed lg:top-[var(--navbar-height)] lg:bg-white lg:dark:bg-black/90 lg:backdrop-blur-lg lg:shadow-xl',
+          'lg:fixed lg:top-[var(--navbar-height)] lg:bg-white lg:dark:bg-black/90 lg:backdrop-blur-lg lg:shadow-xl',
           !inlineMenu && !showMenu && 'lg:-translate-x-full',
           !inlineMenu && showMenu && 'lg:translate-x-0',
         )}
diff --git a/src/components/ShowcaseDetail.tsx b/src/components/ShowcaseDetail.tsx
@@ -203,7 +203,6 @@ export function ShowcaseDetail({ showcaseId }: ShowcaseDetailProps) {
           </p>
           <Link
             to="/showcase"
-            search={{ page: 1 }}
             className="inline-flex items-center gap-2 text-blue-600 hover:text-blue-700 dark:text-blue-400 dark:hover:text-blue-300 font-medium"
           >
             <ArrowLeft className="w-4 h-4" />
@@ -226,7 +225,6 @@ export function ShowcaseDetail({ showcaseId }: ShowcaseDetailProps) {
         {/* Back link */}
         <Link
           to="/showcase"
-          search={{ page: 1 }}
           className="inline-flex items-center gap-2 text-sm text-gray-600 dark:text-gray-400 hover:text-gray-900 dark:hover:text-white mb-6"
         >
           <ArrowLeft className="w-4 h-4" />
diff --git a/src/components/ShowcaseGallery.tsx b/src/components/ShowcaseGallery.tsx
@@ -360,7 +360,7 @@ export function ShowcaseGallery() {
                   totalItems={data.pagination.total}
                   pageSize={24}
                   onPageChange={handlePageChange}
-                  onPageSizeChange={() => {}}
+                  onPageSizeChange={() => { }}
                   canGoPrevious={search.page > 1}
                   canGoNext={search.page < data.pagination.totalPages}
                   itemLabel="projects"
diff --git a/src/components/ShowcaseSection.tsx b/src/components/ShowcaseSection.tsx
@@ -239,7 +239,6 @@ export function ShowcaseSection({
           <Link
             to="/showcase"
             search={{
-              page: 1,
               libraryIds: libraryId ? [libraryId] : undefined,
             }}
           >
diff --git a/src/components/landing/DbLanding.tsx b/src/components/landing/DbLanding.tsx
@@ -21,7 +21,7 @@ export default function DbLanding() {
         cta={{
           linkProps: {
             to: '/$libraryId/$version/docs',
-            params: { libraryId: library.id, version: 'latest' },
+            params: { libraryId: library.id },
           },
           label: 'Get Started',
           className:
@@ -80,7 +80,7 @@ export default function DbLanding() {
       <BottomCTA
         linkProps={{
           to: '/$libraryId/$version/docs',
-          params: { libraryId: library.id, version: 'latest' },
+          params: { libraryId: library.id },
         }}
         label="Get Started!"
         className="bg-orange-500 border-orange-500 hover:bg-orange-600 text-white"
diff --git a/src/components/landing/DevtoolsLanding.tsx b/src/components/landing/DevtoolsLanding.tsx
@@ -22,7 +22,7 @@ export default function DevtoolsLanding() {
         cta={{
           linkProps: {
             to: '/$libraryId/$version/docs',
-            params: { libraryId: library.id, version: 'latest' },
+            params: { libraryId: library.id },
           },
           label: 'Get Started',
           className:
@@ -72,7 +72,7 @@ export default function DevtoolsLanding() {
       <BottomCTA
         linkProps={{
           to: '/$libraryId/$version/docs',
-          params: { libraryId: library.id, version: 'latest' },
+          params: { libraryId: library.id },
         }}
         label="Get Started!"
         className="bg-slate-500 border-slate-500 hover:bg-slate-600 hover:border-slate-600 text-white"
diff --git a/src/components/landing/PacerLanding.tsx b/src/components/landing/PacerLanding.tsx
@@ -22,7 +22,7 @@ export default function PacerLanding() {
         cta={{
           linkProps: {
             to: '/$libraryId/$version/docs',
-            params: { libraryId: library.id, version: 'latest' },
+            params: { libraryId: library.id },
           },
           label: 'Get Started',
           className: 'bg-lime-600 border-lime-600 hover:bg-lime-700 text-white',
@@ -70,7 +70,7 @@ export default function PacerLanding() {
       <BottomCTA
         linkProps={{
           to: '/$libraryId/$version/docs',
-          params: { libraryId: library.id, version: 'latest' },
+          params: { libraryId: library.id },
         }}
         label="Get Started!"
         className="bg-lime-600 border-lime-600 hover:bg-lime-700 hover:border-lime-700 text-white"
diff --git a/src/components/landing/StartLanding.tsx b/src/components/landing/StartLanding.tsx
@@ -130,7 +130,7 @@ export default function StartLanding() {
       <BottomCTA
         linkProps={{
           to: '/$libraryId/$version/docs',
-          params: { libraryId: library.id, version: 'latest' },
+          params: { libraryId: library.id },
         }}
         label="Get Started!"
         className="bg-cyan-500 border-cyan-500 hover:bg-cyan-600 text-white"
diff --git a/src/components/landing/StoreLanding.tsx b/src/components/landing/StoreLanding.tsx
@@ -21,7 +21,7 @@ export default function StoreLanding() {
         cta={{
           linkProps: {
             to: '/$libraryId/$version/docs',
-            params: { libraryId: library.id, version: 'latest' },
+            params: { libraryId: library.id },
           },
           label: 'Get Started',
           className:
@@ -43,7 +43,7 @@ export default function StoreLanding() {
       <BottomCTA
         linkProps={{
           to: '/$libraryId/$version/docs',
-          params: { libraryId: library.id, version: 'latest' },
+          params: { libraryId: library.id },
         }}
         label="Get Started!"
         className="bg-stone-700 border-stone-700 hover:bg-stone-800 text-white"
diff --git a/src/routes/$libraryId/$version.docs.framework.$framework.$.tsx b/src/routes/$libraryId/$version.docs.framework.$framework.$.tsx
@@ -26,9 +26,8 @@ export const Route = createFileRoute(
       return await loadDocs({
         repo: library.repo,
         branch: getBranch(library, version),
-        docsPath: `${
-          library.docsRoot || 'docs'
-        }/framework/${framework}/${docsPath}`,
+        docsPath: `${library.docsRoot || 'docs'
+          }/framework/${framework}/${docsPath}`,
       })
     } catch (error) {
       // If doc not found, redirect to framework docs root instead of showing 404
diff --git a/src/routes/admin/banners.$id.tsx b/src/routes/admin/banners.$id.tsx
@@ -65,12 +65,7 @@ function BannerEditorPage() {
           <h1 className="text-2xl font-bold mb-2">Banner Not Found</h1>
           <Button
             className="mt-4"
-            onClick={() =>
-              navigate({
-                to: '/admin/banners',
-                search: { includeInactive: true },
-              })
-            }
+            onClick={() => navigate({ to: '/admin/banners' })}
           >
             Back to Banners
           </Button>
@@ -84,18 +79,8 @@ function BannerEditorPage() {
       <div className="max-w-6xl mx-auto">
         <BannerEditor
           banner={isNew ? null : (bannerQuery.data as BannerWithMeta)}
-          onSave={() =>
-            navigate({
-              to: '/admin/banners',
-              search: { includeInactive: true },
-            })
-          }
-          onCancel={() =>
-            navigate({
-              to: '/admin/banners',
-              search: { includeInactive: true },
-            })
-          }
+          onSave={() => navigate({ to: '/admin/banners' })}
+          onCancel={() => navigate({ to: '/admin/banners' })}
         />
       </div>
     </div>
diff --git a/src/routes/admin/banners.index.tsx b/src/routes/admin/banners.index.tsx
@@ -33,15 +33,13 @@ import {
 import { useAdminGuard } from '~/hooks/useAdminGuard'
 import { useDeleteWithConfirmation } from '~/hooks/useDeleteWithConfirmation'
 
+const searchSchema = v.object({
+  includeInactive: v.optional(v.boolean(), true),
+});
+
 export const Route = createFileRoute('/admin/banners/')({
   component: BannersAdminPage,
-  validateSearch: (search) =>
-    v.parse(
-      v.object({
-        includeInactive: v.optional(v.boolean(), true),
-      }),
-      search,
-    ),
+  validateSearch: searchSchema,
 })
 
 const STYLE_CONFIG = {
@@ -185,9 +183,8 @@ function BannersAdminPage() {
               return (
                 <div
                   key={banner.id}
-                  className={`bg-white dark:bg-gray-800 rounded-xl border border-gray-200 dark:border-gray-700 overflow-hidden ${
-                    !banner.isActive ? 'opacity-60' : ''
-                  }`}
+                  className={`bg-white dark:bg-gray-800 rounded-xl border border-gray-200 dark:border-gray-700 overflow-hidden ${!banner.isActive ? 'opacity-60' : ''
+                    }`}
                 >
                   <div className="p-4">
                     <div className="flex items-start gap-4">
@@ -285,11 +282,10 @@ function BannersAdminPage() {
                       <div className="flex items-center gap-2">
                         <button
                           onClick={() => handleToggleActive(banner)}
-                          className={`p-2 rounded-lg transition-colors ${
-                            banner.isActive
-                              ? 'text-green-600 hover:bg-green-100 dark:hover:bg-green-900/30'
-                              : 'text-gray-400 hover:bg-gray-100 dark:hover:bg-gray-700'
-                          }`}
+                          className={`p-2 rounded-lg transition-colors ${banner.isActive
+                            ? 'text-green-600 hover:bg-green-100 dark:hover:bg-green-900/30'
+                            : 'text-gray-400 hover:bg-gray-100 dark:hover:bg-gray-700'
+                            }`}
                           title={banner.isActive ? 'Deactivate' : 'Activate'}
                         >
                           {banner.isActive ? (
diff --git a/src/routes/admin/feedback.index.tsx b/src/routes/admin/feedback.index.tsx
@@ -6,6 +6,19 @@ import { listDocFeedbackForModerationQueryOptions } from '~/queries/docFeedback'
 import { requireCapability } from '~/utils/auth.server'
 import { libraryIdSchema, docFeedbackStatusSchema } from '~/utils/schemas'
 
+const searchSchema = v.object({
+  page: v.optional(v.number(), 1),
+  pageSize: v.optional(
+    v.pipe(v.number(), v.integer(), v.minValue(1)),
+    50,
+  ),
+  status: v.optional(v.array(docFeedbackStatusSchema)),
+  libraryId: v.optional(libraryIdSchema),
+  isDetached: v.optional(v.boolean()),
+  dateFrom: v.optional(v.string()),
+  dateTo: v.optional(v.string()),
+});
+
 export const Route = createFileRoute('/admin/feedback/')({
   staleTime: 1000 * 60 * 5, // 5 minutes
   beforeLoad: async () => {
@@ -18,25 +31,7 @@ export const Route = createFileRoute('/admin/feedback/')({
       throw redirect({ to: '/login' })
     }
   },
-  validateSearch: (search) => {
-    const parsed = v.parse(
-      v.object({
-        page: v.optional(v.number(), 1),
-        pageSize: v.optional(
-          v.pipe(v.number(), v.integer(), v.minValue(1)),
-          50,
-        ),
-        status: v.optional(v.array(docFeedbackStatusSchema)),
-        libraryId: v.optional(libraryIdSchema),
-        isDetached: v.optional(v.boolean()),
-        dateFrom: v.optional(v.string()),
-        dateTo: v.optional(v.string()),
-      }),
-      search,
-    )
-
-    return parsed
-  },
+  validateSearch: searchSchema,
   loaderDeps: ({ search }) => ({
     page: search.page,
     pageSize: search.pageSize,
diff --git a/src/routes/admin/feedback_.$id.tsx b/src/routes/admin/feedback_.$id.tsx
@@ -77,7 +77,6 @@ function FeedbackDetailPage() {
             </p>
             <Link
               to="/admin/feedback"
-              search={{ page: 0, pageSize: 10 }}
               className="mt-4 inline-flex items-center gap-2 text-blue-600 hover:text-blue-700"
             >
               <ArrowLeft className="w-4 h-4" />
@@ -110,7 +109,6 @@ function FeedbackDetailPage() {
         <div className="mb-6">
           <Link
             to="/admin/feedback"
-            search={{ page: 0, pageSize: 10 }}
             className="inline-flex items-center gap-2 text-sm text-gray-600 dark:text-gray-400 hover:text-gray-900 dark:hover:text-white mb-4"
           >
             <ArrowLeft className="w-4 h-4" />
@@ -229,11 +227,6 @@ function FeedbackDetailPage() {
               <Link
                 to="/admin/users/$userId"
                 params={{ userId: user.id }}
-                search={{
-                  page: 0,
-                  pageSize: 10,
-                  useEffectiveCapabilities: true,
-                }}
                 className="flex items-center gap-3 hover:bg-gray-50 dark:hover:bg-gray-800 p-2 rounded-lg -m-2"
               >
                 {user.image ? (
diff --git a/src/routes/admin/index.tsx b/src/routes/admin/index.tsx
diff --git a/src/routes/admin/showcases.index.tsx b/src/routes/admin/showcases.index.tsx
diff --git a/src/routes/admin/showcases_.$id.tsx b/src/routes/admin/showcases_.$id.tsx
diff --git a/src/routes/admin/users.$userId.tsx b/src/routes/admin/users.$userId.tsx
diff --git a/src/routes/admin/users.tsx b/src/routes/admin/users.tsx
diff --git a/src/routes/showcase/index.tsx b/src/routes/showcase/index.tsx

Original file line number	Diff line number	Diff line change
`@@ -239,7 +239,6 @@ export function ShowcaseSection({`
`239`	`239`	`<Link`
`240`	`240`	`to="/showcase"`
`241`	`241`	`search={{`
`242`		`- page: 1,`
`243`	`242`	`libraryIds: libraryId ? [libraryId] : undefined,`
`244`	`243`	`}}`
`245`	`244`	`>`