feat: implement separate create buttons with modal forms

scott grayson · scott grayson · commit e0238d5635b7 · 2025-09-12T12:54:30.000-04:00
- Add separate 'Create Folder' and 'Upload File' modal actions
- Create folder modal: name input only
- Upload file modal: file upload only
- Location is automatically set to current folder (cannot be changed)
- Edit form simplified to only allow name changes
- Remove type and parent_id from edit form (immutable after creation)
- Fix auth()-&gt;id() calls to use auth()-&gt;user()?-&gt;id
diff --git a/src/Resources/LibraryItemResource.php b/src/Resources/LibraryItemResource.php
@@ -51,6 +51,43 @@ public static function form(Schema $schema): Schema
             ]);
     }
 
+    public static function folderForm(Schema $schema): Schema
+    {
+        return $schema
+            ->components([
+                \Filament\Forms\Components\TextInput::make('name')
+                    ->label('Folder Name')
+                    ->required()
+                    ->maxLength(255)
+                    ->placeholder('Enter folder name'),
+            ]);
+    }
+
+    public static function fileForm(Schema $schema): Schema
+    {
+        return $schema
+            ->components([
+                \Filament\Forms\Components\FileUpload::make('file')
+                    ->label('Upload File')
+                    ->required()
+                    ->acceptedFileTypes(['*'])
+                    ->maxSize(10240) // 10MB
+                    ->disk('public')
+                    ->directory('library-files')
+                    ->visibility('private'),
+            ]);
+    }
+
+    public static function editForm(Schema $schema): Schema
+    {
+        return $schema
+            ->components([
+                \Filament\Forms\Components\TextInput::make('name')
+                    ->required()
+                    ->maxLength(255),
+            ]);
+    }
+
     public static function table(Table $table): Table
     {
         return $table
@@ -90,8 +127,8 @@ public static function table(Table $table): Table
             ])
             ->actions([
                 ViewAction::make()
-                    ->url(fn (LibraryItem $record): string => 
-                        $record->type === 'folder' 
+                    ->url(fn (LibraryItem $record): string =>
+                        $record->type === 'folder'
                             ? static::getUrl('index', ['parent' => $record->id])
                             : static::getUrl('view', ['record' => $record])
                     ),
@@ -117,6 +154,8 @@ public static function getPages(): array
         return [
             'index' => Pages\ListLibraryItems::route('/'),
             'create' => Pages\CreateLibraryItem::route('/create'),
+            'create-folder' => Pages\CreateFolder::route('/create-folder'),
+            'create-file' => Pages\CreateFile::route('/create-file'),
             'view' => Pages\ViewLibraryItem::route('/{record}'),
             'edit' => Pages\EditLibraryItem::route('/{record}/edit'),
         ];
diff --git a/src/Resources/Pages/CreateFile.php b/src/Resources/Pages/CreateFile.php
@@ -0,0 +1,36 @@
+<?php
+
+namespace Tapp\FilamentLibrary\Resources\Pages;
+
+use Filament\Resources\Pages\CreateRecord;
+use Tapp\FilamentLibrary\Resources\LibraryItemResource;
+
+class CreateFile extends CreateRecord
+{
+    protected static string $resource = LibraryItemResource::class;
+
+    public ?int $parentId = null;
+
+    public function mount(): void
+    {
+        parent::mount();
+        
+        $this->parentId = request()->get('parent');
+    }
+
+    protected function mutateFormDataBeforeCreate(array $data): array
+    {
+        $data['type'] = 'file';
+        $data['parent_id'] = $this->parentId;
+        $data['created_by'] = auth()->user()?->id;
+        
+        return $data;
+    }
+
+    protected function getRedirectUrl(): string
+    {
+        return $this->parentId 
+            ? static::getResource()::getUrl('index', ['parent' => $this->parentId])
+            : static::getResource()::getUrl('index');
+    }
+}
diff --git a/src/Resources/Pages/CreateFolder.php b/src/Resources/Pages/CreateFolder.php
@@ -0,0 +1,36 @@
+<?php
+
+namespace Tapp\FilamentLibrary\Resources\Pages;
+
+use Filament\Resources\Pages\CreateRecord;
+use Tapp\FilamentLibrary\Resources\LibraryItemResource;
+
+class CreateFolder extends CreateRecord
+{
+    protected static string $resource = LibraryItemResource::class;
+
+    public ?int $parentId = null;
+
+    public function mount(): void
+    {
+        parent::mount();
+        
+        $this->parentId = request()->get('parent');
+    }
+
+    protected function mutateFormDataBeforeCreate(array $data): array
+    {
+        $data['type'] = 'folder';
+        $data['parent_id'] = $this->parentId;
+        $data['created_by'] = auth()->user()?->id;
+        
+        return $data;
+    }
+
+    protected function getRedirectUrl(): string
+    {
+        return $this->parentId 
+            ? static::getResource()::getUrl('index', ['parent' => $this->parentId])
+            : static::getResource()::getUrl('index');
+    }
+}
diff --git a/src/Resources/Pages/CreateLibraryItem.php b/src/Resources/Pages/CreateLibraryItem.php
@@ -15,9 +15,9 @@ class CreateLibraryItem extends CreateRecord
     public function mount(): void
     {
         parent::mount();
-        
+
         $this->parentId = request()->get('parent');
-        
+
         if ($this->parentId) {
             $this->form->fill([
                 'parent_id' => $this->parentId,
@@ -30,9 +30,9 @@ protected function mutateFormDataBeforeCreate(array $data): array
         if ($this->parentId) {
             $data['parent_id'] = $this->parentId;
         }
-        
+
         $data['created_by'] = auth()->id();
-        
+
         return $data;
     }
 }
diff --git a/src/Resources/Pages/EditLibraryItem.php b/src/Resources/Pages/EditLibraryItem.php
@@ -4,6 +4,7 @@
 
 use Filament\Resources\Pages\EditRecord;
 use Tapp\FilamentLibrary\Resources\LibraryItemResource;
+use Filament\Actions\DeleteAction;
 
 class EditLibraryItem extends EditRecord
 {
@@ -12,7 +13,29 @@ class EditLibraryItem extends EditRecord
     protected function getHeaderActions(): array
     {
         return [
-            //
+            DeleteAction::make(),
+        ];
+    }
+
+    protected function mutateFormDataBeforeFill(array $data): array
+    {
+        // Remove fields that shouldn't be editable
+        unset($data['type']);
+        unset($data['parent_id']);
+        unset($data['created_by']);
+        
+        return $data;
+    }
+
+    protected function getForms(): array
+    {
+        return [
+            'form' => $this->form(
+                $this->makeForm()
+                    ->schema(static::getResource()::editForm($this->makeFormSchema())->getComponents())
+                    ->statePath('data')
+                    ->model($this->getRecord())
+            ),
         ];
     }
 }
diff --git a/src/Resources/Pages/ListLibraryItems.php b/src/Resources/Pages/ListLibraryItems.php
@@ -7,6 +7,8 @@
 use Tapp\FilamentLibrary\Models\LibraryItem;
 use Filament\Actions\CreateAction;
 use Filament\Actions\Action;
+use Filament\Forms\Components\TextInput;
+use Filament\Forms\Components\FileUpload;
 
 class ListLibraryItems extends ListRecords
 {
@@ -18,9 +20,9 @@ class ListLibraryItems extends ListRecords
     public function mount(): void
     {
         parent::mount();
-        
+
         $this->parentId = request()->get('parent');
-        
+
         if ($this->parentId) {
             $this->parentFolder = LibraryItem::find($this->parentId);
         }
@@ -43,27 +45,70 @@ protected function getHeaderActions(): array
                 ->color('gray');
         }
         
-        // Add "Create" action
-        $actions[] = CreateAction::make()
-            ->url(fn (): string => 
-                $this->parentId 
-                    ? static::getResource()::getUrl('create', ['parent' => $this->parentId])
-                    : static::getResource()::getUrl('create')
-            );
+        // Add "Create Folder" modal action
+        $actions[] = Action::make('create_folder')
+            ->label('Create Folder')
+            ->icon('heroicon-o-folder-plus')
+            ->color('success')
+            ->form([
+                TextInput::make('name')
+                    ->label('Folder Name')
+                    ->required()
+                    ->maxLength(255)
+                    ->placeholder('Enter folder name'),
+            ])
+            ->action(function (array $data): void {
+                LibraryItem::create([
+                    'name' => $data['name'],
+                    'type' => 'folder',
+                    'parent_id' => $this->parentId,
+                    'created_by' => auth()->user()?->id,
+                ]);
+                
+                $this->redirect(static::getResource()::getUrl('index', $this->parentId ? ['parent' => $this->parentId] : []));
+            });
+        
+        // Add "Upload File" modal action
+        $actions[] = Action::make('upload_file')
+            ->label('Upload File')
+            ->icon('heroicon-o-document-plus')
+            ->color('primary')
+            ->form([
+                FileUpload::make('file')
+                    ->label('Upload File')
+                    ->required()
+                    ->acceptedFileTypes(['*'])
+                    ->maxSize(10240) // 10MB
+                    ->disk('public')
+                    ->directory('library-files')
+                    ->visibility('private'),
+            ])
+            ->action(function (array $data): void {
+                $file = $data['file'];
+                
+                LibraryItem::create([
+                    'name' => $file->getClientOriginalName(),
+                    'type' => 'file',
+                    'parent_id' => $this->parentId,
+                    'created_by' => auth()->user()?->id,
+                ]);
+                
+                $this->redirect(static::getResource()::getUrl('index', $this->parentId ? ['parent' => $this->parentId] : []));
+            });
         
         return $actions;
     }
 
     protected function getTableQuery(): \Illuminate\Database\Eloquent\Builder
     {
         $query = parent::getTableQuery();
-        
+
         if ($this->parentId) {
             $query->where('parent_id', $this->parentId);
         } else {
             $query->whereNull('parent_id');
         }
-        
+
         return $query;
     }
 
@@ -72,7 +117,7 @@ public function getTitle(): string
         if ($this->parentFolder) {
             return $this->parentFolder->name;
         }
-        
+
         return 'All Folders';
     }
 
@@ -81,21 +126,21 @@ public function getBreadcrumbs(): array
         $breadcrumbs = [
             static::getResource()::getUrl() => 'All Folders',
         ];
-        
+
         if ($this->parentFolder) {
             $current = $this->parentFolder;
             $path = [];
-            
+
             while ($current) {
                 array_unshift($path, $current);
                 $current = $current->parent;
             }
-            
+
             foreach ($path as $folder) {
                 $breadcrumbs[static::getResource()::getUrl('index', ['parent' => $folder->id])] = $folder->name;
             }
         }
-        
+
         return $breadcrumbs;
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -15,9 +15,9 @@ class CreateLibraryItem extends CreateRecord`
`15`	`15`	`public function mount(): void`
`16`	`16`	`{`
`17`	`17`	`parent::mount();`
`18`		`-`
	`18`	`+`
`19`	`19`	`$this->parentId = request()->get('parent');`
`20`		`-`
	`20`	`+`
`21`	`21`	`if ($this->parentId) {`
`22`	`22`	`$this->form->fill([`
`23`	`23`	`'parent_id' => $this->parentId,`
`@@ -30,9 +30,9 @@ protected function mutateFormDataBeforeCreate(array $data): array`
`30`	`30`	`if ($this->parentId) {`
`31`	`31`	`$data['parent_id'] = $this->parentId;`
`32`	`32`	`}`
`33`		`-`
	`33`	`+`
`34`	`34`	`$data['created_by'] = auth()->id();`
`35`		`-`
	`35`	`+`
`36`	`36`	`return $data;`
`37`	`37`	`}`
`38`	`38`	`}`