Skip to content

Commit 5f4859c

Browse files
Merge pull request #131 from TheAcharya/dev
Updated Notion Module and Profile Validation
2 parents ecfae62 + ff978d1 commit 5f4859c

File tree

7 files changed

+33
-12
lines changed

7 files changed

+33
-12
lines changed

CHANGELOG.md

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,20 @@
11
# Changelog
22

3+
### 1.4.1 (13)
4+
5+
**🎉 Released:**
6+
- 8th October 2025
7+
8+
**🔨 Improvements:**
9+
- Update Notion Database Profile validation
10+
- Updated Notion Module CSV2Notion Neo to version 2.0.0
11+
- Notion module have been migrated from unofficial Notion private API to official [Notion API](https://www.notion.so/my-integrations)
12+
- Notion Database URL is now a required field
13+
- Automatic database creation is no longer supported
14+
- Updated [Database Settings](https://markerdata.theacharya.co/user-guide/databases/) guide
15+
16+
---
17+
318
### 1.4.0 (12)
419

520
**🎉 Released:**

Distribution/version.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
v1.4.0
1+
v1.4.1

SECURITY.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
| Version | Supported |
66
| ------- | ------------------ |
7-
| 1.4.0 | :white_check_mark: |
7+
| 1.4.1 | :white_check_mark: |
88

99
## Reporting a Vulnerability
1010

Source/Marker Data/Marker Data.xcodeproj/project.pbxproj

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1340,7 +1340,7 @@
13401340
"CODE_SIGN_IDENTITY[sdk=macosx*]" = "Apple Development";
13411341
CODE_SIGN_STYLE = Automatic;
13421342
COMBINE_HIDPI_IMAGES = YES;
1343-
CURRENT_PROJECT_VERSION = 12;
1343+
CURRENT_PROJECT_VERSION = 13;
13441344
ENABLE_HARDENED_RUNTIME = YES;
13451345
FRAMEWORK_SEARCH_PATHS = (
13461346
/Library/Frameworks,
@@ -1368,7 +1368,7 @@
13681368
LOCALIZATION_PREFERS_STRING_CATALOGS = YES;
13691369
MACH_O_TYPE = mh_execute;
13701370
MACOSX_DEPLOYMENT_TARGET = 13.0;
1371-
MARKETING_VERSION = 1.4.0;
1371+
MARKETING_VERSION = 1.4.1;
13721372
OTHER_LDFLAGS = (
13731373
"-fapplication-extension",
13741374
"-lProExtension",
@@ -1395,7 +1395,7 @@
13951395
"CODE_SIGN_IDENTITY[sdk=macosx*]" = "Apple Development";
13961396
CODE_SIGN_STYLE = Automatic;
13971397
COMBINE_HIDPI_IMAGES = YES;
1398-
CURRENT_PROJECT_VERSION = 12;
1398+
CURRENT_PROJECT_VERSION = 13;
13991399
ENABLE_HARDENED_RUNTIME = YES;
14001400
FRAMEWORK_SEARCH_PATHS = (
14011401
/Library/Frameworks,
@@ -1423,7 +1423,7 @@
14231423
LOCALIZATION_PREFERS_STRING_CATALOGS = YES;
14241424
MACH_O_TYPE = mh_execute;
14251425
MACOSX_DEPLOYMENT_TARGET = 13.0;
1426-
MARKETING_VERSION = 1.4.0;
1426+
MARKETING_VERSION = 1.4.1;
14271427
OTHER_LDFLAGS = (
14281428
"-fapplication-extension",
14291429
"-lProExtension",
@@ -1571,7 +1571,7 @@
15711571
"CODE_SIGN_IDENTITY[sdk=macosx*]" = "Apple Development";
15721572
CODE_SIGN_STYLE = Automatic;
15731573
COMBINE_HIDPI_IMAGES = YES;
1574-
CURRENT_PROJECT_VERSION = 12;
1574+
CURRENT_PROJECT_VERSION = 13;
15751575
DEAD_CODE_STRIPPING = YES;
15761576
DEVELOPMENT_ASSET_PATHS = "\"Marker Data/Preview Content\"";
15771577
ENABLE_HARDENED_RUNTIME = YES;
@@ -1599,7 +1599,7 @@
15991599
"$(SDKROOT)/usr/lib/swift",
16001600
);
16011601
MACOSX_DEPLOYMENT_TARGET = 13.0;
1602-
MARKETING_VERSION = 1.4.0;
1602+
MARKETING_VERSION = 1.4.1;
16031603
PRODUCT_BUNDLE_IDENTIFIER = co.theacharya.MarkerData;
16041604
PRODUCT_NAME = "$(TARGET_NAME)";
16051605
PROVISIONING_PROFILE_SPECIFIER = "";
@@ -1618,7 +1618,7 @@
16181618
"CODE_SIGN_IDENTITY[sdk=macosx*]" = "Apple Development";
16191619
CODE_SIGN_STYLE = Automatic;
16201620
COMBINE_HIDPI_IMAGES = YES;
1621-
CURRENT_PROJECT_VERSION = 12;
1621+
CURRENT_PROJECT_VERSION = 13;
16221622
DEAD_CODE_STRIPPING = YES;
16231623
DEVELOPMENT_ASSET_PATHS = "\"Marker Data/Preview Content\"";
16241624
ENABLE_HARDENED_RUNTIME = YES;
@@ -1646,7 +1646,7 @@
16461646
"$(SDKROOT)/usr/lib/swift",
16471647
);
16481648
MACOSX_DEPLOYMENT_TARGET = 13.0;
1649-
MARKETING_VERSION = 1.4.0;
1649+
MARKETING_VERSION = 1.4.1;
16501650
PRODUCT_BUNDLE_IDENTIFIER = co.theacharya.MarkerData;
16511651
PRODUCT_NAME = "$(TARGET_NAME)";
16521652
PROVISIONING_PROFILE_SPECIFIER = "";

Source/Marker Data/Marker Data/Models/Database/Profile Models/Notion/NotionDBModel.swift

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,9 @@ final class NotionDBModel: DatabaseProfileModel {
3535
if self.token.isEmpty {
3636
throw NotionValidationError.noToken
3737
}
38+
if self.databaseURL.isEmpty {
39+
throw NotionValidationError.noURL
40+
}
3841
if self.renameKeyColumn == "Marker ID" {
3942
throw NotionValidationError.illegalRenameKeyColumn
4043
}

Source/Marker Data/Marker Data/Models/Errors/DatabaseErrors.swift

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ enum NotionValidationError: Error {
3030
case emptyName
3131
case emptyWorkspaceName
3232
case noToken
33+
case noURL
3334
case illegalRenameKeyColumn
3435
}
3536

@@ -42,6 +43,8 @@ extension NotionValidationError: LocalizedError {
4243
"Empty workspace field"
4344
case .noToken:
4445
"No token provided"
46+
case .noURL:
47+
"No URL provided"
4548
case .illegalRenameKeyColumn:
4649
"'Marker ID' is the default key column and cannot be used in the 'Rename Key Column' field. Please enter a different key column name if you wish to use this field."
4750
}

Source/Marker Data/Marker Data/Views/Detail Views/Database/Create Sheet/NotionFormView.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ struct NotionFormView: View {
2222
)
2323

2424
PlatformInfoTextField(
25-
title: "Notion V2 Token",
25+
title: "Notion Integration Token",
2626
prompt: "Token",
2727
text: $profileModel.token,
2828
isRequired: true,
@@ -33,7 +33,7 @@ struct NotionFormView: View {
3333
title: "Notion Database URL",
3434
prompt: "Database URL",
3535
text: $profileModel.databaseURL,
36-
isRequired: false,
36+
isRequired: true,
3737
secureField: true
3838
)
3939

0 commit comments

Comments
 (0)