Malformed tooljet deployment yaml when redis is disabled

[sebaap]

This commit introduced an issue when redis is disabled because the {{- end }} is in the wrong line, which leaves a dangling

              valueFrom:
                secretKeyRef:
                  name: {{ include "tooljet.fullname" . }}-redis
                  key: password

that goes into the PGRST_JWT_SECRET here

When running helm install tooljet tooljet/tooljet with the default values (redis disabled), it throws:

Error: INSTALLATION FAILED: 1 error occurred:
   * Deployment.apps "tooljet" is invalid: spec.template.spec.containers[0].env[12].valueFrom: Invalid value: "": may not be specified when `value` is not empty

How to reproduce:

helm repo add tooljet https://tooljet.github.io/helm-charts
helm install tooljet tooljet/tooljet

Happy to submit a PR

[biclighter81]

We have the same issue. Installing the chart with default values does not work because of the misplaced {{- end }}

[adishM98]

We've identified and resolved a critical template syntax error in the ToolJet Helm chart that prevented successful deployments when using the default configuration (with Redis disabled).

What Happened

During a recent update, a misplaced closing tag ({{- end }}) was introduced in the deployment template (charts/tooljet/templates/deployment.yaml). This resulted in:

• The Redis configuration conditional being closed prematurely on line 97
• The REDIS_PASSWORD environment variable’s valueFrom block being left outside the expected conditional
• When redis.enabled: false (the default), this orphaned block incorrectly attaching to PGRST_JWT_SECRET
• Kubernetes rejecting the rendered YAML with the validation error:
  "may not be specified when 'value' is not empty"

Impact

Any deployment using the default Helm values (redis.enabled: false) would fail during installation with a Kubernetes validation error. This affected all users attempting fresh installations with the default settings.

Resolution

The issue has now been fixed:

1. deployment.yaml – The misplaced {{- end }} has been moved from line 97 to line 101, ensuring the entire Redis configuration block (including the valueFrom secret reference) is properly wrapped inside the {{- if .Values.redis.enabled }} conditional.
2. worker.yaml – Added the missing {{- if .Values.redis.enabled }} conditional around all Redis-related environment variables (lines 90–102).

Validation

• helm lint passes successfully
• Templates render correctly for both redis.enabled: true and redis.enabled: false

We appreciate you flagging this issue. Apologies for the oversight and any inconvenience caused.