Skip to content

Commit b3717dd

Browse files
authored
Merge pull request #60 from Tumiya/feature/cleanup-unnecessary-shellcheck-disabled-issues
Clean up unnecessary Shellcheck disabled issues
2 parents 7448d15 + 577c347 commit b3717dd

9 files changed

+9
-22
lines changed

gitrise.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
#!/usr/bin/env bash
2+
23
# shellcheck disable=SC2155
34
# disbales "Declare and assign separately to avoid masking return values."
45
# shellcheck disable=SC2120

tests/build_artifacts_tests.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
#!/usr/bin/env bash
22

3+
#shellcheck disable=SC1091
4+
35
source ./gitrise.sh -T
46

57
testFetchingBuildArtifactsSlugs() {

tests/build_info_tests.sh

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
11
#!/usr/bin/env bash
22

3-
# shellcheck disable=SC1091,SC2155,SC2154,SC2034
4-
# Not following: (error message here)
5-
# Declare and assign separately to avoid masking return values.
6-
# var is referenced but not assigned.
7-
# var appears unused
3+
# shellcheck disable=SC1091,SC2155
84

95
source ./gitrise.sh -T
106

tests/build_logs_tests.sh

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
#!/usr/bin/env bash
22

3-
# shellcheck disable=SC1091,SC2155,SC2154
4-
# Not following: (error message here)
5-
# Declare and assign separately to avoid masking return values.
6-
# var is referenced but not assigned.
3+
# shellcheck disable=SC1091,SC2155
74

85
source ./gitrise.sh -T
96

tests/build_status_message_tests.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
#!/usr/bin/env bash
22

33
# shellcheck disable=SC1091,SC2155
4-
# Not following: (error message here)
5-
# Declare and assign separately to avoid masking return values.
4+
65
source ./gitrise.sh -T
76

87
testBuildTimedOutMessage() {

tests/download_single_artifacts_tests.sh

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
11
#!/usr/bin/env bash
22

3-
# shellcheck disable=SC1091,SC2155,SC2154,SC2034
4-
# Not following: (error message here)
5-
# Declare and assign separately to avoid masking return values.
6-
# var is referenced but not assigned.
7-
# var appears unused
3+
# shellcheck disable=SC1091,SC2155
84

95
source ./gitrise.sh -T
106

tests/gitrise_logs_tests.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
#!/usr/bin/env bash
22

3-
# shellcheck disable=SC1091,SC2155,SC2154
4-
# Not following: (error message here)
3+
# shellcheck disable=SC1091,SC2155
54

65
source ./gitrise.sh -T -d
76

tests/input_validation_tests.sh

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
#!/usr/bin/env bash
22

33
# shellcheck disable=SC1091,SC2155
4-
# Not following: (error message here)
5-
# Declare and assign separately to avoid masking return values.
64

75
testMissingWorkflow() {
86
local expected_message="ERROR: Missing arguments(s). All these args must be passed: --workflow,--slug,--access-token"

tests/options_tests.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
#!/usr/bin/env bash
22

33
# shellcheck disable=SC1091,SC2155
4-
# Not following: (error message here)
5-
# Declare and assign separately to avoid masking return values.
4+
65
source ./gitrise.sh -T
76

87
testEnvVars() {

0 commit comments

Comments
 (0)