Skip to content

Commit d23725b

Browse files
committed
Remove volta from documentation. Updated GHA instructions and Dockerfiles
1 parent 57b2969 commit d23725b

File tree

20 files changed

+96
-116
lines changed

20 files changed

+96
-116
lines changed

.github/workflows/debugger-py.yml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@ name: Python Debugger Image
22

33
on:
44
workflow_dispatch:
5-
push:
6-
branches:
7-
- issue-690-debugger
85

96
env:
107
REGISTRY: ghcr.io
@@ -26,7 +23,7 @@ jobs:
2623
timeout-minutes: 15
2724
steps:
2825
- name: Checkout
29-
uses: actions/checkout@v4
26+
uses: actions/checkout@v6
3027

3128
- name: Login to GitHub Container Registry
3229
uses: docker/login-action@v3
@@ -56,7 +53,7 @@ jobs:
5653
labels: ${{ steps.meta.outputs.labels }}
5754

5855
- name: Attest
59-
uses: actions/attest-build-provenance@v1
56+
uses: actions/attest-build-provenance@v3
6057
with:
6158
subject-name: ${{ env.REGISTRY }}/${{ env.REPO_NAME }}/${{ env.CONTAINER_NAME }}
6259
subject-digest: ${{ steps.push.outputs.digest }}

.github/workflows/ghp.yml

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,10 @@ jobs:
1818

1919
steps:
2020
- name: Checkout
21-
uses: actions/checkout@v4
21+
uses: actions/checkout@v6
2222

23-
- name: Volta
24-
uses: volta-cli/action@v4
25-
26-
- name: Use pnpm
27-
uses: pnpm/action-setup@v3
28-
with:
29-
version: 9
23+
- name: mise-en-place
24+
uses: jdx/mise-action@v2
3025

3126
- name: Install
3227
shell: bash
@@ -51,7 +46,7 @@ jobs:
5146
uses: actions/configure-pages@v5
5247

5348
- name: Upload artifact
54-
uses: actions/upload-pages-artifact@v3
49+
uses: actions/upload-pages-artifact@v4
5550
with:
5651
path: ./packages/examples/production/
5752

.github/workflows/ls-clangd.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
timeout-minutes: 150
2525
steps:
2626
- name: Checkout
27-
uses: actions/checkout@v4
27+
uses: actions/checkout@v6
2828

2929
- name: Login to GitHub Container Registry
3030
uses: docker/login-action@v3
@@ -54,7 +54,7 @@ jobs:
5454
labels: ${{ steps.meta_configure.outputs.labels }}
5555

5656
- name: Attest (configure)
57-
uses: actions/attest-build-provenance@v1
57+
uses: actions/attest-build-provenance@v3
5858
with:
5959
subject-name: ${{ env.REGISTRY }}/${{ env.REPO_NAME }}/${{ env.CONTAINER_NAME_CONFIGURE }}
6060
subject-digest: ${{ steps.push_configure.outputs.digest }}
@@ -81,7 +81,7 @@ jobs:
8181
labels: ${{ steps.meta_build.outputs.labels }}
8282

8383
- name: Attest (build)
84-
uses: actions/attest-build-provenance@v1
84+
uses: actions/attest-build-provenance@v3
8585
with:
8686
subject-name: ${{ env.REGISTRY }}/${{ env.REPO_NAME }}/${{ env.CONTAINER_NAME_BUILD }}
8787
subject-digest: ${{ steps.push_build.outputs.digest }}

.github/workflows/ls-eclipsejdt.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
timeout-minutes: 15
2424
steps:
2525
- name: Checkout
26-
uses: actions/checkout@v4
26+
uses: actions/checkout@v6
2727

2828
- name: Login to GitHub Container Registry
2929
uses: docker/login-action@v3
@@ -53,7 +53,7 @@ jobs:
5353
labels: ${{ steps.meta.outputs.labels }}
5454

5555
- name: Attest
56-
uses: actions/attest-build-provenance@v1
56+
uses: actions/attest-build-provenance@v3
5757
with:
5858
subject-name: ${{ env.REGISTRY }}/${{ env.REPO_NAME }}/${{ env.CONTAINER_NAME }}
5959
subject-digest: ${{ steps.push.outputs.digest }}

.github/workflows/ls-groovy.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
timeout-minutes: 15
2424
steps:
2525
- name: Checkout
26-
uses: actions/checkout@v4
26+
uses: actions/checkout@v6
2727

2828
- name: Login to GitHub Container Registry
2929
uses: docker/login-action@v3
@@ -53,7 +53,7 @@ jobs:
5353
labels: ${{ steps.meta.outputs.labels }}
5454

5555
- name: Attest
56-
uses: actions/attest-build-provenance@v1
56+
uses: actions/attest-build-provenance@v3
5757
with:
5858
subject-name: ${{ env.REGISTRY }}/${{ env.REPO_NAME }}/${{ env.CONTAINER_NAME }}
5959
subject-digest: ${{ steps.push.outputs.digest }}

.github/workflows/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020

2121
steps:
2222
- name: Checkout
23-
uses: actions/checkout@v4
23+
uses: actions/checkout@v6
2424

2525
- name: mise-en-place
2626
uses: jdx/mise-action@v2

.github/workflows/peer.yml

Lines changed: 0 additions & 39 deletions
This file was deleted.

.github/workflows/verify.yml

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,10 @@ jobs:
1313

1414
steps:
1515
- name: Checkout
16-
uses: actions/checkout@v4
16+
uses: actions/checkout@v6
1717

18-
- name: Volta
19-
uses: volta-cli/action@v4
20-
21-
- name: Use pnpm
22-
uses: pnpm/action-setup@v3
23-
with:
24-
version: 9
18+
- name: mise-en-place
19+
uses: jdx/mise-action@v2
2520

2621
- name: Install
2722
shell: bash

README.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,11 +84,17 @@ Check find the [full compatibility table](https://github.com/TypeFox/monaco-lang
8484

8585
## Getting started
8686

87+
We recommend [mise-en-place](https://mise.jdx.dev/) to setup corrects version of required tools like `node` and `npm` (described [here](./docs/guides/troubleshooting.md#mise-en-place)). If you have `mise` installed use the optional isntruction below.
88+
8789
On your local machine you can prepare your dev environment as follows. At first it is advised to build everything. Locally, from a terminal do:
8890

8991
```bash
92+
# clone the git repository
9093
git clone https://github.com/TypeFox/monaco-languageclient.git
9194
cd monaco-languageclient
95+
# optional: if you have mise installed
96+
mise upgrade
97+
# install npm dependencies
9298
npm i
9399
# Cleans-up, compiles and builds everything
94100
npm run build

docs/guides/troubleshooting.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,9 @@ If your dependency stack already contains a reference `monaco-editor` you must e
6464
}
6565
```
6666

67-
### Volta
67+
### mise-en-place
6868

69-
There are [Volta](https://volta.sh/) instructions in the `package.json` files. When you have Volta available it will ensure the exactly specified `node` and `npm` versions are used.
69+
We use [mise-en-place](https://mise.jdx.dev/) for tool management. In the past we used Volta, but unfourtunately is has become unmaintained. We will phase out volta instructions in the future. In the repository root you find [mise.toml](../../mise.toml) which specifies all tools required with the correct versions. Use `mise upgrade` to install the required tools.
7070

7171
### Bad Polyfills
7272

0 commit comments

Comments
 (0)