Skip to content

web ingress terraform tag format #12

@AndEsterson

Description

@AndEsterson

In the current version of developer_guide/web_ingress, the tag examples for the terraform style of ingress tags use / as a separator, as far as I'm aware these should be _, e.g in https://github.com/ucl-arc-environments/condenser-ingress-rancher/blob/main/rancher/rancher.go

func (vmi VirtualMachineInstance) getIngressLabel(ingressLabel string, key string) (string, bool) {
  var label string
  var containsLabel bool

  if vmi.IsTagged {
    label, containsLabel = vmi.VMLabels[fmt.Sprintf("tag.harvesterhci.io/condenser_ingress_%s_%s", key, ingressLabel)]
  } else {
    label, containsLabel = vmi.Labels[fmt.Sprintf("condenser.ingress.%s/%s", key, ingressLabel)]
  }
  return label, containsLabel
}

(would make a PR, but I don't have perms to push a branch, sorry!)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions