cannot disable menu buttons in extended theme

[barbeque-squared]

How to reproduce:

• Copy themes/Modern to themes/Yolo
• Create a themes/Yolo.ini as below
• Use it in USDX

Yolo.ini:

[Theme]
Name = Yolo
BaseTheme = Modern
Creator = barbeque
US_Version = USD 110
DefaultSkin = Blue

[MainButtonMulti]
Enabled = 0

[MainButtonMultiText1]
Enabled = 0

[MainButtonJukebox]
Enabled = 0

[MainButtonJukeboxText1]
Enabled = 0

Expected result:

• Party and Jukebox menu buttons are not visible
• If Sing is selected and you press Right, it immediately goes to Options

Actual result:

• Party and Jukebox menu buttons are not visible
• If Sing is selected and you press Right, it selects Party, but only the text is visible

Details:

• I assume this has something to do with Refactor Theme System and Default Themes #1135 so I'll tag @complexlogic
• Before that PR I had simply deleted those theme sections completely from my .ini and it did the Expected behaviour

I actually noticed this a while ago already, just forgot to create an issue for it, though I doubt many people are modifying menus like this anyway, so there's no real rush.

[complexlogic]

I mentioned in #1135 (comment) that using Enabled = false only works for the numbered texts/statics, which does not include menu buttons. So this is expected behavior.

However, I'm open to implementing this if you think it would be valuable. Should be relatively easy to add.

[barbeque-squared]

Ah, my fault then. I must have confused "only text and statics" versus "but not required elements like the sing time progress thing". Menu buttons are (I guess?) somewhere in between, in that they're more than text/statics, but also sort-of not technically required.

I'm 50/50 on whether it's useful to implement for menu buttons or not.

Pro:

• at least on the main menu, it seems buttons used to be optional
• it's already doing something with Enabled, it's like it's drawing the button but it's completely transparent

Con:

• there's probably some menus around where removing half the buttons is going to cause more interesting/breaking effects
• I'm well aware of my stance on adding stuff for the <0.1% and I suspect this is more <0.0001%

Having typed the above, I think my biggest issue is that the expected behaviour should be one of:

• it completely ignores Enabled = false for buttons (and if someone sets it to false, it should log an error/warning during theme loading and set it to true anyway)
• it properly implements Enabled for buttons (could be as simple as just setting X/W/Y/H to 0, there must be some code that handles it like that already -- or better yet change those bits of code to properly handle Enabled)

and right now it's somewhere in-between? Though I should probably also try and see what happens if I try to set Enabled = false on some actually required thing.