Linking Issue

[samielhini]

I am almost certain I am doing something wrong.

I do not get this error for luna::server but when I reference luna::router I get the following during linking:

CMakeFiles/GlacierHardwareController.dir/Webserver.cpp.o: In function Webserver::Webserver(int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >)': /home/sami.elhini/Code/glacierhardwarecontrollerv2/Webserver.cpp:13: undefined reference to luna::router::router(std::__cxx11::basic_string<char, std::char_traits, std::allocator >)'
collect2: error: ld returned 1 exit status
CMakeFiles/GlacierHardwareController.dir/build.make:307: recipe for target 'bin/GlacierHardwareController' failed
make[2]: *** [bin/GlacierHardwareController] Error 1
CMakeFiles/Makefile2:67: recipe for target 'CMakeFiles/GlacierHardwareController.dir/all' failed
make[1]: *** [CMakeFiles/GlacierHardwareController.dir/all] Error 2
Makefile:83: recipe for target 'all' failed
make: *** [all] Error 2

CMakeLists.txt Excerpt:

set(CMAKE_CXX_STANDARD 14)
if(EXISTS ${CMAKE_BINARY_DIR}/conanbuildinfo.cmake)
include(${CMAKE_BINARY_DIR}/conanbuildinfo.cmake)
conan_basic_setup()
else()
message(WARNING "The file conanbuildinfo.cmake doesn't exist, you have to run conan install first")
endif()

target_link_libraries(GlacierHardwareController ${LIBS} ${CONAN_LIBS})

Code Excerpt:

Webserver::Webserver(const int port, const std::string directory) {
this->port = port;
luna::router rtr("/");
//luna::router router{"/"};
//assets.serve_files("/", directory);
//srv.add_router(assets);
}

void Webserver::run(){

srv.start(this->port);

}

conanfile.txt

[requires]
luna/4.0.0@DEGoodmanWilson/stable
nl-json/2.1.1@genvidtech/1.4.0

[generators]
cmake

[UncannyBingo]

Ok that’s weird! I’ll look into that, thanks for raising it!

[samielhini]

Definitely. I really like your coding style and would be thrilled to get this working. I suppose I can experiment with a project with fewer dependencies. I have a fair number of CMAKE dependencies. I would think namespaces would avoid collisions and it is bizarre that only that class does not seem to produce a linkable symbol. Could it be a C dependency without an extern "C" block?

[samielhini]

stdint.h is included by types.h. Types.h does not have it in an extern C block and stdint.h does not seem to have an extern C block either. Just a thought.

[samielhini]

Reproduced with a totally clean project with no other dependencies. See attached.

TestLuna.zip

[UncannyBingo]

Will work on replicating and fixing this morning. Thank you for the replication case!

[UncannyBingo]

Could you tell me what OS and compiler you are using, BTW?

[UncannyBingo]

Just to eliminate some possibilities, let's do this to your conanfile. At the moment, the only version of Luna that stands a change of compiling is 5.0.0. 4.0.0 won't fly. Change your conanfile to look like this:

[requires]
luna/5.0.0@samielhini/testing

[generators]
cmake

Now, go clone the Luna repo to your local machine, and inside the luna directory, do this:

git checkout 5.0.0/testing
conan create . samielhini/testing

This will put a private build on your machine so you can tinker with Luna locally, and have those changes reflected in your test program. Every time you make a change to luna, just re-run the conan create … command.

As it stands, like this, I get one build error right off the bat, that I am going to submit a fix for now, a missing header file in the package deployment!

[UncannyBingo]

OK, that build error is fixed, and with those changes to the conanfile, I am able to get your sample compiling, linking, and running under OS X.

[samielhini]

I will give it a try. I am on Debian 9. I actually do all my other coding work on a Mac but use Debian when I work on my embedded code.

[samielhini]

Quite strange:

canning dependencies of target TestLuna
[ 50%] Building CXX object CMakeFiles/TestLuna.dir/main.cpp.o
[100%] Linking CXX executable bin/TestLuna
CMakeFiles/TestLuna.dir/main.cpp.o: In function main': /home/sami.elhini/Code/TestLuna/main.cpp:8: undefined reference to luna::router::router(std::__cxx11::basic_string<char, std::char_traits, std::allocator >)'
/home/sami.elhini/Code/TestLuna/main.cpp:9: undefined reference to `luna::router::serve_files(std::__cxx11::basic_string<char, std::char_traits, std::allocator >, std::__cxx11::basic_string<char, std::char_traits, std::allocator >)'
collect2: error: ld returned 1 exit status
CMakeFiles/TestLuna.dir/build.make:94: recipe for target 'bin/TestLuna' failed
make[3]: *** [bin/TestLuna] Error 1
CMakeFiles/Makefile2:67: recipe for target 'CMakeFiles/TestLuna.dir/all' failed
make[2]: *** [CMakeFiles/TestLuna.dir/all] Error 2
CMakeFiles/Makefile2:79: recipe for target 'CMakeFiles/TestLuna.dir/rule' failed
make[1]: *** [CMakeFiles/TestLuna.dir/rule] Error 2
Makefile:118: recipe for target 'TestLuna' failed
make: *** [TestLuna] Error 2

I will note that I had to use --build missing with my Conan install file for CMake.

[UncannyBingo]

That's super weird. Do you have, or can you recommend, a Docker image or other VM image that I can use to try to replicate your environment? It looks like symbols aren't getting exported from the Luna library…

[samielhini]

Hi Don, I have a relatively HUGE VMWARE image. I may try to create a Docker image, rerun the build, and if I experience the same issue find a way to get that Docker image to you. Sami

…

Sent from my iPhone

On Mar 16, 2018, at 10:21, Don Goodman-Wilson ***@***.***> wrote: That's super weird. Do you have, or can you recommend, a Docker image or other VM image that I can use to try to replicate your environment? It looks like symbols aren't getting exported from the Luna library… — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[UncannyBingo]

👍