fix: refactor cart operations and improve assertions in add to cart tests

Author: Lenajava1

tests_e2e/tests/test_e2e_category_page_add_product_to_cart.py

@@ -42,39 +42,40 @@ def test_e2e_category_add_product_to_cart_with_add_to_cart_button(
     category_page = CategoryPage(config, page, category["seoInfos"][0]["semanticUrl"])
     category_page.navigate()
 
-    cart = cart_operations.get_cart(
-        store_id=config["STORE_ID"],
-        user_id=user["id"],
-        currency_code="USD",
-        culture_name="en-US",
-    )
-
     product_card = category_page.get_product_card_by_sku(product["code"])
     product_card.add_to_cart_component.quantity_input.fill(quantity_to_add)
     product_card.add_to_cart_component.add_to_cart_text_button.click()
 
-    expect(product_card.count_in_cart_label).to_be_visible(), "Count in cart label is not visible"
-    expect(product_card.count_in_cart_label).to_have_text(
-        quantity_to_add
-    ), "Count in cart label is not equal to product quantity to add"
+    expect(product_card.count_in_cart_label, "Count in cart label is not visible").to_be_visible()
+    expect(
+        product_card.count_in_cart_label, "Count in cart label is not equal to product quantity to add"
+    ).to_have_text(quantity_to_add)
 
     cart_page = CartPage(config, page)
     cart_page.navigate()
     page.wait_for_load_state("networkidle")
 
-    line_item = cart_page.get_line_item_by_sku(product["code"])
+    cart = cart_operations.get_cart(
+        store_id=config["STORE_ID"],
+        user_id=user["id"],
+        currency_code="USD",
+        culture_name="en-US",
+    )
 
-    assert line_item.sku == product["code"], f"Line item sku is not equal to product sku: {product["code"]}"
-    assert (
-        line_item.add_to_cart_component.quantity_input.input_value() == quantity_to_add
-    ), f"Line item quantity is not equal to product quantity to add: {quantity_to_add}"
+    try:
+        line_item = cart_page.get_line_item_by_sku(product["code"])
 
-    cart_operations.remove_cart(
-        payload={
-            "cartId": cart["id"],
-            "userId": user["id"],
-        }
-    )
+        assert line_item.sku == product["code"], f"Line item sku is not equal to product sku: {product['code']}"
+        assert (
+            line_item.add_to_cart_component.quantity_input.input_value() == quantity_to_add
+        ), f"Line item quantity is not equal to product quantity to add: {quantity_to_add}"
+    finally:
+        cart_operations.remove_cart(
+            payload={
+                "cartId": cart["id"],
+                "userId": user["id"],
+            }
+        )
 
 
 @pytest.mark.e2e
@@ -113,13 +114,14 @@ def test_e2e_category_add_product_to_cart_with_quantity_stepper(
     product_card.quantity_stepper_component.increment_button.click()
     product_card.quantity_stepper_component.increment_button.click()
 
-    expect(product_card.quantity_stepper_component.quantity_input).to_have_value(
-        str(quantity_to_add)
-    ), f"Quantity input is not equal to {quantity_to_add}"
-    expect(product_card.count_in_cart_label).to_be_visible(), "Count in cart label is not visible"
-    expect(product_card.count_in_cart_label).to_have_text(
-        str(quantity_to_add)
-    ), "Count in cart label is not equal to product quantity to add"
+    expect(
+        product_card.quantity_stepper_component.quantity_input,
+        f"Quantity input is not equal to {quantity_to_add}",
+    ).to_have_value(str(quantity_to_add))
+    expect(product_card.count_in_cart_label, "Count in cart label is not visible").to_be_visible()
+    expect(
+        product_card.count_in_cart_label, "Count in cart label is not equal to product quantity to add"
+    ).to_have_text(str(quantity_to_add))
 
     cart_page = CartPage(config, page)
     cart_page.navigate()
@@ -132,16 +134,18 @@ def test_e2e_category_add_product_to_cart_with_quantity_stepper(
         culture_name="en-US",
     )
 
-    line_item = cart_page.get_line_item_by_sku(product["code"])
-
-    assert line_item.sku == product["code"], f"Line item sku is not equal to product sku: {product["code"]}"
-    expect(line_item.quantity_stepper_component.quantity_input).to_have_value(
-        str(quantity_to_add)
-    ), f"Line item quantity is not equal to product quantity to add: {quantity_to_add}"
-
-    cart_operations.remove_cart(
-        payload={
-            "cartId": cart["id"],
-            "userId": user["id"],
-        }
-    )
+    try:
+        line_item = cart_page.get_line_item_by_sku(product["code"])
+
+        assert line_item.sku == product["code"], f"Line item sku is not equal to product sku: {product['code']}"
+        expect(
+            line_item.quantity_stepper_component.quantity_input,
+            f"Line item quantity is not equal to product quantity to add: {quantity_to_add}",
+        ).to_have_value(str(quantity_to_add))
+    finally:
+        cart_operations.remove_cart(
+            payload={
+                "cartId": cart["id"],
+                "userId": user["id"],
+            }
+        )