Simplify javascript-lint module definition and ensure proper types

Author: westonruter

package-lock.json

@@ -30,6 +30,7 @@
 		"@lodder/grunt-postcss": "^3.1.1",
 		"@playwright/test": "1.56.1",
 		"@pmmmwh/react-refresh-webpack-plugin": "0.6.1",
+		"@types/codemirror": "5.60.17",
 		"@wordpress/e2e-test-utils-playwright": "1.33.2",
 		"@wordpress/prettier-config": "4.33.1",
 		"@wordpress/scripts": "30.26.2",

package.json

@@ -1,21 +1,9 @@
-/* globals define, CodeMirror */
 /* jshint devel: true */
 
 // CodeMirror, copyright (c) by Marijn Haverbeke and others
 // Distributed under an MIT license: https://codemirror.net/5/LICENSE
 
-( function ( mod ) {
-	if ( typeof exports === 'object' && typeof module === 'object' ) {
-		// CommonJS
-		mod( require( 'codemirror' ) );
-	} else if ( typeof define === 'function' && define.amd ) {
-		// AMD
-		define( [ 'codemirror' ], mod );
-		// Plain browser env
-	} else {
-		mod( CodeMirror );
-	}
-} )( function ( CodeMirror ) {
+( ( CodeMirror ) => {
 	'use strict';
 
 	/**
@@ -26,8 +14,8 @@
 	 * @typedef {Object} CodeMirrorLintError
 	 * @property {string} message - Error message.
 	 * @property {'error'} severity - Severity.
-	 * @property {{line: number, ch: number}} from - From position.
-	 * @property {{line: number, ch: number}} to - To position.
+	 * @property {CodeMirror.Position} from - From position.
+	 * @property {CodeMirror.Position} to - To position.
 	 */
 
 	/**
@@ -70,8 +58,8 @@
 				errors.push( {
 					message: error.message,
 					severity: 'error',
-					from: { line, ch: error.column - 1 },
-					to: { line, ch: error.column },
+					from: CodeMirror.Pos( line, error.column - 1 ),
+					to: CodeMirror.Pos( line, error.column ),
 				} );
 			} else {
 				console.warn( '[CodeMirror] Unable to lint JavaScript:', error );
@@ -125,4 +113,4 @@
 		}
 		return 'latest';
 	}
-} );
+} )( require( 'codemirror' ) );