refactor: clear favorites during extension cleanup for improved resource management

ZanzyTHEbar · ZanzyTHEbar · commit b1ca71fb9fd5 · 2025-02-19T17:26:23.000Z
diff --git a/gnome-extension/src/extension.ts b/gnome-extension/src/extension.ts
@@ -120,6 +120,7 @@ export default class VSCodeWorkspacesExtension extends Extension {
             this._indicator.destroy();
             this._indicator = undefined;
         }
+
         this.gsettings = undefined;
         this._log(`VSCode Workspaces Extension disabled`);
     }
@@ -145,6 +146,7 @@ export default class VSCodeWorkspacesExtension extends Extension {
         // Clean up only the cache; leave persistent settings intact
         this._workspaces.clear();
         this._recentWorkspaces.clear();
+        this._favorites.clear();
         this._log(`VSCode Workspaces Extension cleaned up`);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -120,6 +120,7 @@ export default class VSCodeWorkspacesExtension extends Extension {`
`120`	`120`	`this._indicator.destroy();`
`121`	`121`	`this._indicator = undefined;`
`122`	`122`	`}`
	`123`	`+`
`123`	`124`	`this.gsettings = undefined;`
`124`	`125`	this._log(`VSCode Workspaces Extension disabled`);
`125`	`126`	`}`
`@@ -145,6 +146,7 @@ export default class VSCodeWorkspacesExtension extends Extension {`
`145`	`146`	`// Clean up only the cache; leave persistent settings intact`
`146`	`147`	`this._workspaces.clear();`
`147`	`148`	`this._recentWorkspaces.clear();`
	`149`	`+ this._favorites.clear();`
`148`	`150`	this._log(`VSCode Workspaces Extension cleaned up`);
`149`	`151`	`}`
`150`	`152`