Confused on use of *a2a.Task over *a2a.Event on PushSender

[newtonnthiga]

I'm looking for clarity on the use of *a2a.Task over *a2a.Event on PushSender at

a2a-go/a2asrv/tasks.go

Lines 23 to 28 in 4f7471c

	// PushSender defines the interface for sending push notifications
	// about task state changes to external endpoints.
	type PushSender interface {
	// SendPush sends a push notification containing the latest task state. If an error is returned execution is stopped.
	SendPush(ctx context.Context, config *a2a.PushConfig, task *a2a.Task) error
	}

From https://a2a-protocol.org/latest/topics/streaming-and-async/#protocol-specification-references

This specifies that payload should contains one of: task, message, statusUpdate, or artifactUpdate. The *a2a.Task in this case, does not offer any way to distinguish between then whereas *a2a.Event would.

I think the following would make more sense

type PushSender interface {
	// SendPush sends a push notification containing the latest task state. If an error is returned execution is stopped.
	SendPush(ctx context.Context, config *a2a.PushConfig, taskID a2a.TaskID, event *a2a.Event) error
}

// OR

type PushSender interface {
	// SendPush sends a push notification containing the latest task state. If an error is returned execution is stopped.
	SendPush(ctx context.Context, config *a2a.PushConfig, task *a2a.Task, event a2a.Event) error
}

Am I missing something here?

[nicholasbreckwoldt]

This does indeed appear to be out of line with the official a2a spec? I have experimented a bit with changing this from *a2a.Task to *a2a.Event and produced the intended behaviour with only a few minor changes:

a2a-go/a2asrv/tasks.go

• Updating the interface definition as described above by @newtonnthiga

a2a-go/a2asrv/agentexec.go

• Updating the Processor's sendPushNotifications function to accept the taskID and event

• From the processor's Process function, pass through the incoming event for processing, as well as the taskID reference (needed to access the task's PushConfigs from the store).

a2a-go/a2asrv/push/sender.go

• Need to also update relevant function signature in the default HTTPPushSender

Be equally interested to hear if this would be the correct route to go.

[yarolegovich]

You're looking at the unreleased 1.0 spec (see latest in the URL). This is a common point of confusion unfortunately.
In 0.3 which the current SDK implements it is written:

HTTP Body (Task object is sent as JSON payload):

https://a2a-protocol.org/v0.3.0/specification/#95-push-notification-setup-and-usage

[newtonnthiga]

Thanks for clarifying