Skip to content

Commit 71a0d97

Browse files
committed
refactor: replace deprecated telemetry config active for app insights
1 parent 6e00f91 commit 71a0d97

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

Samples/AspNetCoreApp/Program.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
using System;
21
using Code.Library.AspNetCore.Helpers;
32
using Microsoft.AspNetCore.Hosting;
43
using Microsoft.Extensions.Hosting;
54
using Serilog;
5+
using System;
66

77
namespace AspNetCoreApp
88
{
@@ -14,7 +14,7 @@ public static IHostBuilder CreateHostBuilder(string[] args) =>
1414
{
1515
webBuilder.UseStartup<Startup>();
1616
})
17-
.UseSerilog((hostingContext, loggerConfiguration) => loggerConfiguration.WithSimpleConfiguration(hostingContext.Configuration));
17+
.UseSerilog((hostingContext, serviceProvider, loggerConfiguration) => loggerConfiguration.WithSimpleConfiguration(hostingContext.Configuration, serviceProvider));
1818

1919
public static int Main(string[] args)
2020
{

Samples/AspNetCoreApp/Startup.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ public void ConfigureServices(IServiceCollection services)
5555
services.AddApiExceptionHandler();
5656
services.AddHealthChecks();
5757
services.AddFlurlTelemetry();
58+
services.AddAppInsight(Configuration, "Code.Library Sample");
5859
}
5960
}
6061
}

src/Code.Library.AspNetCore/Helpers/SerilogHelper.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,15 @@
22
using Microsoft.ApplicationInsights.Extensibility;
33
using Microsoft.AspNetCore.Http;
44
using Microsoft.Extensions.Configuration;
5+
using Microsoft.Extensions.DependencyInjection;
56
using Serilog;
67
using Serilog.Events;
78
using Serilog.Formatting.Compact;
9+
using Serilog.Formatting.Elasticsearch;
810
using System;
911
using System.Collections.Generic;
1012
using System.Linq;
1113
using System.Reflection;
12-
using Serilog.Formatting.Elasticsearch;
1314

1415
namespace Code.Library.AspNetCore.Helpers
1516
{
@@ -88,7 +89,7 @@ public static Func<HttpContext, double, Exception, LogEventLevel> GetLevel(LogEv
8889
/// }
8990
/// </remarks>
9091
public static void WithSimpleConfiguration(this LoggerConfiguration loggerConfig,
91-
IConfiguration configuration)
92+
IConfiguration configuration, IServiceProvider serviceProvider)
9293
{
9394
var name = Assembly.GetEntryAssembly().GetName();
9495

@@ -99,8 +100,7 @@ public static void WithSimpleConfiguration(this LoggerConfiguration loggerConfig
99100
.Enrich.WithProperty("Assembly", $"{name.Name}")
100101
.Enrich.WithProperty("Version", $"{name.Version}")
101102
.Destructure.UsingAttributes()
102-
// TODO(abhith): find alternative for TelemetryConfiguration.Active
103-
.WriteTo.ApplicationInsights(TelemetryConfiguration.Active, TelemetryConverter.Traces);
103+
.WriteTo.ApplicationInsights(serviceProvider.GetRequiredService<TelemetryConfiguration>(), TelemetryConverter.Traces);
104104

105105
if (configuration.GetValue<bool>("Serilog:UseElasticsearchFormatter", false))
106106
{

0 commit comments

Comments
 (0)