Skip to content

isSidebarFitsViewport ignores top spacing! #151

@vinnydude

Description

@vinnydude

As the title says, the isSidebarFitsViewport function doesn't take into consideration the top spacing.

I've updated the function to be like this:

isSidebarFitsViewport(){ return this.dimensions.sidebarHeight + this.dimensions.topSpacing < this.dimensions.viewportHeight; }

It might want to take into consideration bottom spacing though as well.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions