feat: update BaseSerialize.serialize method to always accept containerResolver

Author: thetutlage

benchmarks/types.ts

@@ -1,14 +1,17 @@
 import { bench } from '@ark/attest'
-import { apiSerializer } from '../tests/helpers.ts'
+import { apiSerializer, container } from '../tests/helpers.ts'
 import { User } from '../tests/fixtures/models/user.ts'
 import { Post } from '../tests/fixtures/models/posts.ts'
 import { PostTransformer } from '../tests/fixtures/transformers/post.ts'
 import { UserTransformer } from '../tests/fixtures/transformers/user.ts'
 
-await apiSerializer.serialize(UserTransformer.transform(new User()))
+await apiSerializer.serialize(UserTransformer.transform(new User()), container.createResolver())
 
 bench('serialize', async () => {
   const post = new Post()
-  const postDataObject1 = await apiSerializer.serialize(PostTransformer.transform([post]))
+  const postDataObject1 = await apiSerializer.serialize(
+    PostTransformer.transform([post]),
+    container.createResolver()
+  )
   return { postDataObject1 }
 }).types([1, 'instantiations'])

src/base_serializer.ts

@@ -7,7 +7,7 @@
  * file that was distributed with this source code.
  */
 
-import { Container, type ContainerResolver } from '@adonisjs/fold'
+import { type ContainerResolver } from '@adonisjs/fold'
 import { RuntimeException } from '@poppinss/exception'
 
 import { Item } from './resource/item.ts'
@@ -94,7 +94,7 @@ export abstract class BaseSerializer<
    */
   serialize<Data extends Record<string, ResourceDataTypes | PaginatorContract<any>>>(
     data: Data,
-    container?: ContainerResolver<any>
+    resolver: ContainerResolver<any>
   ): Promise<UnpackTopLevelValues<Data>>
 
   /**
@@ -105,7 +105,7 @@ export abstract class BaseSerializer<
    */
   serialize<ResourceItem extends ItemContract<any, any, any>>(
     resource: ResourceItem,
-    container?: ContainerResolver<any>
+    resolver: ContainerResolver<any>
   ): Promise<UnpackAsTopLevelItem<ResourceItem, Wrappers['Wrap']>>
 
   /**
@@ -116,7 +116,7 @@ export abstract class BaseSerializer<
    */
   serialize<ResourceCollection extends CollectionContract<any, any, any>>(
     collection: ResourceCollection,
-    container?: ContainerResolver<any>
+    resolver: ContainerResolver<any>
   ): Promise<UnpackAsTopLevelCollection<ResourceCollection, Wrappers['Wrap']>>
 
   /**
@@ -127,7 +127,7 @@ export abstract class BaseSerializer<
    */
   serialize<ResourcePaginator extends PaginatorContract<any>>(
     paginator: ResourcePaginator,
-    container?: ContainerResolver<any>
+    resolver: ContainerResolver<any>
   ): Promise<
     UnpackAsTopLevelPaginator<
       ResourcePaginator,
@@ -142,16 +142,15 @@ export abstract class BaseSerializer<
    * @param value - The value to serialize
    * @param container - Optional container resolver for dependency injection
    */
-  serialize<Value>(value: Value, container?: ContainerResolver<any>): Promise<Value>
+  serialize<Value>(value: Value, container: ContainerResolver<any>): Promise<Value>
   serialize(
     data: Record<string, ResourceDataTypes> | Item<any, any, any> | Collection<any, any, any>,
-    container?: ContainerResolver<any>
+    resolver: ContainerResolver<any>
   ): Promise<any> {
     if (data === null) {
       throw new RuntimeException('Cannot serialize an item with null value')
     }
 
-    const resolver = container ?? new Container().createResolver()
     if (data instanceof Item) {
       return data.resolve(resolver, 0, -1).then((value) => this.#wrap(value, this.wrap))
     }

tests/helpers.ts

@@ -1,3 +1,4 @@
+import { Container } from '@adonisjs/fold'
 import { BaseSerializer } from '../src/base_serializer.ts'
 
 class ApiSerializer extends BaseSerializer<{
@@ -27,3 +28,4 @@ class WrappedApiSerializer extends BaseSerializer<{
 
 export const apiSerializer = new ApiSerializer()
 export const wrappedApiSerializer = new WrappedApiSerializer()
+export const container = new Container()