pylint near done

Author: agroce

.github/workflows/pylint.yml

@@ -19,7 +19,8 @@ jobs:
         python -m pip install --upgrade pip
         pip install python-levenshtein
         pip install tabulate
+        pip install comby
         pip install pylint
     - name: Analysing the code with pylint
       run: |
-        pylint $(git ls-files '*.py') --disable C0207,C0104,C0201,W0718,C0206,C0410,C0411,W0611,C0115,W0613,C0301,C0114,C0116,C0103,W1514,R1732,W1509,R0913,R0914,R1702,R0912,R0915,R0801,R0911,R0917
+        pylint $(git ls-files '*.py') --disable C0207,C0415,E0401,C0104,C0201,W0718,C0206,C0410,C0411,W0611,C0115,W0613,C0301,C0114,C0116,C0103,W1514,R1732,W1509,R0913,R0914,R1702,R0912,R0915,R0801,R0911,R0917

universalmutator/genmutants.py

@@ -77,6 +77,7 @@ def toGarbage(code):
             newCode += "Q"
     return newCode
 
+cmd = None
 
 def main():
     global cmd
@@ -416,7 +417,7 @@ def main():
                 if handlers[language].dumb:
                     noFastCheck = True
                     dumbHandler = True
-            except:
+            except BaseException:
                 pass
             handler = handlers[language].handler
     else:
@@ -539,7 +540,7 @@ def main():
     valid_rate = 0 if totalMutants == 0 else (len(validMutants) * 100.0)/totalMutants
     print(f"Valid Percentage: {valid_rate}%")
 
-    (rules, ignoreRules, skipRules) = mutator.parseRules(rules, comby= comby)
+    (rules, _, _) = mutator.parseRules(rules, comby= comby)
 
     if printStat:
         source = sourceJoined if comby else None
@@ -568,10 +569,15 @@ def dumpToFile(fileName, mutants):
             sys.stdout.flush()
 
             fis.write(f"{i}.\n")
-            fis.write(mutant[2][0]); fis.write('\n')
+            fis.write(mutant[2][0])
+            fis.write('\n')
             if source is not None:
-                fis.write("source:\n"); fis.write(source[mutant[0][0]:mutant[0][1]]); fis.write('\n')
-            fis.write("mutant:\n"); fis.write(mutant[1]); fis.write('\n\n')
+                fis.write("source:\n")
+                fis.write(source[mutant[0][0]:mutant[0][1]])
+                fis.write('\n')
+            fis.write("mutant:\n")
+            fis.write(mutant[1])
+            fis.write('\n\n')
         fis.close()
 
     validMutants, invalidMutants, redundantMutants = mutants
@@ -600,7 +606,7 @@ def printRulesStat(rules, validMutants, invalidMutants):
     table = []
     table.append(["#","Rule","No. of Valids", "No. of Invalids"])
 
-    for ((lhs, rhs), ruleUsed) in rules:
+    for ((lhs, rhs), _) in rules:
         if (lhs,rhs) not in valid_cnt:
             valid_cnt[(lhs,rhs)] = 0
         if (lhs,rhs) not in invalid_cnt:

universalmutator/mutator.py

@@ -53,7 +53,7 @@ def parseRules(ruleFiles, comby=False):
                 continue  # Allow blank lines and comments, just ignore lines without a transformation
         else:
             s = r.split(" ==> ")
-        
+
         if comby:
             lhs = s[0]
             lhs = lhs.rstrip() # Trailing whitespace in rule file will be treated significantly unless stripped, so strip it. If matching trailing whitespace is desired, then regex holes should be used.
@@ -80,14 +80,16 @@ def parseRules(ruleFiles, comby=False):
 
 
 
-def mutants_comby(source, ruleFiles=["universal.rules"], mutateTestCode=False, mutateBoth=False,
+def mutants_comby(source, ruleFiles=None, mutateTestCode=False, mutateBoth=False,
             ignorePatterns=None, ignoreStringOnly=False, fuzzing=False, language=".generic"):
+    if ruleFiles is None:
+        ruleFiles = ["universal.rules"]
     comby = Comby()
     print("MUTATING WITH RULES (COMBY):", ", ".join(ruleFiles))
-    (rules, ignoreRules, skipRules) = parseRules(ruleFiles, True)
+    (rules, ignoreRules, _) = parseRules(ruleFiles, True)
     for lhs in ignorePatterns:
-        ignoreRules.append(lhs) 
-    source = ''.join(source)    
+        ignoreRules.append(lhs)
+    source = ''.join(source)
     mutants = []
 
     # Lines that match with DO_NOT_MUTATE and other ignore rules will be skipped
@@ -100,9 +102,9 @@ def mutants_comby(source, ruleFiles=["universal.rules"], mutateTestCode=False, m
 
     # Instead of line-by-line x rule-by-rule iterate rule-by-rule x match-by-match.
     for ((lhs, rhs), ruleUsed) in rules:
-        try: 
+        try:
             for match in comby.matches(source, lhs, language=language):
-                environment = dict()
+                environment = {}
                 for entry in match.environment:
                     environment[entry] = match.environment.get(entry).fragment
                 mutant = comby.substitute(rhs, environment)
@@ -115,18 +117,20 @@ def mutants_comby(source, ruleFiles=["universal.rules"], mutateTestCode=False, m
                     if line in ignoreLines:
                         skipMutant = True
                         break
-                
+
                 if not skipMutant:
                     mutants.append((substitutionRange, mutant, ruleUsed, lineRange, (lhs,rhs)))
-        except JSONDecodeError as e:
+        except JSONDecodeError:
             continue
         except Exception as e:
             print(f"WARNING: Got exception {e} running rule {ruleUsed}")
             continue
     return mutants
 
-def mutants(source, ruleFiles=["universal.rules"], mutateTestCode=False, mutateBoth=False,
+def mutants(source, ruleFiles=None, mutateTestCode=False, mutateBoth=False,
             ignorePatterns=None, ignoreStringOnly=False, fuzzing=False):
+    if ruleFiles is None:
+        ruleFiles = ["universal.rules"]
     print("MUTATING WITH RULES:", ", ".join(ruleFiles))
 
     (rules, ignoreRules, skipRules) = parseRules(ruleFiles)
@@ -180,8 +184,8 @@ def mutants(source, ruleFiles=["universal.rules"], mutateTestCode=False, mutateB
                 skipp = skipRule.search(l, 0)
                 if skipp and (skipp.start() < skipPos):
                     skipPos = skipp.start()
-                    
-     
+
+
             p = lhs.search(l, 0)
 
             # skip mutating if match occurs at index >= skipPos
@@ -235,7 +239,7 @@ def mutants(source, ruleFiles=["universal.rules"], mutateTestCode=False, mutateB
                 if (mutant != l) and ((lineno, mutant) not in produced) and (not skipDueToString):
                     mutants.append((lineno, mutant, ruleUsed, (lhs,rhs)))
                     produced[(lineno, mutant)] = True
-                
+
                 p = lhs.search(l, p.start()+1) #search from the next position of the current match
             if abandon:
                 break

universalmutator/utils.py

@@ -145,7 +145,9 @@ def d(m1, m2, changeWeight=5.0, origWeight=0.1, mutantWeight=0.1, codeWeight=0.5
     return d
 
 
-def FPF(mlist, N, f=None, d=d, cutoff=0.0, verbose=True, avoid=[], mutantDir=None, sourceDir=None):
+def FPF(mlist, N, f=None, d=d, cutoff=0.0, verbose=True, avoid=None, mutantDir=None, sourceDir=None):
+    if avoid is None:
+        avoid = []
     if len(mlist) == 0:
         return mlist
     start = time.time()