External URL Call

[vordemberge]

Hej,

your idea for plugin is great and the perfect tool for big libraries.

Unfortunately you are making an external url call to https://overrideit.migoart.com/?=v0.3.9 whenever I try to open the plugin (my-command.js).

As I am not allowed to open external connections (and there a tracking codes in the html), the plugin is therefor not usable :(

Is there a plan to make the tool offline/firewall workable?

Cheers,
Hendrik

[ahmedmigo]

I am using the tracking for debugging the issues that people face since it is so hard to figure it out on every devices log.
But you can work offline with the plugin by un-comment line 45 in my-command.js and comment line 44
But you have to do this with every update of the plugin

[vordemberge]

Thank you for your quick answer!

My company blocks all the tracking, unfortunately it doesn't differ between ads and debugging.

The line 41 and 46 looks like this in my-command.js (overrideit.sketchplugin/Contents/Sketch):

41 /******/ // define getter function for harmony exports
42 /******/ __webpack_require__.d = function(exports, name, getter) {
43 /******/ if(!__webpack_require__.o(exports, name)) {
44 /******/ Object.defineProperty(exports, name, { enumerable: true, get: getter });
45 /******/ }
46 /******/ };

Do you mean the lines 12917 - 12921?

12917 if (Context.selection && Context.selection.count() != 0) {
12918 if (!browserWindow) {
12919 browserWindow = new sketch_module_web_view__WEBPACK_IMPORTED_MODULE_0___default.a(options);
12920 browserWindow.loadURL("https://overrideit.migoart.com/?=v0.3.9");
12921 //browserWindow.loadURL(require("../assets/index.html"));

If so, changing the comments doesn't work in Sketch 54.1

Thanks

[ahmedmigo]

sorry for late replay
you can use this link
https://www.dropbox.com/s/1dkfi0rj4aua0yt/overrideit.sketchplugin%202.zip?dl=0

[vordemberge]

Wow 😍
Thank you so much for sharing this version, your plugin works like a charm.
Should be a standard plugin for everyone!