Allow `address_components_of_type` for Geocoder::Result::Test

[loqimean]

Expected behavior

To have all methods or only this

Actual behavior

undefined method `address_components_of_type' for #<Geocoder::Result::Test:..

Steps to reproduce

mock request and run a test that calls an address_components_of_type method

Environment info

No one

• Geocoder version: latest
• Rails version: 7
• Database (if applicable): postgresql

[alexreisner]

Hmm, so this method is defined for the Google result classes because it's useful for handling the format in which Google's APIs return data. It's not relevant to other result types that have different structures. The Test result class reflects what's in the Base class. I'm not sure what you're trying to do that this is an issue. You might want to look at the Google unit tests to see how mocking is usually done in the test suite.

[todtb]

Hi @alexreisner. I think a use case for this might be when one is stubbing with the Geocoder::Lookup::Test class.

So while testing, say we have:

Geocoder.configure(lookup: :test)
Geocoder::Lookup::Test.add_stub('query', results)

this will obviously return a Geocoder::Result::Test.

If the application were using any of the lookup service specific methods, and one wanted to test around those specifically, that could result in a scenario like this.

One work around could be allowing this as a configurable item:

module Geocoder
  module Lookup
    class Test < Base

      private

      def result_class
        # return Geocoder.config[:test_result_class] if configured or call super
      end
    end
  end
end

Any thoughts on approaching it through configuration?