Skip to content

Commit 093f0b9

Browse files
authored
Simple support for DUMP and RESTORE (#405)
* constants for key types * shared logic for validating argument counts * simple support for DUMP and RESTORE * revert DebugDump rename
1 parent ef3d9f7 commit 093f0b9

File tree

7 files changed

+311
-182
lines changed

7 files changed

+311
-182
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ Implemented commands:
3636
- Key
3737
- COPY
3838
- DEL
39+
- DUMP -- partly, only handles string keys
3940
- EXISTS
4041
- EXPIRE
4142
- EXPIREAT
@@ -50,6 +51,7 @@ Implemented commands:
5051
- RANDOMKEY -- see m.Seed(...)
5152
- RENAME
5253
- RENAMENX
54+
- RESTORE -- partly, only handles string keys
5355
- SCAN
5456
- TOUCH
5557
- TTL
@@ -301,10 +303,8 @@ Commands which will probably not be implemented:
301303
- ~~READONLY~~
302304
- ~~READWRITE~~
303305
- Key
304-
- ~~DUMP~~
305306
- ~~MIGRATE~~
306307
- ~~OBJECT~~
307-
- ~~RESTORE~~
308308
- ~~WAIT~~
309309
- Scripting
310310
- ~~FCALL / FCALL_RO *~~

cmd_connection.go

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -213,12 +213,7 @@ func (m *Miniredis) cmdEcho(c *server.Peer, cmd string, args []string) {
213213

214214
// SELECT
215215
func (m *Miniredis) cmdSelect(c *server.Peer, cmd string, args []string) {
216-
if len(args) != 1 {
217-
setDirty(c)
218-
c.WriteError(errWrongNumber(cmd))
219-
return
220-
}
221-
if !m.isValidCMD(c, cmd) {
216+
if !m.isValidCMD(c, cmd, args, exactly(1)) {
222217
return
223218
}
224219

0 commit comments

Comments
 (0)