check: SPOP foo -1

Author: alicebob

cmd_set.go

@@ -364,6 +364,11 @@ func (m *Miniredis) cmdSpop(c *server.Peer, cmd string, args []string) {
 				c.WriteError(msgInvalidInt)
 				return
 			}
+			if v < 0 {
+				setDirty(c)
+				c.WriteError(msgOutOfRange)
+				return
+			}
 			count = v
 			withCount = true
 			args = args[1:]

cmd_set_test.go

@@ -305,6 +305,9 @@ func TestSpop(t *testing.T) {
 		members, err := s.Members("s")
 		ok(t, err)
 		assert(t, len(members) == 2, "SPOP s 2")
+
+		_, err = c.Do("SPOP", "str", -12)
+		mustFail(t, err, msgOutOfRange)
 	})
 }
 

integration/set_test.go

@@ -154,6 +154,7 @@ func TestSetSpop(t *testing.T) {
 
 		// failure cases
 		fail("SPOP", "foo", "one"),
+		fail("SPOP", "foo", -4),
 	)
 }