options are already optional

alicebob · alicebob · commit ed06249b665d · 2025-09-24T09:01:32.000+02:00
diff --git a/cmd_generic.go b/cmd_generic.go
@@ -32,28 +32,28 @@ func inMilliSeconds(t time.Time) int {
 func commandsGeneric(m *Miniredis) {
 	m.srv.Register("COPY", m.cmdCopy)
 	m.srv.Register("DEL", m.cmdDel)
-	m.srv.RegisterWithOptions("DUMP", m.cmdDump, server.ReadOnlyOption())
-	m.srv.RegisterWithOptions("EXISTS", m.cmdExists, server.ReadOnlyOption())
+	m.srv.Register("DUMP", m.cmdDump, server.ReadOnlyOption())
+	m.srv.Register("EXISTS", m.cmdExists, server.ReadOnlyOption())
 	m.srv.Register("EXPIRE", makeCmdExpire(m, false, time.Second))
 	m.srv.Register("EXPIREAT", makeCmdExpire(m, true, time.Second))
-	m.srv.RegisterWithOptions("EXPIRETIME", m.makeCmdExpireTime(inSeconds), server.ReadOnlyOption())
-	m.srv.RegisterWithOptions("PEXPIRETIME", m.makeCmdExpireTime(inMilliSeconds), server.ReadOnlyOption())
-	m.srv.RegisterWithOptions("KEYS", m.cmdKeys, server.ReadOnlyOption())
+	m.srv.Register("EXPIRETIME", m.makeCmdExpireTime(inSeconds), server.ReadOnlyOption())
+	m.srv.Register("PEXPIRETIME", m.makeCmdExpireTime(inMilliSeconds), server.ReadOnlyOption())
+	m.srv.Register("KEYS", m.cmdKeys, server.ReadOnlyOption())
 	// MIGRATE
 	m.srv.Register("MOVE", m.cmdMove)
 	// OBJECT
 	m.srv.Register("PERSIST", m.cmdPersist)
 	m.srv.Register("PEXPIRE", makeCmdExpire(m, false, time.Millisecond))
 	m.srv.Register("PEXPIREAT", makeCmdExpire(m, true, time.Millisecond))
-	m.srv.RegisterWithOptions("PTTL", m.cmdPTTL, server.ReadOnlyOption())
-	m.srv.RegisterWithOptions("RANDOMKEY", m.cmdRandomkey, server.ReadOnlyOption())
+	m.srv.Register("PTTL", m.cmdPTTL, server.ReadOnlyOption())
+	m.srv.Register("RANDOMKEY", m.cmdRandomkey, server.ReadOnlyOption())
 	m.srv.Register("RENAME", m.cmdRename)
 	m.srv.Register("RENAMENX", m.cmdRenamenx)
 	m.srv.Register("RESTORE", m.cmdRestore)
-	m.srv.RegisterWithOptions("TOUCH", m.cmdTouch, server.ReadOnlyOption())
-	m.srv.RegisterWithOptions("TTL", m.cmdTTL, server.ReadOnlyOption())
-	m.srv.RegisterWithOptions("TYPE", m.cmdType, server.ReadOnlyOption())
-	m.srv.RegisterWithOptions("SCAN", m.cmdScan, server.ReadOnlyOption())
+	m.srv.Register("TOUCH", m.cmdTouch, server.ReadOnlyOption())
+	m.srv.Register("TTL", m.cmdTTL, server.ReadOnlyOption())
+	m.srv.Register("TYPE", m.cmdType, server.ReadOnlyOption())
+	m.srv.Register("SCAN", m.cmdScan, server.ReadOnlyOption())
 	// SORT
 	m.srv.Register("UNLINK", m.cmdDel)
 }
diff --git a/cmd_geo.go b/cmd_geo.go
@@ -14,12 +14,12 @@ import (
 // commandsGeo handles GEOADD, GEORADIUS etc.
 func commandsGeo(m *Miniredis) {
 	m.srv.Register("GEOADD", m.cmdGeoadd)
-	m.srv.RegisterWithOptions("GEODIST", m.cmdGeodist, server.ReadOnlyOption())
-	m.srv.RegisterWithOptions("GEOPOS", m.cmdGeopos, server.ReadOnlyOption())
+	m.srv.Register("GEODIST", m.cmdGeodist, server.ReadOnlyOption())
+	m.srv.Register("GEOPOS", m.cmdGeopos, server.ReadOnlyOption())
 	m.srv.Register("GEORADIUS", m.cmdGeoradius)
-	m.srv.RegisterWithOptions("GEORADIUS_RO", m.cmdGeoradius, server.ReadOnlyOption())
+	m.srv.Register("GEORADIUS_RO", m.cmdGeoradius, server.ReadOnlyOption())
 	m.srv.Register("GEORADIUSBYMEMBER", m.cmdGeoradiusbymember)
-	m.srv.RegisterWithOptions("GEORADIUSBYMEMBER_RO", m.cmdGeoradiusbymember, server.ReadOnlyOption())
+	m.srv.Register("GEORADIUSBYMEMBER_RO", m.cmdGeoradiusbymember, server.ReadOnlyOption())
 }
 
 // GEOADD
diff --git a/cmd_hash.go b/cmd_hash.go
@@ -13,21 +13,21 @@ import (
 // commandsHash handles all hash value operations.
 func commandsHash(m *Miniredis) {
 	m.srv.Register("HDEL", m.cmdHdel)
-	m.srv.RegisterWithOptions("HEXISTS", m.cmdHexists, server.ReadOnlyOption())
-	m.srv.RegisterWithOptions("HGET", m.cmdHget, server.ReadOnlyOption())
-	m.srv.RegisterWithOptions("HGETALL", m.cmdHgetall, server.ReadOnlyOption())
+	m.srv.Register("HEXISTS", m.cmdHexists, server.ReadOnlyOption())
+	m.srv.Register("HGET", m.cmdHget, server.ReadOnlyOption())
+	m.srv.Register("HGETALL", m.cmdHgetall, server.ReadOnlyOption())
 	m.srv.Register("HINCRBY", m.cmdHincrby)
 	m.srv.Register("HINCRBYFLOAT", m.cmdHincrbyfloat)
-	m.srv.RegisterWithOptions("HKEYS", m.cmdHkeys, server.ReadOnlyOption())
-	m.srv.RegisterWithOptions("HLEN", m.cmdHlen, server.ReadOnlyOption())
-	m.srv.RegisterWithOptions("HMGET", m.cmdHmget, server.ReadOnlyOption())
+	m.srv.Register("HKEYS", m.cmdHkeys, server.ReadOnlyOption())
+	m.srv.Register("HLEN", m.cmdHlen, server.ReadOnlyOption())
+	m.srv.Register("HMGET", m.cmdHmget, server.ReadOnlyOption())
 	m.srv.Register("HMSET", m.cmdHmset)
 	m.srv.Register("HSET", m.cmdHset)
 	m.srv.Register("HSETNX", m.cmdHsetnx)
-	m.srv.RegisterWithOptions("HSTRLEN", m.cmdHstrlen, server.ReadOnlyOption())
-	m.srv.RegisterWithOptions("HVALS", m.cmdHvals, server.ReadOnlyOption())
-	m.srv.RegisterWithOptions("HSCAN", m.cmdHscan, server.ReadOnlyOption())
-	m.srv.RegisterWithOptions("HRANDFIELD", m.cmdHrandfield, server.ReadOnlyOption())
+	m.srv.Register("HSTRLEN", m.cmdHstrlen, server.ReadOnlyOption())
+	m.srv.Register("HVALS", m.cmdHvals, server.ReadOnlyOption())
+	m.srv.Register("HSCAN", m.cmdHscan, server.ReadOnlyOption())
+	m.srv.Register("HRANDFIELD", m.cmdHrandfield, server.ReadOnlyOption())
 }
 
 // HSET
diff --git a/cmd_hll.go b/cmd_hll.go
@@ -5,7 +5,7 @@ import "github.com/alicebob/miniredis/v2/server"
 // commandsHll handles all hll related operations.
 func commandsHll(m *Miniredis) {
 	m.srv.Register("PFADD", m.cmdPfadd)
-	m.srv.RegisterWithOptions("PFCOUNT", m.cmdPfcount, server.ReadOnlyOption())
+	m.srv.Register("PFCOUNT", m.cmdPfcount, server.ReadOnlyOption())
 	m.srv.Register("PFMERGE", m.cmdPfmerge)
 }
 
diff --git a/cmd_list.go b/cmd_list.go
@@ -22,14 +22,14 @@ func commandsList(m *Miniredis) {
 	m.srv.Register("BLPOP", m.cmdBlpop)
 	m.srv.Register("BRPOP", m.cmdBrpop)
 	m.srv.Register("BRPOPLPUSH", m.cmdBrpoplpush)
-	m.srv.RegisterWithOptions("LINDEX", m.cmdLindex, server.ReadOnlyOption())
-	m.srv.RegisterWithOptions("LPOS", m.cmdLpos, server.ReadOnlyOption())
+	m.srv.Register("LINDEX", m.cmdLindex, server.ReadOnlyOption())
+	m.srv.Register("LPOS", m.cmdLpos, server.ReadOnlyOption())
 	m.srv.Register("LINSERT", m.cmdLinsert)
-	m.srv.RegisterWithOptions("LLEN", m.cmdLlen, server.ReadOnlyOption())
+	m.srv.Register("LLEN", m.cmdLlen, server.ReadOnlyOption())
 	m.srv.Register("LPOP", m.cmdLpop)
 	m.srv.Register("LPUSH", m.cmdLpush)
 	m.srv.Register("LPUSHX", m.cmdLpushx)
-	m.srv.RegisterWithOptions("LRANGE", m.cmdLrange, server.ReadOnlyOption())
+	m.srv.Register("LRANGE", m.cmdLrange, server.ReadOnlyOption())
 	m.srv.Register("LREM", m.cmdLrem)
 	m.srv.Register("LSET", m.cmdLset)
 	m.srv.Register("LTRIM", m.cmdLtrim)
diff --git a/cmd_server.go b/cmd_server.go
@@ -13,7 +13,7 @@ import (
 
 func commandsServer(m *Miniredis) {
 	m.srv.Register("COMMAND", m.cmdCommand)
-	m.srv.RegisterWithOptions("DBSIZE", m.cmdDbsize, server.ReadOnlyOption())
+	m.srv.Register("DBSIZE", m.cmdDbsize, server.ReadOnlyOption())
 	m.srv.Register("FLUSHALL", m.cmdFlushall)
 	m.srv.Register("FLUSHDB", m.cmdFlushdb)
 	m.srv.Register("INFO", m.cmdInfo)
diff --git a/cmd_set.go b/cmd_set.go
@@ -13,22 +13,22 @@ import (
 // commandsSet handles all set value operations.
 func commandsSet(m *Miniredis) {
 	m.srv.Register("SADD", m.cmdSadd)
-	m.srv.RegisterWithOptions("SCARD", m.cmdScard, server.ReadOnlyOption())
-	m.srv.RegisterWithOptions("SDIFF", m.cmdSdiff, server.ReadOnlyOption())
+	m.srv.Register("SCARD", m.cmdScard, server.ReadOnlyOption())
+	m.srv.Register("SDIFF", m.cmdSdiff, server.ReadOnlyOption())
 	m.srv.Register("SDIFFSTORE", m.cmdSdiffstore)
-	m.srv.RegisterWithOptions("SINTERCARD", m.cmdSintercard, server.ReadOnlyOption())
-	m.srv.RegisterWithOptions("SINTER", m.cmdSinter, server.ReadOnlyOption())
+	m.srv.Register("SINTERCARD", m.cmdSintercard, server.ReadOnlyOption())
+	m.srv.Register("SINTER", m.cmdSinter, server.ReadOnlyOption())
 	m.srv.Register("SINTERSTORE", m.cmdSinterstore)
-	m.srv.RegisterWithOptions("SISMEMBER", m.cmdSismember, server.ReadOnlyOption())
-	m.srv.RegisterWithOptions("SMEMBERS", m.cmdSmembers, server.ReadOnlyOption())
-	m.srv.RegisterWithOptions("SMISMEMBER", m.cmdSmismember, server.ReadOnlyOption())
+	m.srv.Register("SISMEMBER", m.cmdSismember, server.ReadOnlyOption())
+	m.srv.Register("SMEMBERS", m.cmdSmembers, server.ReadOnlyOption())
+	m.srv.Register("SMISMEMBER", m.cmdSmismember, server.ReadOnlyOption())
 	m.srv.Register("SMOVE", m.cmdSmove)
 	m.srv.Register("SPOP", m.cmdSpop)
-	m.srv.RegisterWithOptions("SRANDMEMBER", m.cmdSrandmember, server.ReadOnlyOption())
+	m.srv.Register("SRANDMEMBER", m.cmdSrandmember, server.ReadOnlyOption())
 	m.srv.Register("SREM", m.cmdSrem)
-	m.srv.RegisterWithOptions("SUNION", m.cmdSunion, server.ReadOnlyOption())
+	m.srv.Register("SUNION", m.cmdSunion, server.ReadOnlyOption())
 	m.srv.Register("SUNIONSTORE", m.cmdSunionstore)
-	m.srv.RegisterWithOptions("SSCAN", m.cmdSscan, server.ReadOnlyOption())
+	m.srv.Register("SSCAN", m.cmdSscan, server.ReadOnlyOption())
 }
 
 // SADD
diff --git a/cmd_sorted_set.go b/cmd_sorted_set.go
@@ -16,32 +16,32 @@ import (
 // commandsSortedSet handles all sorted set operations.
 func commandsSortedSet(m *Miniredis) {
 	m.srv.Register("ZADD", m.cmdZadd)
-	m.srv.RegisterWithOptions("ZCARD", m.cmdZcard, server.ReadOnlyOption())
-	m.srv.RegisterWithOptions("ZCOUNT", m.cmdZcount, server.ReadOnlyOption())
+	m.srv.Register("ZCARD", m.cmdZcard, server.ReadOnlyOption())
+	m.srv.Register("ZCOUNT", m.cmdZcount, server.ReadOnlyOption())
 	m.srv.Register("ZINCRBY", m.cmdZincrby)
-	m.srv.RegisterWithOptions("ZINTER", m.makeCmdZinter(false), server.ReadOnlyOption())
+	m.srv.Register("ZINTER", m.makeCmdZinter(false), server.ReadOnlyOption())
 	m.srv.Register("ZINTERSTORE", m.makeCmdZinter(true))
-	m.srv.RegisterWithOptions("ZLEXCOUNT", m.cmdZlexcount, server.ReadOnlyOption())
-	m.srv.RegisterWithOptions("ZRANGE", m.cmdZrange, server.ReadOnlyOption())
-	m.srv.RegisterWithOptions("ZRANGEBYLEX", m.makeCmdZrangebylex(false), server.ReadOnlyOption())
-	m.srv.RegisterWithOptions("ZRANGEBYSCORE", m.makeCmdZrangebyscore(false), server.ReadOnlyOption())
-	m.srv.RegisterWithOptions("ZRANK", m.makeCmdZrank(false), server.ReadOnlyOption())
+	m.srv.Register("ZLEXCOUNT", m.cmdZlexcount, server.ReadOnlyOption())
+	m.srv.Register("ZRANGE", m.cmdZrange, server.ReadOnlyOption())
+	m.srv.Register("ZRANGEBYLEX", m.makeCmdZrangebylex(false), server.ReadOnlyOption())
+	m.srv.Register("ZRANGEBYSCORE", m.makeCmdZrangebyscore(false), server.ReadOnlyOption())
+	m.srv.Register("ZRANK", m.makeCmdZrank(false), server.ReadOnlyOption())
 	m.srv.Register("ZREM", m.cmdZrem)
 	m.srv.Register("ZREMRANGEBYLEX", m.cmdZremrangebylex)
 	m.srv.Register("ZREMRANGEBYRANK", m.cmdZremrangebyrank)
 	m.srv.Register("ZREMRANGEBYSCORE", m.cmdZremrangebyscore)
-	m.srv.RegisterWithOptions("ZREVRANGE", m.cmdZrevrange, server.ReadOnlyOption())
-	m.srv.RegisterWithOptions("ZREVRANGEBYLEX", m.makeCmdZrangebylex(true), server.ReadOnlyOption())
-	m.srv.RegisterWithOptions("ZREVRANGEBYSCORE", m.makeCmdZrangebyscore(true), server.ReadOnlyOption())
-	m.srv.RegisterWithOptions("ZREVRANK", m.makeCmdZrank(true), server.ReadOnlyOption())
-	m.srv.RegisterWithOptions("ZSCORE", m.cmdZscore, server.ReadOnlyOption())
-	m.srv.RegisterWithOptions("ZMSCORE", m.cmdZMscore, server.ReadOnlyOption())
-	m.srv.RegisterWithOptions("ZUNION", m.cmdZunion, server.ReadOnlyOption())
+	m.srv.Register("ZREVRANGE", m.cmdZrevrange, server.ReadOnlyOption())
+	m.srv.Register("ZREVRANGEBYLEX", m.makeCmdZrangebylex(true), server.ReadOnlyOption())
+	m.srv.Register("ZREVRANGEBYSCORE", m.makeCmdZrangebyscore(true), server.ReadOnlyOption())
+	m.srv.Register("ZREVRANK", m.makeCmdZrank(true), server.ReadOnlyOption())
+	m.srv.Register("ZSCORE", m.cmdZscore, server.ReadOnlyOption())
+	m.srv.Register("ZMSCORE", m.cmdZMscore, server.ReadOnlyOption())
+	m.srv.Register("ZUNION", m.cmdZunion, server.ReadOnlyOption())
 	m.srv.Register("ZUNIONSTORE", m.cmdZunionstore)
-	m.srv.RegisterWithOptions("ZSCAN", m.cmdZscan, server.ReadOnlyOption())
+	m.srv.Register("ZSCAN", m.cmdZscan, server.ReadOnlyOption())
 	m.srv.Register("ZPOPMAX", m.cmdZpopmax(true))
 	m.srv.Register("ZPOPMIN", m.cmdZpopmax(false))
-	m.srv.RegisterWithOptions("ZRANDMEMBER", m.cmdZrandmember, server.ReadOnlyOption())
+	m.srv.Register("ZRANDMEMBER", m.cmdZrandmember, server.ReadOnlyOption())
 }
 
 // ZADD
diff --git a/cmd_stream.go b/cmd_stream.go
@@ -16,16 +16,16 @@ import (
 // commandsStream handles all stream operations.
 func commandsStream(m *Miniredis) {
 	m.srv.Register("XADD", m.cmdXadd)
-	m.srv.RegisterWithOptions("XLEN", m.cmdXlen, server.ReadOnlyOption())
-	m.srv.RegisterWithOptions("XREAD", m.cmdXread, server.ReadOnlyOption())
-	m.srv.RegisterWithOptions("XRANGE", m.makeCmdXrange(false), server.ReadOnlyOption())
-	m.srv.RegisterWithOptions("XREVRANGE", m.makeCmdXrange(true), server.ReadOnlyOption())
+	m.srv.Register("XLEN", m.cmdXlen, server.ReadOnlyOption())
+	m.srv.Register("XREAD", m.cmdXread, server.ReadOnlyOption())
+	m.srv.Register("XRANGE", m.makeCmdXrange(false), server.ReadOnlyOption())
+	m.srv.Register("XREVRANGE", m.makeCmdXrange(true), server.ReadOnlyOption())
 	m.srv.Register("XGROUP", m.cmdXgroup)
 	m.srv.Register("XINFO", m.cmdXinfo)
 	m.srv.Register("XREADGROUP", m.cmdXreadgroup)
 	m.srv.Register("XACK", m.cmdXack)
 	m.srv.Register("XDEL", m.cmdXdel)
-	m.srv.RegisterWithOptions("XPENDING", m.cmdXpending, server.ReadOnlyOption())
+	m.srv.Register("XPENDING", m.cmdXpending, server.ReadOnlyOption())
 	m.srv.Register("XTRIM", m.cmdXtrim)
 	m.srv.Register("XAUTOCLAIM", m.cmdXautoclaim)
 	m.srv.Register("XCLAIM", m.cmdXclaim)
diff --git a/cmd_string.go b/cmd_string.go
@@ -14,21 +14,21 @@ import (
 // commandsString handles all string value operations.
 func commandsString(m *Miniredis) {
 	m.srv.Register("APPEND", m.cmdAppend)
-	m.srv.RegisterWithOptions("BITCOUNT", m.cmdBitcount, server.ReadOnlyOption())
+	m.srv.Register("BITCOUNT", m.cmdBitcount, server.ReadOnlyOption())
 	m.srv.Register("BITOP", m.cmdBitop)
-	m.srv.RegisterWithOptions("BITPOS", m.cmdBitpos, server.ReadOnlyOption())
+	m.srv.Register("BITPOS", m.cmdBitpos, server.ReadOnlyOption())
 	m.srv.Register("DECRBY", m.cmdDecrby)
 	m.srv.Register("DECR", m.cmdDecr)
-	m.srv.RegisterWithOptions("GETBIT", m.cmdGetbit, server.ReadOnlyOption())
-	m.srv.RegisterWithOptions("GET", m.cmdGet, server.ReadOnlyOption())
+	m.srv.Register("GETBIT", m.cmdGetbit, server.ReadOnlyOption())
+	m.srv.Register("GET", m.cmdGet, server.ReadOnlyOption())
 	m.srv.Register("GETEX", m.cmdGetex)
-	m.srv.RegisterWithOptions("GETRANGE", m.cmdGetrange, server.ReadOnlyOption())
+	m.srv.Register("GETRANGE", m.cmdGetrange, server.ReadOnlyOption())
 	m.srv.Register("GETSET", m.cmdGetset)
 	m.srv.Register("GETDEL", m.cmdGetdel)
 	m.srv.Register("INCRBYFLOAT", m.cmdIncrbyfloat)
 	m.srv.Register("INCRBY", m.cmdIncrby)
 	m.srv.Register("INCR", m.cmdIncr)
-	m.srv.RegisterWithOptions("MGET", m.cmdMget, server.ReadOnlyOption())
+	m.srv.Register("MGET", m.cmdMget, server.ReadOnlyOption())
 	m.srv.Register("MSET", m.cmdMset)
 	m.srv.Register("MSETNX", m.cmdMsetnx)
 	m.srv.Register("PSETEX", m.cmdPsetex)
@@ -37,7 +37,7 @@ func commandsString(m *Miniredis) {
 	m.srv.Register("SET", m.cmdSet)
 	m.srv.Register("SETNX", m.cmdSetnx)
 	m.srv.Register("SETRANGE", m.cmdSetrange)
-	m.srv.RegisterWithOptions("STRLEN", m.cmdStrlen, server.ReadOnlyOption())
+	m.srv.Register("STRLEN", m.cmdStrlen, server.ReadOnlyOption())
 }
 
 // SET
diff --git a/server/server.go b/server/server.go
@@ -143,13 +143,7 @@ func (s *Server) Close() {
 
 // Register a command. It can't have been registered before. Safe to call on a
 // running server.
-func (s *Server) Register(cmd string, f Cmd) error {
-	return s.RegisterWithOptions(cmd, f)
-}
-
-// RegisterWithOptions registers a command with optional metadata. It can't have
-// been registered before. Safe to call on a running server.
-func (s *Server) RegisterWithOptions(cmd string, f Cmd, options ...CmdOption) error {
+func (s *Server) Register(cmd string, f Cmd, options ...CmdOption) error {
 	s.mu.Lock()
 	defer s.mu.Unlock()
 	cmd = strings.ToUpper(cmd)
@@ -161,12 +155,11 @@ func (s *Server) RegisterWithOptions(cmd string, f Cmd, options ...CmdOption) er
 		handler:  f,
 		readOnly: false,
 	}
-
 	for _, option := range options {
 		option(meta)
 	}
-
 	s.cmds[cmd] = meta
+
 	return nil
 }
 
diff --git a/server/server_test.go b/server/server_test.go
@@ -273,7 +273,6 @@ func TestFormatFloat(t *testing.T) {
 }
 
 func TestReadOnlyOption(t *testing.T) {
-	// Create a new server
 	srv, err := NewServer("127.0.0.1:0")
 	if err != nil {
 		t.Fatalf("Failed to create server: %v", err)
@@ -285,34 +284,26 @@ func TestReadOnlyOption(t *testing.T) {
 		c.WriteOK()
 	}
 
-	// Register a read-only command
-	err = srv.RegisterWithOptions("TESTGET", testHandler, ReadOnlyOption())
-	if err != nil {
+	if err := srv.Register("TESTGET", testHandler, ReadOnlyOption()); err != nil {
 		t.Fatalf("Failed to register read-only command: %v", err)
 	}
 
-	// Register a write command (default)
-	err = srv.Register("TESTSET", testHandler)
-	if err != nil {
+	if err := srv.Register("TESTSET", testHandler); err != nil {
 		t.Fatalf("Failed to register write command: %v", err)
 	}
 
-	// Test that TESTGET is marked as read-only
 	if !srv.IsReadOnlyCommand("TESTGET") {
 		t.Error("TESTGET should be marked as read-only")
 	}
 
-	// Test that TESTSET is not marked as read-only
 	if srv.IsReadOnlyCommand("TESTSET") {
 		t.Error("TESTSET should not be marked as read-only")
 	}
 
-	// Test case insensitivity
 	if !srv.IsReadOnlyCommand("testget") {
 		t.Error("Command checking should be case insensitive")
 	}
 
-	// Test non-existent command
 	if srv.IsReadOnlyCommand("NONEXISTENT") {
 		t.Error("Non-existent command should return false")
 	}

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@ import "github.com/alicebob/miniredis/v2/server"`
`5`	`5`	`// commandsHll handles all hll related operations.`
`6`	`6`	`func commandsHll(m *Miniredis) {`
`7`	`7`	`m.srv.Register("PFADD", m.cmdPfadd)`
`8`		`- m.srv.RegisterWithOptions("PFCOUNT", m.cmdPfcount, server.ReadOnlyOption())`
	`8`	`+ m.srv.Register("PFCOUNT", m.cmdPfcount, server.ReadOnlyOption())`
`9`	`9`	`m.srv.Register("PFMERGE", m.cmdPfmerge)`
`10`	`10`	`}`
`11`	`11`